48505 Commits

This Branch

This Branch

All Branches

• Remove unused using
  Dan Balasescu · 2022-01-28 15:26:29 +09:00
  32f9299fe0
• Ensure hold for menu button fades out if the cursor is never moved

  Closes https://github.com/ppy/osu/discussions/16669.

  Dean Herbert · 2022-01-28 14:48:35 +09:00
  28c8e07e3f
• Bring HoldForMenuButton tests up-to-date in code quality
  Dean Herbert · 2022-01-28 14:48:17 +09:00
  f32d56e213
• Merge pull request #16647 from peppy/song-select-scroll-position-during-delete

  Ensure beatmap carousel scroll position is maintained during deletion operations

  Bartłomiej Dach · 2022-01-27 21:22:15 +01:00
  d1158acb82
• Merge branch 'master' into song-select-scroll-position-during-delete
  Bartłomiej Dach · 2022-01-27 20:46:19 +01:00
  04d6ca59a3
• Merge pull request #16657 from peppy/skip-scores-missing-beatmap

  Skip scores missing beatmaps during realm migration

  Dean Herbert · 2022-01-28 01:33:12 +09:00
  2022.128.0 6beb0ff2a4
• Merge pull request #16659 from bdach/fix-tournament-not-loading

  Fix tournament client not loading

  Dean Herbert · 2022-01-28 01:32:59 +09:00
  8508e0d512
• Fix tournament client not loading

  Caused by a `LoadComponentsAsync()` call being fired from a worker
  thread, which will throw exceptions since the recent addition of safety
  checks around that method.

  Bartłomiej Dach · 2022-01-27 17:31:12 +01:00
  9deeaee404
• Skip scores missing beatmaps during realm migration
  Dean Herbert · 2022-01-28 01:20:32 +09:00
  942ea896f1
• Merge pull request #16652 from peppy/skip-beatmaps-missing-ruleset
  Salman Ahmed · 2022-01-27 19:09:28 +03:00
  96f86d035d
• Skip beatmap imports where ruleset is not present in realm

  Closes #16651.
  
  When a ruleset is not available, the `Find` call would return null. When
  a null is passed to the constructor, `BeatmapInfo` would create an "osu"
  ruleset, which tries to get stored to realm and fails on duplicate
  primary key.
  
  Probably need to add better safeties against this (or change that
  constructor...) but this will fix the migration process.
  
  Probably not serious enough to pull the build. This only affects
  rulesets like karaoke which have custom beatmaps.

  Dean Herbert · 2022-01-28 00:14:20 +09:00
  81461be49f
• Merge pull request #16648 from peppy/fix-song-select-tests

  Fix song select tests not waiting for beatmap imports to arrive

  Dean Herbert · 2022-01-27 23:00:58 +09:00
  e872877185
• Merge pull request #16641 from peppy/ruleset-ordering-fix

  Add more encompassing stable ordering of rulesets

  Dan Balasescu · 2022-01-27 22:41:07 +09:00
  2022.127.0 99bc679a22
• Move nulling of previous songSelect to SetUpSteps instead
  Dean Herbert · 2022-01-27 21:59:44 +09:00
  fae4f8bd8e
• Use a more correct CompareTo implementation for ruleset ordering
  Dean Herbert · 2022-01-27 21:58:04 +09:00
  2d1a8a9d49
• Update pointless CompareTo implementation
  Dean Herbert · 2022-01-27 21:49:33 +09:00
  33b7bdcf82
• Merge branch 'master' into ruleset-ordering-fix
  Dean Herbert · 2022-01-27 21:46:03 +09:00
  7af23328a4
• Merge pull request #16644 from peppy/ruleset-id-fixes

  Update all usages of `RulesetID` and `Ruleset.ID` to use `Ruleset.OnlineID`

  Dean Herbert · 2022-01-27 21:44:22 +09:00
  d7fd11a16d
• Fix song select tests not waiting for beatmap imports to arrive

  After the change to realm, notification fires could take a frame or two.
  We aren't accounting for this.
  
  Fixes test failures like
  https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true

  Dean Herbert · 2022-01-27 19:35:42 +09:00
  831fa44433
• Merge pull request #16645 from peppy/fix-button-system-crash

  Fix `ButtonSystem` null reference crash due to missing null check in delayed animations

  Dean Herbert · 2022-01-27 17:09:46 +09:00
  df9f969030
• Fix compilation error due to commit split
  Dean Herbert · 2022-01-27 17:08:31 +09:00
  3ae5973ab7
• Merge branch 'master' into ruleset-id-fixes
  Dean Herbert · 2022-01-27 17:07:18 +09:00
  a5d422e82c
• Merge pull request #16637 from bdach/editor-changes-not-resetting

  Fix changes to beatmap info made in editor persisting after exit without save

  Dean Herbert · 2022-01-27 17:02:42 +09:00
  29a4ec949f
• Add failing test coverage showing carousel deletions don't keep scroll position
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  f2cecad83b
• Ensure beatmap carousel scroll position is maintained during deletion operations
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  449e9bcf5c
• Remove unnecessary double-schedule in UpdateBeatmapSet
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  0a45aa80cb
• Merge pull request #16642 from peppy/ruleset-private-info-set

  Make `Ruleset.RulesetInfo` get only

  Dan Balasescu · 2022-01-27 16:41:52 +09:00
  54d18bd7ac
• Merge pull request #16643 from peppy/ruleset-silly-ctor

  Remove pointless constructor in `RulesetInfo`

  Dan Balasescu · 2022-01-27 16:41:38 +09:00
  81ba1558de
• Fix ButtonSystem null reference crash due to missing null check in delayed animations

  ```csharp
  [runtime] 2022-01-27 07:36:34 [error]: System.NullReferenceException: Object reference not set to an instance of an object.
  [runtime] 2022-01-27 07:36:34 [error]: at osu.Game.Screens.Menu.ButtonSystem.<>c__DisplayClass56_0.<updateLogoState>b__1() in /Users/dean/Projects/osu/osu.Game/Screens/Menu/ButtonSystem.cs:line 357
  [runtime] 2022-01-27 07:36:34 [error]: at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
  [runtime] 2022-01-27 07:36:34 [error]: at osu.Framework.Threading.Scheduler.Update()
  [runtime] 2022-01-27 07:36:34 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
  ```

  Dean Herbert · 2022-01-27 16:39:38 +09:00
  b87d1a61a8
• Perform ordering using IComparable instead
  Dean Herbert · 2022-01-27 15:59:20 +09:00
  5637fd64d6
• Merge pull request #16640 from peppy/realm-migration-always-delete

  Improve realm migration UX to give users a recovery path on error

  Dan Balasescu · 2022-01-27 15:43:14 +09:00
  9ff2b9eb95
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Remove pointless constructor in RulesetInfo
  Dean Herbert · 2022-01-27 15:37:27 +09:00
  714177cce1
• Make Ruleset.RulesetInfo get only
  Dean Herbert · 2022-01-27 15:36:35 +09:00
  e67b1fe0ec
• Add SortID to RulesetInfo to allow stable ordering of rulesets for display
  Dean Herbert · 2022-01-27 15:35:16 +09:00
  f30d63107a
• Merge pull request #16639 from peppy/ef-db-delete-retry

  Add more attempts to delete EF database

  Dan Balasescu · 2022-01-27 15:31:40 +09:00
  cc0a8db76a
• Add exception message to discussion template url
  Dean Herbert · 2022-01-27 14:56:04 +09:00
  67ccb87992
• Add safety against zip creation potentially failing (probably can't but still)
  Dean Herbert · 2022-01-27 14:55:52 +09:00
  fb081384e1
• Avoid showing the external link warning
  Dean Herbert · 2022-01-27 14:53:11 +09:00
  465e7d29fe
• Automatically zip and show the backup archive to the user
  Dean Herbert · 2022-01-27 14:52:58 +09:00
  31abb372e5
• Move backups to "backups" subfolder to make them easier to find
  Dean Herbert · 2022-01-27 14:39:13 +09:00
  08948f60f3
• Show notification when migration fails to give users a recovery path
  Dean Herbert · 2022-01-27 14:39:11 +09:00
  b745252962
• Change migration process to always delete old EF database

  It is already backed up, so this is probably fine.

  Dean Herbert · 2022-01-27 14:33:46 +09:00
  deb5d75b5f
• Add more attempts to delete EF database

  Just noticed in passing. Probably best we do this since it was known to
  fail on windows in some rare cases.

  Dean Herbert · 2022-01-27 14:32:21 +09:00
  587c0f965c
• Fix test gameplay tests failing due to beatmap refetch on suspend
  Bartłomiej Dach · 2022-01-26 21:15:49 +01:00
  e0616476e2
• Ensure edited beatmap is restored to a baseline state on exit
  Bartłomiej Dach · 2022-01-26 21:15:49 +01:00
  d760283665
• Add test coverage for editor changes not resetting after exit without save
  Bartłomiej Dach · 2022-01-26 21:15:49 +01:00
  4382adad82
• Merge pull request #16632 from LumpBloom7/Third-party-ruleset-filter-fix

  Fix ruleset filters not working correctly on song select

  Bartłomiej Dach · 2022-01-26 19:24:06 +01:00
  de5ac7ad83
• Merge branch 'master' into Third-party-ruleset-filter-fix
  Bartłomiej Dach · 2022-01-26 18:54:20 +01:00
  df9658641c
• Merge pull request #16633 from peppy/fix-collection-migration

  Block collection loading until realm migration has completed

  Bartłomiej Dach · 2022-01-26 18:12:19 +01:00
  b7aa26bc5f