67746 Commits

This Branch

This Branch

All Branches

• Compile regexes for speed
  Bartłomiej Dach · 2024-07-03 15:49:21 +02:00
  32b3d3d7df
• Address code quality issues
  Bartłomiej Dach · 2024-07-03 15:49:17 +02:00
  901fec65ef
• Fix test method names
  Arthur Araujo · 2024-07-02 21:12:15 -03:00
  21829e7ef4
• Make MarkerChecks and MarkerCheck class private
  Arthur Araujo · 2024-07-02 21:09:49 -03:00
  7143ff523f
• Fix explicit array type specification in MarkerChecks
  Arthur Araujo · 2024-07-02 20:55:52 -03:00
  7cdad20119
• Add verify checks for title markers
  Arthur Araujo · 2024-07-02 17:20:00 -03:00
  7cb3d7445c
• Merge pull request #28689 from smoogipoo/fix-break-conversion

  Fix `ManiaModInvert` permanently destroying the beatmap

  Bartłomiej Dach · 2024-07-02 07:53:16 +02:00
  3bf3e9133b
• Merge pull request #28660 from mcendu/no-release-mod

  Add "No Release" mod

  Dan Balasescu · 2024-07-02 12:46:27 +09:00
  00462f6d56
• Remove unused code
  Dan Balasescu · 2024-07-02 12:21:24 +09:00
  31edca866c
• Revert "Change breaks list to IReadOnlyList"

  This reverts commit 2c3b411bb5.

  Dan Balasescu · 2024-07-02 12:16:11 +09:00
  04da1209f7
• Revert "Move break cloning back to non-virtual method"

  This reverts commit f69bc40a4b.

  Dan Balasescu · 2024-07-02 12:16:10 +09:00
  db84711214
• Move break cloning back to non-virtual method
  Dean Herbert · 2024-07-02 12:07:13 +09:00
  f69bc40a4b
• Change breaks list to IReadOnlyList
  Dean Herbert · 2024-07-02 11:59:24 +09:00
  2c3b411bb5
• Fix typo in xmldoc
  Dean Herbert · 2024-07-02 11:47:40 +09:00
  f694ae416e
• Isolate bindable breaks list to EditorBeatmap
  Dean Herbert · 2024-07-02 11:31:55 +09:00
  005af280f2
• Rewrite no release mod

  Per the request of spaceman_atlas, the No Release mod is rewritten to
  avoid modifications to DrawableHoldNoteTail. The approach is based
  on that of the Strict Tracking mod for the osu!(standard) ruleset,
  injecting the mod behavior by replacing the normal hold note with
  the mod's variant. The variant inherits most bevaior from the normal
  hold note, but when creating nested hitobjects, it creates its own
  hold note tail variant instead, which in turn is used to instantiate
  the mod's variant of DrawableHoldNoteTail with a new behavior.
  
  The time a judgement is awarded is changed from the end of its
  Perfect window to the time of the tail itself.

  Nathan Du · 2024-07-01 20:29:30 +08:00
  1eb10e029c
• Fix ManiaModInvert permanently messing up the beatmap
  Dan Balasescu · 2024-07-01 15:02:00 +09:00
  f942595829
• Add failing test
  Dan Balasescu · 2024-07-01 15:02:00 +09:00
  4cb58fbe47
• Merge pull request #28657 from peppy/playfield-skin-components-respect-border

  Change "playfield" skin layer to respect shifting playfield border in osu! ruleset

  Dean Herbert · 2024-07-01 10:35:15 +09:00
  56f4f40334
• Merge pull request #28686 from peppy/fix-summary-timeline-break-display

  Fix summary timeline not correctly updating after changes to breaks

  Dan Balasescu · 2024-07-01 10:03:16 +09:00
  2f9bce5274
• Fix summary timeline not correctly updating after changes to breaks

  Closes https://github.com/ppy/osu/issues/28678.
  
  Oops.

  Dean Herbert · 2024-06-30 20:32:16 +09:00
  8bb51d5a4f
• formatting
  Nathan Du · 2024-06-29 16:46:16 +08:00
  463ab46fee
• add tests for No Release mod

  The new test scene is essentially a copy of TestSceneHoldNoteInput,
  modified to test the judgement changes applied by the new mod. A base
  class might need to be abstracted out for them.

  Nathan Du · 2024-06-29 16:20:07 +08:00
  679f4735b3
• Initial implemention of the No Release mod

  This commit adds a new osu!mania mod No Release that relaxes tail
  judgements. The current implementation automatically awards Perfect
  (or Meh if the hold note is broken midway) for a hold note tail at
  the end of its Perfect window, as long as it is held by then.
  
  Tests are pending for the next commit.

  Nathan Du · 2024-06-28 22:21:08 +08:00
  960d552dc1
• Merge pull request #25725 from smoogipoo/fix-juicestream-velocity

  Fix JuiceStream velocity calculation

  Bartłomiej Dach · 2024-06-28 13:42:44 +02:00
  18f4fac4c1
• Merge pull request #26465 from LeNitrous/fix/editor-test-exit

  Fix editor test play not marking hit objects before its start time as judged.

  Bartłomiej Dach · 2024-06-28 12:12:17 +02:00
  81c6da98c2
• Add test for correct juice stream tick counts in editor

  cda9440a29 inadvertently fixes this in the
  most frequent case by inverting the `TickDistanceMultiplier` from being
  not-1 to 1 on beatmap versions above v8.
  
  This can still potentially go wrong if a beatmap from a version below v8
  is edited, because upon save it will be reencoded at the latest version,
  meaning that the multiplier will change from not-1 to 1 - but this can
  be handled separately.

  Bartłomiej Dach · 2024-06-28 11:58:07 +02:00
  deeb2e99a2
• Merge branch 'master' into fix-juicestream-velocity
  Bartłomiej Dach · 2024-06-28 11:47:39 +02:00
  c70a72ece8
• Change "playfield" skin layer to respect shifting playfield border in osu! ruleset
  Dean Herbert · 2024-06-28 18:12:20 +09:00
  55b80f70f6
• Merge pull request #28636 from bdach/daily-challenge/watch-room

  Add client/server models for allowing clients to receive realtime playlist updates

  Dean Herbert · 2024-06-28 17:51:40 +09:00
  4bb8a45d75
• Merge pull request #28653 from peppy/featured-artist-even-more-visible

  Update beatmap listing filter overlay to better imply selected filters

  Bartłomiej Dach · 2024-06-28 09:50:21 +02:00
  007bd3973a
• Fix formatting
  Bartłomiej Dach · 2024-06-28 09:45:45 +02:00
  a3ea36d2b2
• Ensure past drawable objects also get their results populated in editor test play
  Bartłomiej Dach · 2024-06-28 09:37:10 +02:00
  7ac5bd4d37
• Expand test coverage

  - Covers fail case that wasn't covered before
  - Removes arbitrary wait step that was inevitably going to cause
    intermittent test failures

  Bartłomiej Dach · 2024-06-28 09:30:28 +02:00
  ace6427d40
• Merge branch 'master' into fix/editor-test-exit
  Bartłomiej Dach · 2024-06-28 09:17:40 +02:00
  b36e0f0875
• Fix vertical overlaps on multiselection filters when they wrap
  Bartłomiej Dach · 2024-06-28 09:07:29 +02:00
  030bbf2641
• Merge pull request #28652 from smoogipoo/fix-dangerous-button-lowpass

  Fix low pass filter sometimes not applied in dialog overlays

  Dean Herbert · 2024-06-28 16:05:35 +09:00
  04c09b5027
• Update design for selected filters to better imply that they are selected
  Dean Herbert · 2024-06-28 15:45:09 +09:00
  fa1527f446
• Fix low pass filter sometimes not applied in dialog overlays
  Dan Balasescu · 2024-06-28 15:20:55 +09:00
  77b00dac7e
• Simplify colour logic for beatmap overlay filter rows
  Dean Herbert · 2024-06-28 14:55:55 +09:00
  c1bec7a7c3
• Merge pull request #28650 from peppy/mod-preset-tooltip-improvements

  Show mod preset description text in tooltip popup

  Dan Balasescu · 2024-06-28 14:07:06 +09:00
  1668048fb7
• Syncrhronise colours across mod and preset tooltips
  Dean Herbert · 2024-06-28 13:16:54 +09:00
  d370f50cc1
• Show preset description text in tooltip popup

  As proposed in https://github.com/ppy/osu/discussions/28610.

  Dean Herbert · 2024-06-28 13:16:53 +09:00
  28d5278935
• Merge pull request #28500 from Givikap120/pp_counter_fix

  Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"

  Dan Balasescu · 2024-06-28 13:12:45 +09:00
  17151e81ee
• Merge branch 'master' into pp_counter_fix
  Dan Balasescu · 2024-06-28 12:40:56 +09:00
  3b3f914cd2
• Merge pull request #28640 from bdach/osu-inspector-distance

  Show distance in pixels to previous/next object in osu! hitobject inspector

  Dean Herbert · 2024-06-28 00:44:31 +09:00
  8598e8bf34
• Fix distance snap control being removed
  Dean Herbert · 2024-06-27 23:59:38 +09:00
  fd6b77ea92
• Remove redundant array spec
  Dean Herbert · 2024-06-27 22:19:06 +09:00
  b293eb7930
• Show distance in pixels to previous/next object in osu! hitobject inspector
  Bartłomiej Dach · 2024-06-27 14:46:57 +02:00
  1b741dada3
• Merge pull request #28638 from OliBomby/beat-divisor

  Fix editor not loading arbitrary beat divisors

  Bartłomiej Dach · 2024-06-27 13:31:44 +02:00
  e35744118c