osu-lazer

Partial everything

Dan Balasescu · 2022-11-27 00:00:27 +09:00

7bc8908ca9

Add "Component" prefix to lookup naming

Dean Herbert · 2022-11-09 17:46:43 +09:00

1aa0e40f2f

Rename ISkinComponent to ISkinLookup

Dean Herbert · 2022-11-09 17:46:43 +09:00

c908969d9b

Adjust fade out duration to match stable

Salman Ahmed · 2022-10-18 23:48:51 +03:00

13e2323791

Automated #nullable processing

Dan Balasescu · 2022-06-17 16:37:17 +09:00

f8830c6850

Specify full size for spinner ticks container

Salman Ahmed · 2022-06-07 00:29:14 +03:00

0eaf420fa1

Move spinner spin samples to auxiliary specification

Dean Herbert · 2022-03-14 17:19:48 +09:00

be99202188

Remove unused params from BDL methods

Susko3 · 2022-01-15 01:06:39 +01:00

19467e58c1

Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod

Salman Ahmed · 2021-06-19 20:06:28 +03:00

c04b09520d

Move spinner approach circle to its own SkinnableDrawable

Salman Ahmed · 2021-06-18 20:33:50 +03:00

843c8bd7a4

Hide spinner approach circle in "Hidden" mod

Salman Ahmed · 2021-06-18 06:23:54 +03:00

c9458fd9ce

Add regression test for spinner sample actually transforming its frequency

Dean Herbert · 2021-05-24 15:10:33 +09:00

8336428574

Inline add of spm calculation (no need for it to be a separate call)

Dean Herbert · 2021-03-30 13:43:05 +09:00

9504fe3f3c

Refactor spinner SPM counter for skinning purposes

Salman Ahmed · 2021-03-30 04:19:23 +03:00

0bf84e473d

Merge branch 'master' into legacy-spinner-bonus

Dean Herbert · 2021-03-25 18:09:25 +09:00

c715b9b89e

Remove unnecessary null checks and debug code

Dean Herbert · 2021-03-23 10:38:37 +09:00

098005393e

Fix spinners playing looping sound too long in the editor

The `OnComplete` event was never being run due to the transform playing
out longer than the spinner's lifetime. I've matched the durations, but
also moved the `Stop()` call to what I deem a safer place to run it (I
did notice that without this it would still potentially never fire).

Note that this is more noticeable in the editor because of lifetime
extension. In gameplay, the returning of a spinner to the pool will
clean things up (but in the editor that can take longer, depending on
timeline zoom level).

Another thing worth mentioning is that the fade doesn't actually work.
This is due to https://github.com/ppy/osu-framework/pull/4212.

Closes #12119.

Dean Herbert · 2021-03-22 16:04:51 +09:00

c4d08463ad

Move default spinner bonus counter to new DefaultSpinner

Salman Ahmed · 2021-03-13 05:59:42 +03:00

98f6e16113

Revert legacy spinner presence changes and bonus counter component

No longer necessary, after inlining legacy coordinates logic to `LegacySpinner` and limiting precisely-positioned legacy components there

Salman Ahmed · 2021-03-13 05:57:47 +03:00

8fdab5a7de

Use sensible "score per tick" constant

Salman Ahmed · 2021-03-13 05:56:28 +03:00

020a03e01e

Merge branch 'master' into legacy-spinner-bonus

Salman Ahmed · 2021-03-13 05:54:34 +03:00

c4048c9831

Move spin start time to inside result and switch to standard state handling

Dean Herbert · 2021-03-11 12:58:15 +09:00

1591d593e2

Fix SPM counter decreasing after spinner has already been completed

Dean Herbert · 2021-03-09 16:54:46 +09:00

4e8bcc9265

Fix SPM counter immediately disappearing on completion of spinners

Dean Herbert · 2021-03-09 16:54:46 +09:00

5a6864eb78

Add default spinner bonus counter piece

Salman Ahmed · 2021-03-06 20:27:56 +03:00

3f1d36ee6b

Separate "gained bonus" to a read-only bindable

Salman Ahmed · 2021-03-06 20:27:56 +03:00

c441e993ff

Merge branch 'master' into non-concurrent-sample-playback

smoogipoo · 2021-02-12 17:22:15 +09:00

d3f0c0730d

Don't directly update HandleUserInput (as it is used by mods)

Dean Herbert · 2021-01-30 02:35:11 +09:00

d521bfc251

Fix unused using

Dean Herbert · 2021-01-29 20:22:25 +09:00

5a306dfc2b

Ensure spinners only handle input during their hittable time

While this was already being enforced inside of `CheckForResult`, the
internal tracking values of rotation were still being incremented as
long as the `DrawableSpinner` was present. This resulted in incorrect
SPM values being displayed if a user was to start spinning before the
object's `StartTime`.

Kind of annoying to write a test for (there's no setup for spinners yet)
but am willing to do so if that is deemed necessary.

Closes https://github.com/ppy/osu/issues/11600.

Dean Herbert · 2021-01-29 19:55:55 +09:00

f25809d35f

Initial sample + samplechannel rework

smoogipoo · 2021-01-19 17:11:40 +09:00

de9d075f94

Use OnComplete instead of Finally to avoid potentially stopping on aborted transforms

Dean Herbert · 2021-01-15 17:18:15 +09:00

14b3323682

Only restart spinning sample if it was not already playing

Dean Herbert · 2021-01-15 17:17:51 +09:00

311f8b7017

Adjust transition time of spinner sound