28333 Commits

This Branch

This Branch

All Branches

• Seal the ruleset creation methods and let abstract method take their place

  Also makes `CreatePlayerRuleset()` and `CreateRulesetForSkinProvider()` not-null to avoid unwanted behaviour with their derivers

  Salman Ahmed · 2020-04-23 13:27:12 +03:00
  2fa47992dc
• Mark the top ruleset creation method as can-be-null
  Salman Ahmed · 2020-04-23 13:24:30 +03:00
  0a0ea39431
• Re-enable ruleset bindable before setting defined ruleset in case it's disabled

  Happens on cases like restarting the test scene by clicking directly on it on the browser (*where it for some reason reloads the entire test scene*)

  Salman Ahmed · 2020-04-17 11:18:05 +03:00
  7f791dcdf0
• Remove ModTestScene ruleset parameter on constructor and use CreateRuleset instead
  Salman Ahmed · 2020-04-17 11:17:59 +03:00
  155bc8b49a
• Remove PlayerTestScene constructor and use CreateRuleset method instead
  Salman Ahmed · 2020-04-17 11:17:51 +03:00
  92df4e3a9e
• Move SkinnableTestScene into using the global CreateRuleset method
  Salman Ahmed · 2020-04-17 11:17:44 +03:00
  5fa6bcb5a3
• Add CreateRuleset in OsuTestScene for scenes that depend on it
  Salman Ahmed · 2020-04-17 11:12:25 +03:00
  67bd7bfa39
• Merge pull request #8764 from smoogipoo/disable-undo-redo

  Disable undo/redo menu items when they can't be performed

  Dean Herbert · 2020-04-16 13:47:23 +09:00
  5ec8d49241
• Merge pull request #8768 from Joehuu/hide-edit-item-multiplayer

  Hide edit context menu item in multiplayer song select

  Dan Balasescu · 2020-04-16 13:47:03 +09:00
  4abb85023f
• Remove bindable to promote one-way access
  smoogipoo · 2020-04-16 13:25:08 +09:00
  9e2be6f2f4
• Apply same conditional check changes to DrawableCarouselBeatmapSet
  Dean Herbert · 2020-04-16 12:13:26 +09:00
  03a74a4320
• Add exception disallowing potential edit when disabled at a property level
  Dean Herbert · 2020-04-16 12:11:12 +09:00
  91b13f91ea
• Simplify menu item checks (and add for other items)
  Dean Herbert · 2020-04-16 12:10:20 +09:00
  c4caf38feb
• Merge branch 'master' into hide-edit-item-multiplayer
  Dean Herbert · 2020-04-16 11:46:10 +09:00
  255ae0ea61
• Merge pull request #8756 from smoogipoo/fix-0-customsampleset

  Fix 0 custom sample bank not falling back to user skin

  Dean Herbert · 2020-04-16 11:43:09 +09:00
  3ca42cce71
• Merge branch 'master' into fix-0-customsampleset
  Dean Herbert · 2020-04-16 11:20:31 +09:00
  4eefe47ce3
• Fix typo
  Dean Herbert · 2020-04-16 10:44:08 +09:00
  06e25091f6
• Hide edit context menu item in multiplayer song select
  Joehu · 2020-04-15 18:17:12 -07:00
  e2b28bfe88
• Use bindables in menu items
  smoogipoo · 2020-04-15 16:17:34 +09:00
  ce21cfbb03
• Add CanUndo/CanRedo bindables
  smoogipoo · 2020-04-15 16:17:17 +09:00
  e8c955ed9b
• Add disabled state to menu items
  smoogipoo · 2020-04-15 16:17:17 +09:00
  102c1d9095
• Fix OS-dependent substring
  smoogipoo · 2020-04-15 13:54:23 +09:00
  72707a9973
• Merge pull request #8755 from peppy/fix-multi-stage-mania-replays

  Fix osu!mania replays actuating incorrect keys when multiple stages are involved

  Dan Balasescu · 2020-04-15 13:42:37 +09:00
  2af2a49f22
• Merge pull request #8761 from EVAST9919/typo-fix

  Fix typo in DrawableTaikoHitObject

  Dan Balasescu · 2020-04-15 13:22:19 +09:00
  8b83c3daab
• Merge branch 'master' into fix-multi-stage-mania-replays
  Dan Balasescu · 2020-04-15 13:08:28 +09:00
  a42f24b900
• Use another argument exception
  smoogipoo · 2020-04-15 13:08:15 +09:00
  e534d59c80
• Fix typo in DrawableTaikoHitObject
  Andrei Zavatski · 2020-04-15 07:00:38 +03:00
  f4b5a17b65
• Apply review feedback (unroll inner loop / xml fixes)
  Dean Herbert · 2020-04-15 12:35:43 +09:00
  d47e414fb1
• Fix potential dependency-related issues
  smoogipoo · 2020-04-14 23:10:14 +09:00
  10486a0ad2
• Make testscene headless
  smoogipoo · 2020-04-14 22:39:51 +09:00
  64d44dedcd
• Remove suffix hackery
  smoogipoo · 2020-04-14 21:33:32 +09:00
  44981431c5
• Add tests
  smoogipoo · 2020-04-14 21:18:28 +09:00
  00d564d29c
• Fix no audiomanager in test scene working beatmap
  smoogipoo · 2020-04-14 21:05:42 +09:00
  b29957798f
• Improve logic for CSB transfer
  smoogipoo · 2020-04-14 21:05:07 +09:00
  6935221463
• Merge pull request #8312 from Game4all/low-hp-red-layer

  Fade playfield to red when player health is low

  Dean Herbert · 2020-04-14 18:33:51 +09:00
  ecd40072c4
• Fix osu!mania replays actuating incorrect keys when multiple stages are involved
  Dean Herbert · 2020-04-14 16:52:17 +09:00
  7f95418262
• Update bindings in LoadComplete()
  smoogipoo · 2020-04-14 15:52:38 +09:00
  f3dbddd75c
• Fix up/improve test scene
  smoogipoo · 2020-04-14 15:24:34 +09:00
  59728ffebd
• Merge pull request #8752 from smoogipoo/fix-headless-api-test

  Mark dummy api test scene as headless

  Dean Herbert · 2020-04-14 15:23:09 +09:00
  363b43c41f
• Always unbind bindings
  smoogipoo · 2020-04-14 15:21:56 +09:00
  b8b334ca27
• Reorder fields
  smoogipoo · 2020-04-14 15:09:31 +09:00
  3183827329
• Fix potential unsafe ordering of binds
  smoogipoo · 2020-04-14 15:07:32 +09:00
  7d2d0785fd
• Remove bind in Player
  smoogipoo · 2020-04-14 15:00:36 +09:00
  9619fb9f6a
• Mark dummy api test scene as headless
  smoogipoo · 2020-04-14 14:51:09 +09:00
  3c5fb79823
• Merge branch 'master' into low-hp-red-layer
  Dan Balasescu · 2020-04-14 14:47:01 +09:00
  ac8a3efc46
• Merge pull request #8444 from LittleEndu/select-recommended

  Make beatmap carousel select recommended difficulties

  Dan Balasescu · 2020-04-14 14:25:17 +09:00
  33f7e429a8
• Merge pull request #8714 from peppy/dummy-api-request-support

  Add support for testing arbitrary API requests/responses via Dummy API

  Dan Balasescu · 2020-04-14 14:08:54 +09:00
  79a306cb79
• Merge branch 'master' into select-recommended
  Dan Balasescu · 2020-04-14 13:59:03 +09:00
  948e225e12
• Merge pull request #8751 from peppy/fix-missing-background-when-video

  Fix beatmap background not displaying when video is present

  Dan Balasescu · 2020-04-14 13:52:17 +09:00
  d994b4c13c
• Merge branch 'master' into dummy-api-request-support
  Dan Balasescu · 2020-04-14 13:42:42 +09:00
  d965baa4bd