1396 Commits

• Add logging and Debug.Fail on detached beatmap detection
  Dean Herbert · 2023-06-28 12:21:05 +09:00
  99e55bb9c0
• Fix incorrect realm copy logic when a beatmap becomes detached from its set

  The code here was assuming that if the beatmap which is having changes
  copied across does not exist within the `BeatmapSet.Beatmaps` list, it
  was not yet persisted to realm.
  
  In some edge case, it can happen that the beatmap *is* persisted to
  realm but not correctly attached to the beatmap set. I don't yet know
  how this occurs, but it has caused loss of data for at least two users.
  
  The fix here is to check realm-wide for the beatmap (using its primary
  key) rather than only in the list. We then handle the scenario where the
  beatmap needs to be reattached to the set as a seprate step.
  
  ---
  
  This does raise others questions like "are we even structuring this
  correctly? couldn't a single beatmap exist in two different sets?"
  
  Maybe, but let's deal with that if/when it comes up.

  Dean Herbert · 2023-06-27 18:20:01 +09:00
  8e80e2fa32
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Force migration of old-new standardised scores to run once more
  Dean Herbert · 2023-06-16 14:04:18 +09:00
  1f17f416a4
• Fix old-new standardised score conversion missing some scores due to not rounding correctly
  Dean Herbert · 2023-06-16 14:01:56 +09:00
  94b7de4b3f
• Apply migration to new standardised score on normal reimport too
  Bartłomiej Dach · 2023-06-15 21:53:15 +02:00
  51b5a0863f
• Fix thing
  Dean Herbert · 2023-06-15 21:43:41 +02:00
  d83bf02923
• Fix score migration not considering mod multipliers
  Bartłomiej Dach · 2023-06-13 19:00:13 +02:00
  6205864c62
• Fix weird usings
  Dean Herbert · 2023-06-13 05:30:12 +09:00
  422e87f0ec
• Ensure all misses are dequeued
  Dean Herbert · 2023-06-13 05:24:04 +09:00
  c1b0c60e79
• Add more commenting
  Dean Herbert · 2023-06-13 05:20:29 +09:00
  3304e41a30
• Fix typo

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-06-13 05:13:22 +09:00
  afb5a9243a
• Avoid tracking hit events altogether during migration
  Dean Herbert · 2023-06-13 02:15:41 +09:00
  e9fb1f8932
• Move local classes to their rightful location
  Dean Herbert · 2023-06-13 02:12:23 +09:00
  385f6dbd84
• Avoid overhead from retrieving MaxCombo inside loop from realm
  Dean Herbert · 2023-06-13 02:05:00 +09:00
  87520ae400
• Add basic profiling output of realm migrations
  Dean Herbert · 2023-06-13 01:57:41 +09:00
  0916ae1671
• Remove logging and catch any kind of errors
  Dean Herbert · 2023-06-13 01:40:43 +09:00
  0e9576acfb
• Account for scores which don't have correct maximum statistics populated
  Dean Herbert · 2023-06-13 01:40:43 +09:00
  d19f8997fc
• Add basic setup for score migration
  Dean Herbert · 2023-06-13 01:40:43 +09:00
  f30c1a564f
• Apply NRT in MemoryCachingComponent subclasses too
  Bartłomiej Dach · 2023-06-09 13:47:35 +02:00
  11694f35fe
• Apply NRT to MemoryCachingComponent classes
  Dean Herbert · 2023-06-09 19:00:05 +09:00
  4685ba83e1
• Be slightly more specific with error message
  Bartłomiej Dach · 2023-06-09 11:20:12 +02:00
  ca25ac446b
• Inline binary reading to avoid polluting RealmAccess with nested class
  Dean Herbert · 2023-06-09 17:34:27 +09:00
  53f935714e
• try-catch more
  Dean Herbert · 2023-06-09 17:33:59 +09:00
  a9071e7afd
• Catch errors during score parsing
  Dan Balasescu · 2023-06-09 14:35:29 +09:00
  67562a3856
• Parse ScoreInfo.IsLegacyScore from replays
  Dan Balasescu · 2023-06-08 21:38:10 +09:00
  facf7de053
• Merge pull request #23711 from timiimit/add-last-edit-time

  Store timestamp of beatmap's last edit time in local database

  Bartłomiej Dach · 2023-06-07 16:57:24 +02:00
  1f4e79d79d
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Fix incorrect realm schema comment

  Co-authored-by: timiimit <32331609+timiimit@users.noreply.github.com>

  Dean Herbert · 2023-06-06 22:17:05 +09:00
  e0e013cca1
• Bump schema version
  Dean Herbert · 2023-06-06 15:11:37 +09:00
  878cdb2ed3
• Gracefully handle failures in cleaning up pending file deletions
  Dean Herbert · 2023-05-31 19:39:43 +09:00
  18eb15bfa5
• Move comment to more correct place
  Bartłomiej Dach · 2023-05-30 23:18:34 +02:00
  2e81cae201
• Adjust realm backup procedure to hard fail if running out of attempts

  Previously, if the backup procedure failed, startup would continue and
  the user's realm database may be deleted. I think in such a fail case
  I'd rather the game didn't startup so the user gets in touch (or reads
  the log files themselves) rather than potentially losing data.

  Dean Herbert · 2023-05-30 13:04:34 +09:00
  a0be526266
• Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt

  The whole restructure here is to move the nested call out of the
  `try-catch`. I noticed this while looking at a corrupt database issue a
  user reported (https://github.com/ppy/osu/discussions/23694).
  
  It's not the first time we've seen a corrupt database error where the
  "corrupt" version works just fine on a second attempt.
  
  Maybe this isn't the issue and it's just a transitive file access violation
  but it definitely feels like this should be fixed regardless.

  Dean Herbert · 2023-05-30 13:00:17 +09:00
  79694897be
• Remove usages of [ExcludeFromDynamicCompile]
  Dan Balasescu · 2023-05-08 18:12:56 +09:00
  d2380bd840
• Mark exporter extensions as untranslatable
  Bartłomiej Dach · 2023-05-06 19:42:28 +02:00
  510484011c
• Reorder increment to make progress update less weird
  Bartłomiej Dach · 2023-05-06 19:39:52 +02:00
  3f63fd7f4d
• Rename flag
  Bartłomiej Dach · 2023-05-06 19:38:41 +02:00
  bb17b684b0
• Unify error message wording
  Bartłomiej Dach · 2023-05-06 19:38:05 +02:00
  a56a5d563c
• Remove weird single-use private method
  Bartłomiej Dach · 2023-05-06 19:34:22 +02:00
  3afe198d1d
• Move lower and xmldoc GetFilename(TModel)
  Bartłomiej Dach · 2023-05-06 19:29:08 +02:00
  e0823ffd03
• Make UserFileStorage readonly again
  Bartłomiej Dach · 2023-05-06 19:26:51 +02:00
  5e64d25b2a
• Rename outputStream variable to match base class
  Dean Herbert · 2023-05-07 00:24:30 +09:00
  64d7e0d896
• More xmldoc fixes
  Dean Herbert · 2023-05-06 23:53:35 +09:00
  d2591368a6
• Remove non-Live pathway
  Dean Herbert · 2023-05-06 23:10:18 +09:00
  0d095c4bb7
• Remove redundant xmldoc and reword some remaining
  Dean Herbert · 2023-05-06 23:10:09 +09:00
  e75ff33d62
• remove meanless comment
  cdwcgt · 2023-05-05 21:29:06 +09:00
  71864fbb93
• ExportToStream should be public
  cdwcgt · 2023-05-05 21:28:43 +09:00
  4393e53b43
• Fix incorrect cancellation logic
  Dean Herbert · 2023-05-05 21:08:01 +09:00
  747f912af5