1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-20 07:19:53 +08:00
Files
osu-lazer/osu.Game/Database
T
Dean Herbert 8e80e2fa32 Fix incorrect realm copy logic when a beatmap becomes detached from its set
The code here was assuming that if the beatmap which is having changes
copied across does not exist within the `BeatmapSet.Beatmaps` list, it
was not yet persisted to realm.

In some edge case, it can happen that the beatmap *is* persisted to
realm but not correctly attached to the beatmap set. I don't yet know
how this occurs, but it has caused loss of data for at least two users.

The fix here is to check realm-wide for the beatmap (using its primary
key) rather than only in the list. We then handle the scenario where the
beatmap needs to be reattached to the set as a seprate step.

---

This does raise others questions like "are we even structuring this
correctly? couldn't a single beatmap exist in two different sets?"

Maybe, but let's deal with that if/when it comes up.
8e80e2fa32 · 2023-06-27 18:20:01 +09:00
History
..
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2022-06-17 16:37:17 +09:00
2023-06-24 01:00:03 +09:00
2022-08-10 19:53:40 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2022-06-17 16:37:17 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2022-11-17 13:56:27 +09:00