Bartłomiej Dach
29697d4999
Fix taiko test scene failing due to missing gameplay clock dependency
...
`GameplayClock` is inscrutable.
`TestManualClock` is lifted from another test scene because of
`FramedBeatmapClock`'s intensely confusing tendency to not work if it is
given a non-adjustable `ManuelClock` instead.
2023-06-20 23:30:52 +02:00
Bartłomiej Dach
2f77675fe7
Fix errors in tests due to mismatching NRT annotations
2023-06-20 21:57:32 +02:00
Dean Herbert
cb07f2399f
Apply NRT to GameplaySampleTriggerSource
2023-06-20 21:03:55 +09:00
Dean Herbert
92e89c7df7
Update test expectations
2023-06-20 21:02:34 +09:00
Dean Herbert
04dad6c6e8
Use IGameplayClock to ensure our clock source is correct
2023-06-20 20:47:56 +09:00
Dean Herbert
0e86102681
Fix nested lookups
2023-06-20 20:45:02 +09:00
Dean Herbert
786d5a394b
Add back optimisation and increase time allowance slightly
2023-06-20 20:30:07 +09:00
Dean Herbert
555ce7684b
Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object
...
Closes #23963 .
To simplify things, I've removed the optimisation of using
`AliveObject`s because it would break the way this whole lookup works.
2023-06-20 20:06:07 +09:00
Dean Herbert
c815f8cd23
Merge pull request #23973 from peppy/update-framework
...
Update framework
2023-06-20 18:53:55 +09:00
Dean Herbert
ff8350bac6
Update framework
2023-06-20 17:43:52 +09:00
Bartłomiej Dach
c467e6ba1f
Merge pull request #23969 from Joehuu/fix-beatmap-info-bpm
...
Fix beatmap info not showing individual difficulty bpm
2023-06-19 22:57:17 +02:00
Bartłomiej Dach
a600eb5f36
Merge pull request #23938 from peppy/fix-distance-snap-grid-centering
...
Fix distance snap grid circles not correctly being centred on snap point
2023-06-19 21:36:33 +02:00
Joseph Madamba
362fe62b4b
Fix beatmap info not showing individual difficulty bpm
2023-06-19 11:05:29 -07:00
Bartłomiej Dach
ecc5915ab3
Merge branch 'master' into fix-distance-snap-grid-centering
2023-06-19 18:45:06 +02:00
Bartłomiej Dach
9bcd86d66d
Fix test failure due to relying on implementation detail
2023-06-19 18:42:30 +02:00
Bartłomiej Dach
2d8a74d776
Merge pull request #23520 from jtbiddle/snap-colour-mod
...
Add "Synesthesia" mod for osu! ruleset
2023-06-19 18:31:58 +02:00
Bartłomiej Dach
6d32206a08
Fix slider tails receiving wrong colours
...
Only visually apparent on legacy skins.
2023-06-19 17:47:01 +02:00
Dean Herbert
84fc6e92db
Fix slightly incorrect calculations
2023-06-19 20:23:46 +09:00
Dean Herbert
4314f9f46a
Merge branch 'master' into fix-distance-snap-grid-centering
2023-06-19 20:22:09 +09:00
Dean Herbert
0900cebc0d
Avoid doing expensive colour fetch operation every update
2023-06-19 20:12:17 +09:00
Dean Herbert
aa96fefae2
Merge branch 'master' into snap-colour-mod
2023-06-19 20:01:36 +09:00
Dean Herbert
f8b94ed033
Merge pull request #23414 from Cootz/add-mod-search-option
...
Add mod search
2023-06-19 02:07:00 +09:00
Dean Herbert
db445660e7
Avoid resolving realm Live more than once
2023-06-19 01:06:45 +09:00
Dean Herbert
425d3c23f5
Fix some code layout and NRT some classes
2023-06-19 01:03:43 +09:00
Bartłomiej Dach
b4c1266fc5
Add TODO for future support of typical search shortcuts
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
b87acfa66f
Dynamically change placeholder to convey how to activate search
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
75300ca229
Switch search box to initially unfocused
...
Done primarily to keep mod hotkeys working without any behavioural
changes when mod select is opened.
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
9ba4bf5fb7
Merge branch 'master' into add-mod-search-option
2023-06-18 15:06:21 +02:00
Bartłomiej Dach
5dc675ab65
Merge pull request #23882 from peppy/focused-overlay-container-override-fixes
...
Apply osu! side changes in line with `FocusedOverlayContainer.PopIn` `abstract` change
2023-06-18 15:05:58 +02:00
Bartłomiej Dach
d4c9eb013e
Fix bugged initial state of matching filter flag
...
Was preventing mod preset panels from refiltering correctly on ruleset
change due to the `matchingFilter == value` guard.
2023-06-18 14:51:52 +02:00
Bartłomiej Dach
0b6c0592e4
Add failing test case for mod preset filtering not working after ruleset change
2023-06-18 14:51:16 +02:00
Bartłomiej Dach
a49af06e88
Reword comments in ModSelectOverlay
2023-06-18 14:34:33 +02:00
Bartłomiej Dach
28f929dc4d
Remove yet another redundant guard
2023-06-18 14:28:26 +02:00
Bartłomiej Dach
b9156b1df3
Reword/rename some stuff in test
2023-06-18 14:24:35 +02:00
Bartłomiej Dach
76f509a1db
Do not use ?? true pattern
...
Universally disliked. `!= false` is preferred.
2023-06-18 14:19:38 +02:00
Bartłomiej Dach
9758e5f840
Fix utterly broken test
...
- Was on wrong ruleset, so the mod/free mod sets did literally nothing
- `assertHasFreeModButton` had a param that did nothing
- Was checking `MatchingFilter` rather than `Visible`
2023-06-18 14:16:38 +02:00
Bartłomiej Dach
4c78144d10
Remove obvious comment
2023-06-18 14:04:00 +02:00
Bartłomiej Dach
64e96c6d82
Fix duplicate linq and reword comment
2023-06-18 14:03:26 +02:00
Bartłomiej Dach
a1015b4145
Remove duplicated xmldoc and move into relevant region
2023-06-18 13:59:36 +02:00
Bartłomiej Dach
1b4d7db1e6
Remove redundant guard
...
`Bindable` has one of those already.
2023-06-18 13:58:25 +02:00
Bartłomiej Dach
c7e8990576
Remove unused property
2023-06-18 13:58:25 +02:00
Bartłomiej Dach
62f01e4f40
Rename ModState members to better convey what's what
2023-06-18 13:58:25 +02:00
Dean Herbert
d9c00fc4be
Update framework
2023-06-18 20:57:43 +09:00
Dean Herbert
eb31fdecee
Apply osu! side changes in line with FocusedOverlayContainer.PopIn abstract change
...
See https://github.com/ppy/osu-framework/pull/5834
2023-06-18 20:57:32 +09:00
Dean Herbert
ba8ca3facf
Merge pull request #23954 from Joehuu/fix-drain-length-tooltip
...
Fix beatmap info length tooltip not showing actual drain length
2023-06-18 15:20:45 +09:00
Dean Herbert
66f33b4f8c
Merge pull request #23952 from frenzibyte/ios-file-import-support
...
Add back support for importing beatmaps/skins/replays on iOS via "Files" app
2023-06-18 15:14:50 +09:00
Joseph Madamba
9ae864c219
Fix beatmap info length tooltip not showing actual drain length
2023-06-17 15:00:32 -07:00
Joseph Madamba
fdebf93ae4
Fix incorrect xmldoc of IBeatmapInfo.Length
2023-06-17 14:55:27 -07:00
Bartłomiej Dach
fc07705809
Merge pull request #23951 from peppy/avoid-humanizer-song-select-overhead
...
Avoid humanizer regex compilation overhead when opening song select for the first time
2023-06-17 20:39:40 +02:00
Bartłomiej Dach
eafd774044
Bring back old formatting spec
2023-06-17 20:03:24 +02:00
