Liam DeVoe
60eedbafd1
rename GetTextBoxPlaceholder to GetPlaceholderText
2023-06-19 22:05:18 -04:00
Liam DeVoe
f7dde53f9b
use runOnceImmediately instead of duplicating logic
2023-06-19 18:20:16 -04:00
Liam DeVoe
591277e0f9
extract button text properties to methods, show login overlay on click
2023-06-19 18:10:37 -04:00
Liam DeVoe
d5d494f07b
resolve protected API in comments superclass
2023-06-19 17:36:40 -04:00
Liam DeVoe
4a9543092a
disable posting comments when logged out
2023-06-19 17:08:04 -04:00
Bartłomiej Dach
c467e6ba1f
Merge pull request #23969 from Joehuu/fix-beatmap-info-bpm
...
Fix beatmap info not showing individual difficulty bpm
2023-06-19 22:57:17 +02:00
Bartłomiej Dach
a600eb5f36
Merge pull request #23938 from peppy/fix-distance-snap-grid-centering
...
Fix distance snap grid circles not correctly being centred on snap point
2023-06-19 21:36:33 +02:00
Joseph Madamba
362fe62b4b
Fix beatmap info not showing individual difficulty bpm
2023-06-19 11:05:29 -07:00
Bartłomiej Dach
ecc5915ab3
Merge branch 'master' into fix-distance-snap-grid-centering
2023-06-19 18:45:06 +02:00
Bartłomiej Dach
9bcd86d66d
Fix test failure due to relying on implementation detail
2023-06-19 18:42:30 +02:00
Bartłomiej Dach
2d8a74d776
Merge pull request #23520 from jtbiddle/snap-colour-mod
...
Add "Synesthesia" mod for osu! ruleset
2023-06-19 18:31:58 +02:00
Bartłomiej Dach
6d32206a08
Fix slider tails receiving wrong colours
...
Only visually apparent on legacy skins.
2023-06-19 17:47:01 +02:00
Dean Herbert
69526f25bb
Add hotkey to save replay
...
Defaults to `F2` aka stable.
2023-06-19 20:45:29 +09:00
Dean Herbert
84fc6e92db
Fix slightly incorrect calculations
2023-06-19 20:23:46 +09:00
Dean Herbert
4314f9f46a
Merge branch 'master' into fix-distance-snap-grid-centering
2023-06-19 20:22:09 +09:00
Dean Herbert
0900cebc0d
Avoid doing expensive colour fetch operation every update
2023-06-19 20:12:17 +09:00
Dean Herbert
aa96fefae2
Merge branch 'master' into snap-colour-mod
2023-06-19 20:01:36 +09:00
tsrk
f83a4f4952
refactor: tidy up attachement flow
...
TODO: find better naming and improve XMLDocs
2023-06-18 22:57:21 +02:00
tsrk
141f9efad5
style(KeyCounterController): remove reliance on Receptor
2023-06-18 21:26:16 +02:00
tsrk
1a8219adf6
style: guard event handler unsubscriptions
2023-06-18 20:20:56 +02:00
Dean Herbert
f8b94ed033
Merge pull request #23414 from Cootz/add-mod-search-option
...
Add mod search
2023-06-19 02:07:00 +09:00
Bartłomiej Dach
1a6a66e953
Rewrite assertions to be better
2023-06-18 18:48:54 +02:00
Bartłomiej Dach
ee08ed414c
Document DrawableChatUsername members
2023-06-18 18:46:49 +02:00
Bartłomiej Dach
a2a9823d84
Rename constant
2023-06-18 18:46:49 +02:00
Bartłomiej Dach
dad32817ee
Improve UsernameColour documentation
2023-06-18 18:46:49 +02:00
Bartłomiej Dach
bd174b5193
Revert to non-bindable AccentColour
...
Not necessary for now, so let's not incur unnecessary overheads.
2023-06-18 18:46:49 +02:00
Ruki
9c6c6bf1ea
Merge branch 'master' into hud/kc-skinnable
2023-06-18 18:30:44 +02:00
tsrk
cf1ee2ba35
test(TestSceneOsuTouchInput): fix InputTrigger depth
2023-06-18 18:26:08 +02:00
Dean Herbert
db445660e7
Avoid resolving realm Live more than once
2023-06-19 01:06:45 +09:00
Dean Herbert
425d3c23f5
Fix some code layout and NRT some classes
2023-06-19 01:03:43 +09:00
tsrk
c8afd057bd
test(TestSceneOsuTouchInput): simplify draw hierarchy
...
An InputTrigger is considered active as long as
2023-06-18 17:51:17 +02:00
tsrk
886a1e98da
test(SkinDeserialisationTest): use more complete skin
2023-06-18 17:32:49 +02:00
Bartłomiej Dach
b4c1266fc5
Add TODO for future support of typical search shortcuts
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
b87acfa66f
Dynamically change placeholder to convey how to activate search
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
75300ca229
Switch search box to initially unfocused
...
Done primarily to keep mod hotkeys working without any behavioural
changes when mod select is opened.
2023-06-18 15:58:50 +02:00
Bartłomiej Dach
9ba4bf5fb7
Merge branch 'master' into add-mod-search-option
2023-06-18 15:06:21 +02:00
Bartłomiej Dach
5dc675ab65
Merge pull request #23882 from peppy/focused-overlay-container-override-fixes
...
Apply osu! side changes in line with `FocusedOverlayContainer.PopIn` `abstract` change
2023-06-18 15:05:58 +02:00
Bartłomiej Dach
d4c9eb013e
Fix bugged initial state of matching filter flag
...
Was preventing mod preset panels from refiltering correctly on ruleset
change due to the `matchingFilter == value` guard.
2023-06-18 14:51:52 +02:00
Bartłomiej Dach
0b6c0592e4
Add failing test case for mod preset filtering not working after ruleset change
2023-06-18 14:51:16 +02:00
Bartłomiej Dach
a49af06e88
Reword comments in ModSelectOverlay
2023-06-18 14:34:33 +02:00
Bartłomiej Dach
28f929dc4d
Remove yet another redundant guard
2023-06-18 14:28:26 +02:00
Bartłomiej Dach
b9156b1df3
Reword/rename some stuff in test
2023-06-18 14:24:35 +02:00
Bartłomiej Dach
76f509a1db
Do not use ?? true pattern
...
Universally disliked. `!= false` is preferred.
2023-06-18 14:19:38 +02:00
Bartłomiej Dach
9758e5f840
Fix utterly broken test
...
- Was on wrong ruleset, so the mod/free mod sets did literally nothing
- `assertHasFreeModButton` had a param that did nothing
- Was checking `MatchingFilter` rather than `Visible`
2023-06-18 14:16:38 +02:00
Bartłomiej Dach
4c78144d10
Remove obvious comment
2023-06-18 14:04:00 +02:00
Bartłomiej Dach
64e96c6d82
Fix duplicate linq and reword comment
2023-06-18 14:03:26 +02:00
Bartłomiej Dach
a1015b4145
Remove duplicated xmldoc and move into relevant region
2023-06-18 13:59:36 +02:00
Bartłomiej Dach
1b4d7db1e6
Remove redundant guard
...
`Bindable` has one of those already.
2023-06-18 13:58:25 +02:00
Bartłomiej Dach
c7e8990576
Remove unused property
2023-06-18 13:58:25 +02:00
Bartłomiej Dach
62f01e4f40
Rename ModState members to better convey what's what
2023-06-18 13:58:25 +02:00
