51150 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into fix-autopilot-touch-devices
  Dean Herbert · 2021-12-15 12:04:35 +09:00
  6bffeb6a24
• Fix null reference in some tests due to missing realm context factory
  Dean Herbert · 2021-12-15 11:16:37 +09:00
  9d85beddbe
• Merge pull request #16072 from rumoi/rhythm-bonus-performance-fix

  Eliminate iterations with no effect from rhythm bonus calculation

  Dan Balasescu · 2021-12-15 09:57:25 +09:00
  01ca9eb81c
• Remove redundant code.
  rumoi · 2021-12-15 12:36:45 +13:00
  e662a9f0c4
• Merge pull request #16083 from peppy/fix-online-availability-after-reimport

  Fix `OnlinePlayBeatmapAvailabilityTracker` failng after modified reimport of existing beatmap

  Dan Balasescu · 2021-12-15 08:31:02 +09:00
  2cea39a92a
• Merge pull request #15967 from tbrose/chat-mention-fix

  Check word boundaries during username mention matching

  Dan Balasescu · 2021-12-15 08:04:39 +09:00
  ee6f125948
• Remove whitespace
  Dan Balasescu · 2021-12-15 07:33:49 +09:00
  da00c020be
• Rename to AbortGameplay() and handle additional states
  Dan Balasescu · 2021-12-15 06:40:28 +09:00
  9ade8069a1
• Merge pull request #16068 from peppy/fix-fail-animation-background-dim

  Improve appearance of player-wide background after failing with low background dim

  Dan Balasescu · 2021-12-15 06:32:02 +09:00
  4c81fd8b7c
• Merge pull request #16081 from peppy/fix-menu-background-desync

  Fix `BackgroundScreenDefault` incorrectly updating current background after being inactive

  Bartłomiej Dach · 2021-12-14 22:01:31 +01:00
  e862b3775b
• Merge branch 'master' into fix-menu-background-desync
  Bartłomiej Dach · 2021-12-14 21:31:10 +01:00
  00154fe86d
• Merge branch 'rhythm-bonus-performance-fix' of https://github.com/rumoi/osu into rhythm-bonus-performance-fix
  rumoi · 2021-12-15 05:16:34 +13:00
  74ea10179d
• Remove uneeded complexity
  rumoi · 2021-12-15 05:16:10 +13:00
  4664bb1d29
• Merge remote-tracking branch 'origin/chat-mention-fix' into chat-mention-fix
  tbrose · 2021-12-14 16:24:05 +01:00
  a831744f05
• Fixes code quality check failed
  tbrose · 2021-12-14 16:23:51 +01:00
  8e79fac389
• Add back PlaylistRoomCreation test

  Was spiritually removed in https://github.com/ppy/osu/pull/16045.
  
  This implementation is mostly taken from that PR's comment thread
  verbatim, and now works due to the associated changes to
  `OnlinePlayBeatmapAvailabilityTracker`.

  Dean Herbert · 2021-12-14 19:16:52 +09:00
  0950d8d327
• Fix OnlinePlayBeatmapAvailabilityTracker potentially in incorrect state

  Adter an import of a modified version of a beatmap (that was already
  present in the local database), it's feasible that one of these trackers
  would not see the state change due to the nuances of the import process.

  Dean Herbert · 2021-12-14 19:16:11 +09:00
  453ecd21b3
• Add failing test coverage of modified beatmap import breaking online availability state
  Dean Herbert · 2021-12-14 19:11:23 +09:00
  3bc2de4889
• Merge pull request #16080 from smoogipoo/fix-storyboard-start-time

  Fix incorrect storyboard life time start with looping commands

  Dean Herbert · 2021-12-14 18:33:56 +09:00
  04551ea61e
• Merge pull request #16045 from smoogipoo/multiplayer-local-beatmap-query

  Rework multiplayer's current item tracking

  Dean Herbert · 2021-12-14 18:33:30 +09:00
  cebfeb5220
• Use longer form to read better

  Using `l.StartTime` reads like a coding issue, even though if you go
  down the call chain looks to be correct.

  Dean Herbert · 2021-12-14 17:41:09 +09:00
  79dd9674fc
• Fix BackgroundScreenDefault incorrectly updating current background after being inactive

  If the beatmap was changed but then reverted to the previously displayed
  map, the background may have displayed incorrectly on resuming.
  
  Closes #15804.

  Dean Herbert · 2021-12-14 16:40:50 +09:00
  8c6f50ddb1
• Remove pointless/broken test steps

  These aren't accurate and are tested via a more accurate means directly
  above.

  Dean Herbert · 2021-12-14 16:40:50 +09:00
  25a056dfad
• Add failing test coverage of BackgroundScreeNDefault's beatmap background tracking when active/non-active
  Dean Herbert · 2021-12-14 16:40:34 +09:00
  b6a272e31a
• Fix incorrect test
  Dan Balasescu · 2021-12-14 15:08:00 +09:00
  eb3050b2ac
• Provide a realm factory to usages of ToLive/RealmLive
  Dean Herbert · 2021-12-14 14:26:34 +09:00
  441b7baa93
• Add accessibility to realm factory via IStorageResourceProvider

  We might need to rename this class..

  Dean Herbert · 2021-12-14 14:19:49 +09:00
  f9a2db5ec6
• Add failing test coverage of RealmLive failing post storage migration
  Dean Herbert · 2021-12-14 13:53:23 +09:00
  be337b4ace
• Use OsuStorage in realm tests to allow for migration

  Also changes the realm filename to use `client` to match the ignore
  rules in `OsuStorage`. Without doing this, migration will fail in an
  indefinite mutex wait when attempting to delete the realm `.note` file.

  Dean Herbert · 2021-12-14 13:52:28 +09:00
  8e6c7eb030
• Add note about how the background colour is restored
  Dean Herbert · 2021-12-14 13:25:19 +09:00
  7e576ae9d3
• Fix storyboard sprites sometimes starting too early
  Dan Balasescu · 2021-12-14 13:13:12 +09:00
  357a661379
• Merge branch 'master' into chat-mention-fix
  Dan Balasescu · 2021-12-14 11:49:57 +09:00
  51b6b9d857
• Fix TestMultiplayerClient not handling all users bailing from gameplay
  Dan Balasescu · 2021-12-14 11:35:56 +09:00
  750bfae909
• Add AbortLoad() method to abort gameplay loads
  Dan Balasescu · 2021-12-14 11:30:42 +09:00
  2f1dc91211
• Merge pull request #16062 from smoogipoo/retry-score-submission-timeout

  Increase score submission timeout

  Dean Herbert · 2021-12-14 11:03:20 +09:00
  a076eda834
• Merge pull request #16070 from peppy/test-score-refactoring

  Move test `ScoreInfo` creation to `TestResources`

  Dan Balasescu · 2021-12-14 10:03:52 +09:00
  19f7f4dc02
• Merge branch 'master' into test-score-refactoring
  Dan Balasescu · 2021-12-14 07:30:06 +09:00
  419a34e7b4
• Merge pull request #16069 from peppy/clean-up-excess-bindings

  Refactor `KeyBindingStore` to clean up any excess bindings for individual actions

  Dan Balasescu · 2021-12-14 06:48:08 +09:00
  01c7ff71c2
• Reduce to 30s
  Dan Balasescu · 2021-12-14 06:40:45 +09:00
  7564658b5e
• Remove weird test
  Dan Balasescu · 2021-12-14 06:38:57 +09:00
  6e3558b222
• Merge branch 'master' into rhythm-bonus-performance-fix
  Isaac Andrews · 2021-12-14 09:40:37 +13:00
  5618bdafce
• calculateRhythmBonus performance fix.
  rumoi · 2021-12-14 09:25:29 +13:00
  c87ff82c1c
• Remove unused using statement
  Dean Herbert · 2021-12-13 17:59:04 +09:00
  9e9341597d
• Use new method in more places that can benefit from it
  Dean Herbert · 2021-12-13 16:56:43 +09:00
  309290a3c9
• Move "excess mods" test behaviour to local usages

  There were only two of these, so it doesn't make sense to add extra
  complexity in the test resources class.

  Dean Herbert · 2021-12-13 16:41:30 +09:00
  654b47c7ec
• Simplify usages where the ruleset being used is osu! ruleset
  Dean Herbert · 2021-12-13 16:37:20 +09:00
  99ac71c1fe
• Move test ScoreInfo creation to TestResources

  The main goal here is to remove the inheritance, since realm doesn't
  like that. Unfortunate that we can't use object initialisers in a few of
  these places, but no real way around that.

  Dean Herbert · 2021-12-13 16:34:50 +09:00
  b0d14526ea
• Re-simplify code by removing BeatmapManager event instead
  Dan Balasescu · 2021-12-13 16:09:54 +09:00
  70045494ba
• Refactor KeyBindingStore to clean up any excess bindings for individual actions

  While this isn't strictly required (outside of rulesets, potentially),
  I think it's best that we keep these counts in a sane state.
  
  Right now, it will remove any excess. Arguably, in the case an entry is
  found with too many, we should wipe all entries and re-populate the
  defaults. Interested in opinions on that before merging. See
  https://github.com/ppy/osu/discussions/15925 for an example where wiping
  may be the more appropriate behaviour.

  Dean Herbert · 2021-12-13 15:26:51 +09:00
  7318ff3f98
• Add test coverage showing that KeyBindingStore won't remove excess key bindings
  Dean Herbert · 2021-12-13 15:26:32 +09:00
  4cac87e933