44264 Commits

This Branch

This Branch

All Branches

• Merge branch 'master' into localisable-tooltips
  Dean Herbert · 2021-06-28 15:29:42 +09:00
  f939e2603a
• Make OutlinedNumberBox private and nested again
  Dean Herbert · 2021-06-28 15:24:55 +09:00
  eeb56970ef
• Rename variables in line with standards
  Dean Herbert · 2021-06-28 15:23:19 +09:00
  88c6143aae
• ResourcesSkin -> ResourceStoreBackedSkin
  Salman Ahmed · 2021-06-28 09:18:29 +03:00
  f598de4cdb
• Maintain ruleset resources skin across multiple source changes
  Salman Ahmed · 2021-06-28 09:11:28 +03:00
  692f24437e
• Add null check for safety

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-06-28 15:08:49 +09:00
  7dd566dc46
• Remove Dispose() special case and add explicit exception to make debugging issues non-deadlock
  Dean Herbert · 2021-06-28 15:04:14 +09:00
  c281e43cd8
• Simplify instantiation
  Dean Herbert · 2021-06-28 14:51:27 +09:00
  f777741ca7
• Simplify caching in test
  Dean Herbert · 2021-06-28 14:44:52 +09:00
  73bd88cb31
• Add inline comment mentioning why CreateChildDependencies is being used in this instance
  Dean Herbert · 2021-06-28 14:39:55 +09:00
  e387feb1d6
• Merge branch 'master' into fix-initial-ruleset-skin-loading
  Dean Herbert · 2021-06-28 14:35:34 +09:00
  fdd6778f36
• Fix typo in newly added xmldoc

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2021-06-28 14:07:21 +09:00
  a3946a1265
• Use IHasRepeats instead of IHasPathWithRepeats
  Henry Lin · 2021-06-28 11:33:19 +08:00
  ea8993d6d6
• Use BindValueChanged instead of setting the value in property setter
  Henry Lin · 2021-06-28 11:20:00 +08:00
  3d19364a71
• Remove redundant string interpolation (and mark all local logging strings as verbatim)
  Dean Herbert · 2021-06-28 12:16:15 +09:00
  4d6002ab88
• Moved the string to int? conversion logic into SettingsNumberBox
  Henry Lin · 2021-06-28 11:00:07 +08:00
  0cceef8da5
• Add logging to help understand existing case skips better
  Dean Herbert · 2021-06-28 10:42:42 +09:00
  4a557e73a7
• Fix test oversights
  Dean Herbert · 2021-06-28 10:42:28 +09:00
  128f08ccba
• Merge pull request #13598 from JimmyC7834/supporter-only-filter-content

  Add supporter required placeholder in beatmap listing overlay

  Dan Balasescu · 2021-06-28 10:27:56 +09:00
  9c0840268a
• Add back unidirectional online id check
  Dean Herbert · 2021-06-28 10:11:27 +09:00
  90b87cbb9e
• Revert "Remove comparison of online beatmap IDs during dedupe checks"

  This reverts commit 15af28d2a0.

  Dean Herbert · 2021-06-28 09:54:18 +09:00
  9a96cd4a1d
• Merge pull request #13669 from Naxesss/hitsound-checks

  Add hitsound checks

  Dean Herbert · 2021-06-28 03:13:43 +09:00
  a1e8cc5444
• Add nested hitobject tests for few hitsounds check
  Naxess · 2021-06-27 15:58:00 +02:00
  b58644106c
• Use local variables for common sample lists
  Naxess · 2021-06-27 15:57:41 +02:00
  1dbac76da5
• Add check for spanDuration <= 0 prior to division
  Naxess · 2021-06-27 15:40:09 +02:00
  9f9e96ce9e
• Improve acceptable difference for repeat edges

  Likelihood that `spanDuration` is greater than E+7 is quite low in any realistic case, so this should work fine.

  Naxess · 2021-06-27 15:39:31 +02:00
  a4a5325b73
• Add concurrent hitobjects test for few hitsounds check

  See https://github.com/ppy/osu/pull/13669#discussion_r659314980

  Naxess · 2021-06-27 15:26:52 +02:00
  1d5bff1660
• Move MockNestedHitObject to own class
  Naxess · 2021-06-27 15:16:40 +02:00
  c2ceb83bbb
• Add log method for new flow
  Dean Herbert · 2021-06-27 20:37:12 +09:00
  e755dcc34d
• Move private method down in class
  Dean Herbert · 2021-06-27 20:36:01 +09:00
  f470b7095d
• Add back ignore cases for intentionally broken tests
  Dean Herbert · 2021-06-27 20:24:16 +09:00
  cd9aa38d3d
• Fix missing undelete call on using existing
  Dean Herbert · 2021-06-27 20:22:48 +09:00
  f216404952
• Merge pull request #13671 from peppy/import-process-clean-up

  Tidy up some areas of `ArchiveModelManager` / beatmap imports

  Bartłomiej Dach · 2021-06-27 12:12:04 +02:00
  8f5e3092ab
• Add comments mentioning shortcomings and avoid potential double check
  Dean Herbert · 2021-06-27 19:07:35 +09:00
  9120321731
• Bypass optimised existing check in SkinManager (due to custom hashing function)
  Dean Herbert · 2021-06-27 16:35:13 +09:00
  44f875b802
• Add optimised existing check earlier in import process
  Dean Herbert · 2021-06-27 16:34:40 +09:00
  e493685c14
• Remove comparison of online beatmap IDs during dedupe checks
  Dean Herbert · 2021-06-27 14:48:57 +09:00
  15af28d2a0
• Remove overly verbose logging during beatmap imports
  Dean Herbert · 2021-06-27 14:29:02 +09:00
  46f8100f43
• Make Populate abstract to avoid unnecessary base call async complexity
  Dean Herbert · 2021-06-27 14:29:02 +09:00
  d1f852d102
• Merge pull request #13668 from gagahpangeran/od-filter

  Add overall difficulty in query search filter

  Dean Herbert · 2021-06-27 12:00:36 +09:00
  f6919b70c9
• Improve precision for repeat edges
  Naxess · 2021-06-27 03:26:35 +02:00
  4cfa0ae5ec
• Add "or equal to" to volume threshold xmldocs
  Naxess · 2021-06-27 02:30:12 +02:00
  2cd7eda3c4
• Order hitobjects by endtime
  Naxess · 2021-06-27 01:25:03 +02:00
  0c0fd291d9
• Use local variables for hasHitsound & couldHaveHitsound
  Naxess · 2021-06-27 00:04:30 +02:00
  4796b1b208
• Rename hasHitsounds -> mapHasHitsounds
  Naxess · 2021-06-26 23:49:25 +02:00
  5bc08ebadb
• Add negligible template to PossibleTemplates
  Naxess · 2021-06-26 23:49:06 +02:00
  d29e6f4695
• Use HitSampleInfo.AllAdditions instead of new list
  Naxess · 2021-06-26 23:48:28 +02:00
  1913084342
• Fix comments in few hitsounds check tests
  Naxess · 2021-06-26 23:43:08 +02:00
  5642d321b7
• Factor out edge type logic
  Naxess · 2021-06-26 20:45:31 +02:00
  f78cc9397e
• Make || and && priority explicit
  Naxess · 2021-06-26 20:44:39 +02:00
  51147405c5