51 Commits

• Fix classic fallback not having a transformer (and only add if required)
  Dean Herbert · 2024-07-04 20:17:39 +09:00
  b2af49c102
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove completely incorrect check before applying ruleset transformer
  Dean Herbert · 2022-10-12 17:07:13 +09:00
  1c93551590
• Add new default skin "argon"
  Dean Herbert · 2022-09-19 23:16:46 +09:00
  0f7b38f4c3
• Remove "default" prefix from naming
  Dean Herbert · 2022-09-18 00:15:26 +09:00
  41e69fbca6
• Rename references to DefaultSkin to have Triangles suffix
  Dean Herbert · 2022-09-17 23:57:25 +09:00
  51841988bf
• Rename CreateLegacySkinProvider to CreateSkinTransformer and apply to all skins
  Dean Herbert · 2022-09-15 20:18:10 +09:00
  c7f8f948b9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename OnSourceChanged and expand on xmldoc to mention that it doesn't fire SourceChanged
  Dean Herbert · 2021-10-12 13:04:48 +09:00
  d7cbacc5a0
• Replace Add/Reset methods with single Set method
  Dean Herbert · 2021-10-12 11:55:07 +09:00
  39a3482458
• Add xmldoc and remove any question of how the intitial flow is being run
  Dean Herbert · 2021-07-06 17:18:45 +09:00
  cd4885e450
• Remove double fetch/binding of parent source
  Dean Herbert · 2021-07-06 16:51:29 +09:00
  935fbe7cc6
• Remove BindableList usage
  Dean Herbert · 2021-07-06 16:40:23 +09:00
  93ef783339
• Use LastOrDefault instead
  Salman Ahmed · 2021-06-28 12:43:58 +03:00
  66fc95c111
• Remove resolution to SkinManager and use pattern matching instead
  Salman Ahmed · 2021-06-28 12:43:13 +03:00
  7197998a10
• Merge branch 'master' into ruleset-resources-skin
  Salman Ahmed · 2021-06-28 11:16:37 +03:00
  177bfe1234
• Add comment explaining insertion of ruleset skin before default skin

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2021-06-28 09:38:42 +03:00
  779a1b322c
• ResourcesSkin -> ResourceStoreBackedSkin
  Salman Ahmed · 2021-06-28 09:18:29 +03:00
  f598de4cdb
• Maintain ruleset resources skin across multiple source changes
  Salman Ahmed · 2021-06-28 09:11:28 +03:00
  692f24437e
• Simplify instantiation
  Dean Herbert · 2021-06-28 14:51:27 +09:00
  f777741ca7
• Add inline comment mentioning why CreateChildDependencies is being used in this instance
  Dean Herbert · 2021-06-28 14:39:55 +09:00
  e387feb1d6
• Dispose ResourcesSkin before clearing skin sources
  Salman Ahmed · 2021-06-26 12:34:30 +03:00
  e8e9fdd533
• Fix RulesetSkinProvidingContainer potentially late in setting up skin sources
  Salman Ahmed · 2021-06-25 10:05:51 +03:00
  f07008a0a2
• Convert RulesetResourcesSkin to plain ResourcesSkin and pass non-null resources
  Salman Ahmed · 2021-06-24 10:07:38 +03:00
  a98b5618b8
• Handle case where SkinManager sources aren't part of AllSources

  In tests.

  Salman Ahmed · 2021-06-23 10:44:23 +03:00
  d484469906
• Add ruleset resources skin before SkinManager.DefaultSkin
  Salman Ahmed · 2021-06-23 10:09:25 +03:00
  53fa229880
• Resolve conflict issues
  Salman Ahmed · 2021-06-22 20:38:24 +03:00
  ee84364d7c
• Merge branch 'master' into ruleset-resources-skin
  Salman Ahmed · 2021-06-22 20:36:49 +03:00
  896c1dc202
• Update and improve code documentation

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2021-06-22 12:05:17 +03:00
  71e2815e7e
• Add missing newline
  Dean Herbert · 2021-06-22 16:20:09 +09:00
  14bdcef26b
• Expose skin sources via ISkinSource and revert to consuming based on hierarchy
  Dean Herbert · 2021-06-22 16:19:55 +09:00
  0ad189e357
• Fix leak due to not properly unbinding SourceChanged event on disposal
  Salman Ahmed · 2021-06-22 05:05:41 +03:00
  ec040ff3fc
• Fix default skin potentially added twice in RulesetSkinProvidingContainer
  Salman Ahmed · 2021-06-22 03:45:43 +03:00
  caa90bccc6
• Propagate SourceChanged events from SkinManager down in the ruleset skin container
  Salman Ahmed · 2021-06-22 03:45:24 +03:00
  627c857da8
• Add back SkinManager.DefaultSkin to the ruleset skin lookup sources
  Salman Ahmed · 2021-06-22 02:54:34 +03:00
  97dbc7f20e
• Isolate RulesetSkinProvidingContainer from falling back to parent skin sources

  For simplicity of lookup order, and which sources are used for the lookup.

  Salman Ahmed · 2021-06-22 02:53:22 +03:00
  d53a43cf3c
• Remove implicit LegacySkin check and refactor anything using it
  Salman Ahmed · 2021-06-21 04:16:58 +03:00
  5cfd0e3223
• Fix incorrect return value
  Salman Ahmed · 2021-06-17 03:48:29 +03:00
  780388d174
• Remove default skin from the ruleset skin sources

  That one doesn't need any changes to it, can be fetched from the `SkinManager` instead.

  Salman Ahmed · 2021-06-16 17:24:31 +03:00
  74ad6f9117
• Consider not adding legacy skin transformers to non-legacy skins
  Salman Ahmed · 2021-06-16 17:24:16 +03:00
  52ddf08532
• Revert GetRulesetTransformedSkin accessibility change

  This reverts commit 521077b714.
  
  Forgot to do it when I made this `protected`, but subclasses in test scenes require this.

  Salman Ahmed · 2021-06-16 16:49:38 +03:00
  5ebf570ec4
• Make getRulesetTransformedSkin private
  Dean Herbert · 2021-06-16 17:44:18 +09:00
  521077b714
• Fix potentially adding the same skin multiple times
  Salman Ahmed · 2021-06-11 17:55:07 +03:00
  b6947c25ec
• Also handle null Ruleset.CreateLegacySkinProvider values

  Let's just go this way for now, maybe it's a better choice to always create transformers and disallow null, but it's too much work and out of scope at this point

  Salman Ahmed · 2021-06-11 16:26:54 +03:00
  108a3deb27
• Move TODO comment to correct location
  Salman Ahmed · 2021-06-11 11:46:30 +03:00
  2e01e61177
• Add skin providing ruleset resources in RulesetSkinProvidingContainer
  Salman Ahmed · 2021-06-11 00:25:22 +03:00
  169c98f963
• Make RulesetSkinProvidingContainer able to be overriden for testing purposes
  Salman Ahmed · 2021-06-10 16:36:46 +03:00
  ef2c4fd0d8
• Refrain from attempting to transform null skins
  Salman Ahmed · 2021-06-10 16:36:45 +03:00
  09a2d008d2
• Expose default SkinManager providers for use in RulesetSkinProvidingContainer
  Salman Ahmed · 2021-06-10 13:07:32 +03:00
  c3a2f2c2a4
• Remove mentioning of "layer" in skin providers

  `SkinSources` sounds better.

  Salman Ahmed · 2021-06-10 11:55:26 +03:00
  18edbdd135