116 Commits

• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Update hit error metre to use new icons

  - [ ] Depends on https://github.com/ppy/osu-resources/pull/317.

  Dean Herbert · 2024-04-04 14:31:40 +08:00
  9521c1e3e4
• remove useless DrawablePool
  cdwcgt · 2024-03-01 13:20:37 +09:00
  4ad8bbb9e2
• Fix ColourHitErrorMeter not loading pooled drawables ahead of time
  Bartłomiej Dach · 2024-01-15 21:40:07 +01:00
  97e08f5071
• Clear transformations with more fire
  Dean Herbert · 2023-12-13 17:00:21 +09:00
  3131d37621
• Fix HitError Clear methods not correctly returning pooled drawables
  Dean Herbert · 2023-12-13 16:13:23 +09:00
  f2c6c348be
• Rename ISkinnableDrawable to ISerialisableDrawable
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  d159d6b970
• Move skin component localisations to namespaces
  Dean Herbert · 2023-02-03 15:34:57 +09:00
  cf8cfe0d2c
• Fix incorrectly applied enum localisation
  Dean Herbert · 2023-02-03 15:27:11 +09:00
  50559643bb
• refactor: change namespacing to allow osu-localisation-analyzer to process all strings
  tsrk · 2023-02-02 00:46:14 +00:00
  0fb6a63709
• feat: add localisation for Skin editor components
  tsrk · 2023-02-01 23:48:05 +00:00
  8645e705fd
• Move setting up to be in line with other toggle
  Dean Herbert · 2023-01-10 18:07:15 +09:00
  3c93d0551c
• Start bars invisible
  Dean Herbert · 2023-01-10 18:06:45 +09:00
  63ce5787e7
• Address unclear naming issue
  mk56-spn · 2023-01-09 21:04:51 +01:00
  602062f011
• Add the ability to toggle the visibility of the main bar in BarHitErrorMeter.cs
  mk56-spn · 2023-01-09 18:51:51 +01:00
  d6f60db234
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove upper limit for pooling
  Dean Herbert · 2022-11-15 12:31:25 +09:00
  489dca79a1
• Fix number of judgements shown potentially exceeding upper limit
  Dean Herbert · 2022-11-15 12:31:25 +09:00
  308ed1abd1
• Ensure flowing animation starts correctly from zero
  Dean Herbert · 2022-11-15 12:04:40 +09:00
  59a8603728
• Apply pooling support to ColourHitErrorMeter
  Dean Herbert · 2022-11-15 12:04:40 +09:00
  aef6ee23eb
• Apply nullability to BarHitErrorMeter
  Dean Herbert · 2022-11-15 11:33:27 +09:00
  a86b50d62a
• Add pooling support to BarHitErrorMeter
  Dean Herbert · 2022-11-15 11:33:27 +09:00
  576f462f59
• Fix bar hit error meter labels not clearing when setting to none
  Joseph Madamba · 2022-10-27 23:59:01 -07:00
  87328dd1f5
• Fix formatting issues
  Dean Herbert · 2022-10-17 13:22:06 +09:00
  1e7b8cd227
• Only create hit error bar icon containers once

  Move icon container creation to BDL, and only recreate the contained
  icon when `recreateLabels` is called

  outfoxxed · 2022-10-16 11:47:21 -07:00
  85de802793
• Reuse existing code in hit error bar fix

  Use `UprightAspectMaintainingContainer` instead of a local fix for
  hit error bar orientation

  outfoxxed · 2022-10-16 10:06:38 -07:00
  d6030891a2
• Fix hit error bar icon orientation

  Icons now keep their original orientation when the hit error bar is
  flipped

  outfoxxed · 2022-10-16 02:55:10 -07:00
  cd1885a17b
• Decrease precision of spacing setting
  Dean Herbert · 2022-09-22 15:49:02 +09:00
  f0dcda9acc
• Fix bindable flow, code quality, everything
  Dean Herbert · 2022-09-22 15:45:23 +09:00
  26d98323ff
• Fix changing shape causing alpha to be permanently reset to zero
  Dean Herbert · 2022-09-22 15:24:57 +09:00
  0f663deda0
• Fix other weirdness in variable and description naming
  Dean Herbert · 2022-09-22 15:21:27 +09:00
  ae70b2c32f
• Remove "Opacity" setting

  This should be implemented at a higher level

  Dean Herbert · 2022-09-22 15:19:01 +09:00
  19db7c5977
• Rename judgement count to not mention "shape"
  Dean Herbert · 2022-09-22 15:18:20 +09:00
  f3898da37a
• Framework change adressed
  Mk-56spn · 2022-09-10 21:24:29 +02:00
  c00bf61273
• Merge branch 'ppy:master' into Colour_hit_meter_improved
  MK56 · 2022-09-10 21:16:23 +02:00
  8661dc3c93
• fixed shape bindable not working, test creation, removal of Clear(), adjusted settings names
  Mk-56spn · 2022-09-10 20:30:43 +02:00
  f6aef73f9e
• Fix enum to STRING????????? conversion (and use bindable flow)
  Dean Herbert · 2022-09-09 16:30:08 +09:00
  05797cb9e5
• Fix Main file issues
  Mk-56spn · 2022-09-08 11:58:14 +02:00
  07c16224d2
• chore(osu.Game): combine Osu.Colour.{Draw,Text}ForHitResult into OsuColour.ForHitResult
  Acid Chicken (硫酸鶏) · 2022-09-07 23:34:46 +09:00
  267465df18
• Fix some test issues
  Mk-56spn · 2022-09-05 04:49:48 +02:00
  aace334fb3
• refactor(osu.Game): separate OsuColour.ForHitResult by usage
  Acid Chicken (硫酸鶏) · 2022-09-05 01:58:57 +09:00
  5f0832ead7
• Large code refactor, Implementation of shapes option drop down
  Mk-56spn · 2022-09-04 17:24:12 +02:00
  0c6d8efa28
• Bug fixing and parameter adjustments
  Mk-56spn · 2022-09-03 01:27:22 +02:00
  51061c3a12
• Initial version
  Mk-56spn · 2022-09-02 23:07:30 +02:00
  534c40e18e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Revert most unnecessary changes

  Turns out `AlwaysPresent` at top level is actually enough.
  
  This reverts commit 86163d2225.

  Dean Herbert · 2022-06-13 23:58:14 +09:00
  bd9ea9bd6f
• Fix hit error meters not updating visual state when hidden

  It is an expectation of users that when the HUD is shown after a period
  of being hidden, it will visually reflect the state based on recent
  judgements.
  
  To achieve this, I've added `AlwaysPresent` and moved the transform
  application to the meter level, rather than at a child level. If this is
  seen as a bad direction, `AlwaysPresent` can be applied to the drawable
  children and the transforms can be moved back.
  
  Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
  could potentially be removed and reduce `AlwaysPresent` usage by one.
  Can do that refactor as part of this PR if preferred.
  
  Closes #18624.

  Dean Herbert · 2022-06-13 16:38:57 +09:00
  86163d2225
• Add failing test coverage showing hit meters don't update when not visible
  Dean Herbert · 2022-06-13 16:36:22 +09:00
  17eaf7bb5c
• Fix centering of labels using Height instead of location to better handle rotations
  Dean Herbert · 2022-03-18 20:17:04 +09:00
  ed90dc6d6b
• Better centre text labels for hit error meter
  Dean Herbert · 2022-03-18 20:11:05 +09:00
  bd488d139d