78 Commits

• Use OverlayColourProvider for BeatDivisorControl icon colour
  Marvin Schürz · 2025-07-01 10:38:22 +02:00
  709bc9c330
• Change icon colour of BeatDivisorControl to be light
  marvin · 2025-06-30 18:43:37 +02:00
  ccc1a7ae6f
• Block all mouse events at BeatDivisorControl and revert animated button change
  Dean Herbert · 2025-04-09 14:56:30 +09:00
  27edee477d
• Fix mouse down actions being leaked through buttons
  Dean Herbert · 2025-04-08 14:28:48 +09:00
  e42301058f
• Remove non-visible "beat snap" text in editor
  Dean Herbert · 2025-03-20 15:46:09 +09:00
  80ff974594
• Stop beat divisor "slider" from accepting focus
  Dean Herbert · 2025-02-17 15:06:35 +09:00
  d5566831d2
• Adjust visuals of tick display (and fine tune some other timeline elements)
  Dean Herbert · 2024-08-21 16:46:14 +09:00
  7e6490133d
• Fix crash on attempting to edit particular beatmaps

  Closes https://github.com/ppy/osu/issues/29492.
  
  I'm not immediately sure why this happened, but some old locally
  modified beatmaps in my local realm database have a `BeatDivisor` of 0
  stored, which is then passed to
  `BindableBeatDivisor.SetArbitraryDivisor()`, which then blows up.
  
  To stop this from happening, just refuse to use values outside of a sane
  range.

  Bartłomiej Dach · 2024-08-20 13:51:58 +02:00
  bb964e32fa
• Ensure timeline ticks aren't hidden by other pieces

  Addresses https://github.com/ppy/osu/issues/28667.

  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  50818da166
• Adjust calls to GetContainingInputManager()
  Bartłomiej Dach · 2024-06-18 07:41:19 +02:00
  659505f711
• Null-propagate all calls to GetContainingFocusManager()
  Bartłomiej Dach · 2024-06-18 07:30:46 +02:00
  8a4ae5d23d
• Update focus specifications in line with framework changes
  Dean Herbert · 2024-05-22 21:32:49 +08:00
  66ceda1d67
• Apply padding to GridContainers directly
  Andrei Zavatski · 2024-02-20 23:18:37 +03:00
  2543a48ac8
• Prevent custom divisor ranges from halting preset cycling

  A custom divisor like 24 or 32 will result in a range containing
  many divisors that are already in the `Common` and `Triplets` presets.
  When this happens, it can become impossible to cycle between presets,
  because the preset can only be changed if the new divisor isn't already
  contained within the current preset's range.

  Mike Will · 2024-01-24 18:31:39 -05:00
  9e1c242713
• Update autoselect implementation to work correctly with framework changes
  Bartłomiej Dach · 2023-10-31 08:38:22 +01:00
  144006fbe8
• Merge branch 'master' into beat-divisor-select-text-on-click
  Bartłomiej Dach · 2023-10-31 08:36:53 +01:00
  8a68333425
• Change some component samples to go better with overlay pop-in samples
  Jamie Taylor · 2023-08-17 18:36:37 +09:00
  d10d7b6ea4
• Change BeatDivisorControl to retrive bindable divisor via DI
  Dean Herbert · 2023-07-14 14:03:25 +09:00
  56acc9e3dd
• Merge branch 'master' into beat-divisor-better-defaults
  Bartłomiej Dach · 2023-06-08 20:35:03 +02:00
  4b3b22f046
• Select all text when popover is initially shown

  Depends on https://github.com/ppy/osu-framework/pull/5823.

  Dean Herbert · 2023-06-09 02:27:22 +09:00
  c1743dbe1d
• Remove unused method
  Bartłomiej Dach · 2023-06-07 23:38:06 +02:00
  3c8f387a6c
• Remove unused virtual spec
  Bartłomiej Dach · 2023-06-07 23:38:06 +02:00
  d9281ac8c7
• Use existing next/previous methods (and remove looping behaviour)
  Dean Herbert · 2023-06-08 01:01:29 +09:00
  3a01498789
• Add ability to cycle beat snap divisor using hotkeys

  Defaults to Ctrl+Shift+Wheel (as per stable).
  
  Closes #23785.

  Dean Herbert · 2023-06-07 17:15:15 +09:00
  2c89af608a
• Remember the last used custom divisor when cycling divisor types
  Dean Herbert · 2023-06-01 17:11:49 +09:00
  32207d4112
• Apply NRT to BeatDivisorControl
  Dean Herbert · 2023-06-01 16:58:14 +09:00
  bcde2cbc73
• Use better defaults of 1/4 and 1/6 when cycling types
  Dean Herbert · 2023-06-01 16:28:03 +09:00
  f52ed41f10
• Tidy up implementation and ensure non-solid ticks start at zero alpha
  Dean Herbert · 2023-05-24 13:49:29 +09:00
  561b759bf9
• Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements

  Add ghost ticks to exhibit current divisor on `BeatDivisorControl`

  Dean Herbert · 2023-05-24 13:41:48 +09:00
  8f1f1955df
• Last instead of Max divisor to match code elsewhere
  Gyoshi · 2023-05-23 18:45:49 +02:00
  7fe19d1992
• Code styling
  Gyoshi · 2023-05-23 18:44:20 +02:00
  c5ef3ae181
• Use RangePadding to align mouse with slider
  Gyoshi · 2023-05-23 18:16:14 +02:00
  b5f8093941
• Small format
  Gyoshi · 2023-05-23 15:11:27 +02:00
  7b1e8ede54
• Remove duplicate code by making GetDivisorForBeatIndex method more general
  Gyoshi · 2023-05-23 15:05:38 +02:00
  1b32370c6a
• Small format & comment
  Gyoshi · 2023-05-23 14:30:35 +02:00
  37a796306d
• Add ghost ticks to exhibit current divisor on BeatDivisorControl
  Johannes vd Berg · 2023-05-23 12:57:25 +02:00
  ebda35c3c9
• Update beat divisor control to show ticks in more visually correct locations

  As proposed in https://github.com/ppy/osu/discussions/23527.

  Dean Herbert · 2023-05-17 16:34:12 +09:00
  87ff28b022
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add ability to use Shift+Number to set current beat divisor in editor
  Dean Herbert · 2022-10-24 15:20:15 +09:00
  1d5df15027
• Reorganise beatmap snap control to work better in compact mode
  Dean Herbert · 2022-10-13 15:47:54 +09:00
  c3902728f6
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge branch 'master' into editor-beat-divisor-size-static
  Bartłomiej Dach · 2022-05-24 23:17:02 +02:00
  5f6baaca13
• Adjust marker to match design proportions
  Dean Herbert · 2022-05-24 18:26:01 +09:00
  3ace5f135e
• Update BeatDivisorControl to better match new designs and metrics
  Dean Herbert · 2022-05-24 18:26:01 +09:00
  3c2e57bf00
• Handle beat divisor input on mouse down, rather than mouse up

  It felt way too unresponsive.

  Dean Herbert · 2022-05-24 18:16:19 +09:00
  e6087f5f5b
• Reword popup text to read better (or more vaguely)

  Removed some words but also don't mention "smaller" because it's...
  musically incorrect and also functionally incorrect – entering 1/[8]
  will result in 1/16 also being populated for instance.

  Dean Herbert · 2022-02-28 15:26:50 +09:00
  2be40f36f7
• Remove unused using statement
  Dean Herbert · 2022-02-28 15:24:02 +09:00
  368eadd8d1
• Automatically focus divisor textbox and hide popover after successful change
  Dean Herbert · 2022-02-28 15:23:01 +09:00
  3634e12e66