5678 Commits

• Add legacy reference health processor
  Dan Balasescu · 2023-11-10 18:40:21 +09:00
  fecc6f580b
• Merge pull request #25348 from bdach/less-basic-touchscreen-detection

  Implement basic touchscreen detection

  Dean Herbert · 2023-11-10 18:01:40 +09:00
  1c63f1f89d
• Merge branch 'master' into slider-combo-matching-2
  Dean Herbert · 2023-11-09 18:45:37 +09:00
  92043f45a4
• Merge branch 'master' into less-basic-touchscreen-detection
  Bartłomiej Dach · 2023-11-09 17:36:48 +09:00
  13b599b9b6
• Merge branch 'master' into better-touch-settings
  Dean Herbert · 2023-11-07 23:21:59 +09:00
  c00a1d948a
• HitObject Selection logic and separation for gamemodes

  + moved time_regex into EditorTimestampParser

  ratinfx · 2023-11-07 01:36:58 +01:00
  aa87e0a44d
• Rename setting to TouchDisableGameplayTaps for better visibility when searching
  Susko3 · 2023-11-07 00:13:46 +01:00
  05d9418718
• Fix tests by using the correct setting for touch input
  Susko3 · 2023-11-06 20:53:22 +01:00
  ea357bafdd
• Just use yellow for system mods
  Bartłomiej Dach · 2023-11-06 16:40:57 +01:00
  a136f272cf
• Fix unused variable
  Bartłomiej Dach · 2023-11-06 12:18:02 +01:00
  4bc36a6c90
• Use better colours for system mods
  Bartłomiej Dach · 2023-11-06 11:41:23 +01:00
  6deac9a5a4
• Use placeholder mod icon for touch device
  Bartłomiej Dach · 2023-11-06 10:14:56 +01:00
  204cd541e2
• Improve code quality
  Givikap120 · 2023-11-04 17:25:09 +02:00
  57170501cd
• Declare Touch Device incompatible with Autopilot

  With Autopilot active, Touch Device no longer matters.

  Bartłomiej Dach · 2023-11-02 22:57:05 +01:00
  8e9006b5d5
• Do not attempt to turn on Touch Device in song select with autoplay active
  Bartłomiej Dach · 2023-11-02 22:56:43 +01:00
  8784dd42c0
• Automatically activate and deactivate touch device mod in song select
  Bartłomiej Dach · 2023-11-02 19:45:48 +01:00
  2f6ff893b5
• Mark ModTouchDevice as always valid for submission
  Bartłomiej Dach · 2023-11-02 19:25:57 +01:00
  68efb3c110
• Generalise notion of 'touch device' mod
  Bartłomiej Dach · 2023-11-02 19:14:05 +01:00
  9f11a04cc7
• Fix non-classic osu! combo not matching expectations
  Dean Herbert · 2023-11-02 19:27:55 +09:00
  818432fab4
• Merge pull request #25328 from bdach/mod-cleanups-docs

  Clean up mod usability flags

  Dean Herbert · 2023-11-01 15:48:47 +09:00
  57d8b5ddc9
• Seal a few more multiplayer playability flags of rate-changing mods

  Not really changing anything, just tightening things down to curb
  possible funny business.

  Bartłomiej Dach · 2023-10-31 16:20:33 +01:00
  a90f8dd4f6
• Seal UnknownMod

  Not a class for extension.

  Bartłomiej Dach · 2023-10-31 16:18:09 +01:00
  955e2ed051
• Mark ModScoreV2 as invalid for multiplayer

  Doesn't do much for the client; mostly a safety for osu-web's sake,
  as without the change it could theoretically fail to validate the mod
  properly in multiplayer contexts.

  Bartłomiej Dach · 2023-10-31 16:16:59 +01:00
  a644c75957
• Seal ModScoreV2

  Nobody should ever need to extend it.

  Bartłomiej Dach · 2023-10-31 16:16:14 +01:00
  456f4ebba2
• Seal ModAutoplay playability flags

  Can't do much more than that due to the unfortunate fact of Cinema
  inheriting from Autoplay.

  Bartłomiej Dach · 2023-10-31 16:15:10 +01:00
  3a2645efb1
• Add xmldoc to Mod playability flags
  Bartłomiej Dach · 2023-10-31 16:13:44 +01:00
  7ea298a1b6
• Fix some new nullable inspections
  Dean Herbert · 2023-10-30 15:10:10 +09:00
  a91b704d21
• Fix catch distance snap provider not hiding slider properly

  Regressed in https://github.com/ppy/osu/pull/25171.
  
  The old code was kinda dependent on correct order of setting `Disabled`.
  `CatchHitObjectComposer` would disable distance spacing in its BDL, and
  then via the base `DistancedHitObjectComposer.LoadComplete()`, the
  slider would be faded out. The switch to composition broke that
  ordering.
  
  To fix, stop relying on ordering and just respond to changes as they
  come. That's what bindables are for.

  Bartłomiej Dach · 2023-10-26 15:46:32 +02:00
  79910df959
• Merge pull request #25185 from bdach/minimum-sample-volume
  Dean Herbert · 2023-10-24 22:04:43 +09:00
  34505b3933
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Fix fudge not being applied
  Dean Herbert · 2023-10-20 20:18:14 +09:00
  906b700aca
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Merge branch 'master' into legacy-tick-test-coverage
  Dean Herbert · 2023-10-20 16:41:32 +09:00
  686c45e21b
• Remove unused using directive
  Bartłomiej Dach · 2023-10-19 20:45:47 +02:00
  2c6bf9e346
• Move beat snap grid implementation details to ScrollingHitObjectComposer
  Dean Herbert · 2023-10-19 23:54:34 +09:00
  013b5fa916
• Merge branch 'master' into taiko-beat-snap-grid
  Dean Herbert · 2023-10-19 23:53:01 +09:00
  52c2eb93de
• Remove DistancedHitObjectComposer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  144ef5a87c
• Remove DistancedHitObjectComposer inheritance from osu! composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  dcfd6a0a8a
• Split IPositionSnapProvider from IDistanceSnapProvider

  In preparation to remove `DistancedHitObjectComposer`, split off
  `IPositionSnapProvider` from `IDistanceSnapProvider`.
  
  `DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
  only interface member at all, it was just forwarding it for subclasses
  to override to their own leisure.

  Bartłomiej Dach · 2023-10-19 11:45:24 +02:00
  3ab083b696
• Add inline commentary in Mod{Day,Night}core about different speed adjustments
  Bartłomiej Dach · 2023-10-18 12:27:16 +02:00
  cff69d63a6
• Take in IBindables and tidy up multiplier handling
  Dean Herbert · 2023-10-18 17:39:13 +09:00
  9907adc337
• Move audio adjustment hookup to own method for clarity
  Dean Herbert · 2023-10-18 17:38:11 +09:00
  161890292f
• Also share ScoreMultiplier implementation
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  e56ff33271
• Split common functionality from rate adjust mods into helper class
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  43238b0cee
• Merge branch 'master' into pitch_change
  Dean Herbert · 2023-10-18 16:33:03 +09:00
  eabfcfbf2a
• Merge branch 'master' into legacy-tick-test-coverage
  Dan Balasescu · 2023-10-18 15:21:31 +09:00
  939b55020c
• Merge pull request #25155 from peppy/fix-new-inspections

  Fix various new rider EAP inspections

  Bartłomiej Dach · 2023-10-17 17:04:39 +02:00
  e927267c4d
• Merge pull request #25152 from bdach/key-binding-deduplication

  Clear pre-existing bindings of same key combination to single action

  Dean Herbert · 2023-10-17 17:49:51 +09:00
  d9fc532a9f
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Remove redundant explicit array type specification
  Bartłomiej Dach · 2023-10-17 10:26:02 +02:00
  7abd7fe658