90 Commits

• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Remove legacy non-pooled pathway to DrawableJudgement
  Dean Herbert · 2024-08-13 21:03:00 +09:00
  2221c4891f
• Add log output when judgements aren't being pooled
  Dean Herbert · 2024-08-13 20:57:23 +09:00
  bb0c9e2497
• Never call prepareDrawables from unsafe context

  I can't mentally figure out *what* is causing the issue here, but in the
  case where `prepareDrawables` is called from
  `JudgementBody.OnSkinChanged` (only happens in a non-pooled scenario),
  things go very wrong.
  
  I think a smell test is enough for anyone to agree that the flow was
  very bad. Removing this call doesn't seem to cause any issues.
  
  `runAnimation` should always be called in `PrepareForUse` (both pooled
  and non-pooled scenarios) so things should still always be in a correct
  state.
  
  Closes #29398.

  Dean Herbert · 2024-08-13 20:57:20 +09:00
  d74ac57092
• Don't rely on single-use properties
  Dan Balasescu · 2024-07-18 19:07:02 +09:00
  a7e110f669
• Fix judgement animation getting cut early
  Dan Balasescu · 2024-07-16 17:32:59 +09:00
  bd4f3e28d9
• Use hopefully safer implementation of anchoring judgements to objects
  Bartłomiej Dach · 2024-05-29 11:11:43 +02:00
  a6c776dac8
• Add support for showing tick misses
  Dean Herbert · 2023-12-20 20:23:19 +09:00
  9b383e3276
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into taiko-judgement-fixes
  Dan Balasescu · 2022-11-11 15:48:33 +09:00
  5bdbf56f43
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Remove unnecessary centering logic in DrawableJudgement
  Dean Herbert · 2022-11-07 17:19:32 +09:00
  2b72c3833b
• Update usages of RemoveInternal
  Dean Herbert · 2022-08-29 15:57:40 +09:00
  105aa01e7d
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Ensure proxied judgement content is correctly depth-ordered
  Bartłomiej Dach · 2021-08-01 15:21:31 +02:00
  f868a201f5
• Remove redundant arguments
  PercyDan54 · 2021-07-05 23:52:39 +08:00
  e1c646b9b2
• Remove obsoleted DrawableJudgement methods

  Undated, but change was made on 2020-11-18.

  Dean Herbert · 2021-06-09 14:09:23 +09:00
  a87226ab10
• Fix taiko leaving behind empty judgements on legacy skins
  Bartłomiej Dach · 2021-03-06 16:02:20 +01:00
  06e42b4b4c
• Uncomment incorrectly commented lines
  Dean Herbert · 2020-11-25 12:11:44 +09:00
  c46d655832
• Remove left over logging line
  Dean Herbert · 2020-11-24 15:28:03 +09:00
  1682260677
• Fix DrawableJudgement not always animating correctly on skin change

  If the skin is changed before gameplay has started (at the loading
  screen) it is possible for a sequence of events to occur which results
  in the animation not being played:
  
  - `SkinReloadableDrawable` runs its BDL load (and calls `OnSkinChanged`
    once)
  - User changes skin, triggering `DrawableJudgement`'s skin change
    handling (binding directly on the `SkinSource` locally)
  - This will call `PrepareDrawables` and reinitialise the
    `SkinnableDrawable` child hierarchy, then immediately apply the
  animations to it.
  - The new `SkinnableDrawable` will then get the `SkinChanged` event and
    schedule a handler for it, which will run on its first Update call.
  - Any added animations will be lost as a result.
  
  Fixed by binding directly to the `SkinnableDrawable`'s `OnSkinChanged`.
  This has the added bonus of not needing to reinitialise the child
  hierarchy on skin change (which felt a bit weird in the first place).

  Dean Herbert · 2020-11-24 15:23:53 +09:00
  ee33f62809
• Add comment covering intentional call to ClearTransformsAfter
  Dean Herbert · 2020-11-23 15:20:59 +09:00
  19faa2b9bb
• Rewind judgement transforms before clearing
  Bartłomiej Dach · 2020-11-21 17:56:49 +01:00
  9f997db958
• Show main judgement content above hitobjects
  Dean Herbert · 2020-11-20 16:25:48 +09:00
  7fe0923fcf
• Add null check for disposal safety
  Dean Herbert · 2020-11-19 14:04:43 +09:00
  ba735584fa
• Update xmldoc to match new behaviour
  Dean Herbert · 2020-11-18 19:38:38 +09:00
  b3bec81b79
• Reduce nesting of skinned component to reduce exposed surface
  Dean Herbert · 2020-11-18 19:34:27 +09:00
  8522ddc61e
• Fix animation playback not running on skin change
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  ee8804b50b
• Fix hit lighting dictating lifetime even when not present in skin
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  9d3de5bca0
• Handle DrawableJudgement lifetime more flexibly
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  72a15ef2dc
• Remove fades from DrawableJudgement itself
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  94886a09b2
• Move result type to ctor
  Dean Herbert · 2020-11-17 15:43:54 +09:00
  8247e6ce91
• Add xmldoc coverage of Apply()
  Dean Herbert · 2020-11-17 15:03:26 +09:00
  e4f1e52422
• Move all extended animation logic out of DrawableJudgement
  Dean Herbert · 2020-11-17 14:59:34 +09:00
  f465dd5a5e
• Make Apply non-virtual
  Dean Herbert · 2020-11-17 14:05:13 +09:00
  9dfa4249e0
• Remove unnecessary depth setter
  Dean Herbert · 2020-07-28 12:16:01 +09:00
  a210deee9a
• Prevent DrawableJudgement from removing other children
  Bartłomiej Dach · 2020-07-27 19:07:21 +02:00
  5fc7039bf2
• Fix judgement animations not resetting on use
  smoogipoo · 2020-07-13 21:21:59 +09:00
  8a3cadc111
• Make Apply virtual to further simplify application process
  Dean Herbert · 2020-07-10 18:35:20 +09:00
  f872343bab
• Move application of judgements to Apply method
  Dean Herbert · 2020-07-10 18:34:31 +09:00
  8aff828dfe
• Add per-result type pooling
  Dean Herbert · 2020-07-06 12:54:39 +09:00
  51050ec4ef
• Use DrawablePool for DrawableJudgements
  Dean Herbert · 2020-07-04 16:45:50 +09:00
  ffec4298a7
• Move judgement colours to OsuColour
  smoogipoo · 2020-03-18 17:21:36 +09:00
  5f09c70f75
• Use [Resolved] wherever possible
  recapitalverb · 2020-02-14 20:14:00 +07:00
  c753cb46c5
• Fix judgement sizes not matching legacy skins (#6145)

  Fix judgement sizes not matching legacy skins

  Dean Herbert · 2019-09-19 18:49:35 +09:00
  0640b2eb35
• Fix scaling mode being applied to judgements
  Dean Herbert · 2019-09-19 17:36:32 +09:00
  e6c36a8bc7
• Fix judgement sizes not matching skins stable
  Dean Herbert · 2019-09-18 02:56:03 +09:00
  26eca5b1f4
• Add initial implementation of hit lighting

  Requires a supporting skin, like osu!classic for now.

  Dean Herbert · 2019-09-18 02:49:54 +09:00
  ba76f09c99
• Update naming
  Dean Herbert · 2019-08-30 15:13:29 +09:00
  70e417533f