80 Commits

• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove fade transitions
  Salman Alshamrani · 2024-10-24 16:20:49 -04:00
  1d559b2cad
• Fix placement blueprints sometimes not behaving correctly with touch input

  More specifically, this fixes placement blueprints not beginning placement when using touch input while the cursor was previously outside compose area, due to the placement blueprint not existing (removed from the scene by `ComposeBlueprintContainer`).

  Salman Alshamrani · 2024-10-23 16:51:21 -04:00
  3a4d5af83e
• Add xmldoc to SnapType
  OliBomby · 2024-10-03 11:16:37 +02:00
  2c39ecbda3
• Don't snap to global grid while placing grid
  OliBomby · 2024-09-23 17:24:09 +02:00
  0f0f490598
• Refactor PlacementBlueprint to not be hitobject specific
  OliBomby · 2024-09-23 16:33:36 +02:00
  1a81e12192
• Remove select action to end placement
  OliBomby · 2024-08-16 11:55:07 +02:00
  e5fab9cfbe
• Allow placement deletion with middle mouse

  This is in addition to Shift + Right-click.
  
  I thik middle mouse feels more natural and is a good permanent solution
  to this issue.
  
  Note that this also *allows triggering the context menu from placement
  mode*. Until now it's done nothing. This may be annoying to users with
  muscle memory but I want to make the change and harvest feedback. I
  think showing the context menu is more correct behaviour (although
  arguably it should return to placement mode on dismiss?).

  Dean Herbert · 2024-08-05 14:25:09 +09:00
  0557b9ab79
• Adjust code style
  Bartłomiej Dach · 2024-07-04 15:19:36 +02:00
  652d2e9633
• Merge branch 'inherit-addition' into nodesample-inherit
  Bartłomiej Dach · 2024-07-04 15:13:20 +02:00
  8b4155fc0a
• Merge branch 'inherit-volume' into inherit-addition
  Bartłomiej Dach · 2024-07-04 14:52:05 +02:00
  faedf268ec
• Reduce duplication in new logic
  Bartłomiej Dach · 2024-07-04 14:45:46 +02:00
  72492a79cd
• Always inherit the volume from the previous hit object
  OliBomby · 2024-07-04 01:09:06 +02:00
  e754668daa
• inherit addition bank from last hitobject
  OliBomby · 2024-07-04 00:56:53 +02:00
  8f3a30b0b9
• update nodesamples on placement
  OliBomby · 2024-07-04 00:39:12 +02:00
  8dd04b6e9a
• Fix slider blueprint placement when ending placement outside the playfield

  As mentioned in https://github.com/ppy/osu/discussions/24161

  Dean Herbert · 2023-07-11 17:29:53 +09:00
  a0e6748882
• Change PlacementBlueprint.AutomaticBankAssignment to property

  Mostly for consistency.

  Bartłomiej Dach · 2023-05-25 21:32:21 +02:00
  adee624a8f
• Add "auto" bank selection during placement
  Dean Herbert · 2023-05-24 17:11:12 +09:00
  3a05dffa50
• Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes

  Fix timeline blueprint display not showing correct combo number / colour during placement

  Bartłomiej Dach · 2023-05-20 15:02:55 +02:00
  afdddb0195
• Remove a couple of unnecessary volume declarations
  Dean Herbert · 2023-05-18 14:12:57 +09:00
  ee522253cb
• Make EditorClock non-nullable in PlacementBlueprint
  Dean Herbert · 2023-05-17 21:40:52 +09:00
  b58ab28765
• Update combo information on placement blueprint
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  0b25818bd2
• Improve previous hitobject lookup efficient and correctness
  Dean Herbert · 2023-05-17 17:19:29 +09:00
  e43f2c2c43
• Apply NRT to PlacementBlueprint
  Dean Herbert · 2023-05-17 17:19:29 +09:00
  7d7d402d4e
• Make HitSampleInfo.Bank non-nullable
  Dean Herbert · 2023-05-16 18:12:56 +09:00
  83dcd78826
• Allow commiting / undoing placement of blueprints using back / select bindings
  Dean Herbert · 2023-05-12 16:06:20 +09:00
  0c1959ef2f
• Move blueprint validity conditions to allow more correct external usage of EndPlacement

  Until now, these were haphazardly enforce inline in blueprint
  implementations. The only thing stopping complete breakage is that
  `EndPlacement` wasn't called (too much) from outside the blueprint,
  leaving them responsible for their own placement.
  
  By moving this conditional out of the provided paramters to
  `EndPlacement`, it allows more flexible usage of that method externally.
  Coming in a future PR.

  Dean Herbert · 2023-05-12 16:02:22 +09:00
  f443cfb93e
• Make sure the first object you place has bank and volume
  OliBomby · 2023-05-01 00:49:01 +02:00
  2a94757154
• fix null sample
  OliBomby · 2023-04-30 01:08:52 +02:00
  83111223e0
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• Use equals instead and update other usage
  Joseph Madamba · 2023-02-04 19:58:48 -08:00
  191259c050
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Fix new hitobject placements not taking on the existing sample settings

  Similar to velocity / difficulty points, a user expectation is that
  volume and sample settings will be transferred to newly placed objects
  from the most recent one.
  
  Closes https://github.com/ppy/osu/issues/18742.

  Dean Herbert · 2022-06-18 13:49:59 +09:00
  bd5037fcad
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Fix PlacementBlueprint using the wrong beatmap when applying defaults

  Closes #12855.

  Dean Herbert · 2021-05-19 18:34:07 +09:00
  6c4709e7b4
• Allow certain mouse input to pass through PlacementBlueprints to the selection logic
  Dean Herbert · 2021-04-22 15:44:12 +09:00
  9a7bf8109f
• Fix placement blueprints not being correctly removed after a rolled back placement
  Dean Herbert · 2021-04-16 14:11:33 +09:00
  119c9b4294
• Move default sample addition to inside PlacementBlueprint

  This isn't actually required to fix the behaviour but it does feel like
  a better place to put this logic.

  Dean Herbert · 2021-02-11 17:16:18 +09:00
  e9730d4782
• Fix outdated xmldoc
  Dean Herbert · 2020-11-30 18:35:30 +09:00
  3ad2eeaff5
• Rename application method to better describe what it actually does
  Dean Herbert · 2020-11-26 19:16:18 +09:00
  9811c46e35
• Add new combo toggle to main composer interface
  Dean Herbert · 2020-09-25 14:10:30 +09:00
  e009264f10
• Add swell and drumroll blueprints
  Dean Herbert · 2020-05-29 16:45:47 +09:00
  b2fad91589
• Merge pull request #9033 from smoogipoo/applydefaults-cancellation

  Add cancellation token support to CreateNestedHitObjects()

  Dean Herbert · 2020-05-26 12:04:06 +09:00
  0cc6d6d97c
• Remove extra default application
  smoogipoo · 2020-05-25 16:15:55 +09:00
  cd65fc860b
• Remove double resolution of EditorClock
  Dean Herbert · 2020-05-25 15:40:45 +09:00
  b44beb4137
• Merge branch 'master' into editor-clock-cache
  Dean Herbert · 2020-05-25 15:39:42 +09:00
  ed83ef202a
• Merge branch 'master' into editor-clock-cache
  Dean Herbert · 2020-05-23 00:44:04 +09:00
  a3a9810344