48 Commits

• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Fix progressively worsening performance on taiko argon skin
  Dan Balasescu · 2025-04-10 15:53:14 +09:00
  92c0b3cae2
• Fix transforms from swell progress being cleared on completion by not using transforms
  Bartłomiej Dach · 2025-02-12 13:25:42 +01:00
  0ac08158e3
• fix code style
  Nathan Du · 2025-01-31 20:48:29 +08:00
  a62a84a30f
• remove ISkinnableSwell

  This commit removes ISkinnableSwell for taiko swell animations. In place
  of it, an event named UpdateHitProgress is added to DrawableSwell, and
  the skin swells are converted to listen to said event and
  ApplyCustomUpdateState, like how spinner skinning is implemented for
  std.

  Nathan Du · 2025-01-31 18:10:50 +08:00
  2a5540b392
• Merge taiko swell components

  Per <https://github.com/ppy/osu/pull/21601/files#r1064167756>, taking a
  variation of the "Make all swell main pieces implement
  ISkinnableSwellPart" path. Should clean the interface up enough for
  further refactors.

  Nathan Du · 2025-01-31 16:55:39 +08:00
  4fd8a4dc5a
• Rename methods and skin component + add comments
  Joppe27 · 2025-01-31 10:24:45 +08:00
  e2196e8b9b
• Add legacy taiko swell
  Joppe27 · 2025-01-31 10:24:45 +08:00
  4a164b7b14
• Define constant input drum width for osu!taiko
  Salman Ahmed · 2024-01-20 01:46:15 +03:00
  d4fef99e1f
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Apply required nullability changes
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  3585c3f1d5
• Rename variables to give more context
  Dean Herbert · 2023-06-12 14:18:26 +09:00
  b986d1cee1
• lower kiai pulse brightness
  Xinnoh · 2023-06-09 22:51:45 -07:00
  0c42aa7f3b
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix argon swells incorrectly flashing on every hit
  Dean Herbert · 2022-11-15 18:28:13 +09:00
  233d45e185
• Merge branch 'master' into argon-taiko
  Bartłomiej Dach · 2022-11-12 01:56:30 +09:00
  7379f6fe20
• Merge pull request #21151 from peppy/taiko-judgement-fixes

  Fix various issues surrounding hit judgements

  Dan Balasescu · 2022-11-11 16:41:46 +09:00
  fe58329478
• Merge pull request #21148 from peppy/taiko-barline-separation

  Move major barline portion to default implementation to allow for further customisation

  Dan Balasescu · 2022-11-11 16:40:51 +09:00
  8063dcd74a
• Merge branch 'master' into taiko-judgement-fixes
  Dan Balasescu · 2022-11-11 15:48:33 +09:00
  5bdbf56f43
• Merge branch 'master' into taiko-barline-separation
  Dan Balasescu · 2022-11-11 15:47:06 +09:00
  1a1a186d22
• Merge branch 'master' into taiko-tick-trackiung
  Dan Balasescu · 2022-11-11 15:41:06 +09:00
  f25a8ee4a6
• Fix NRT causing CI failure
  Susko3 · 2022-11-10 14:31:24 +01:00
  6303b88e56
• Merge pull request #21171 from peppy/unpollute-taiko-drawable-hit

  Remove triangles skin specific implementation from base osu!taiko `DrawableHit`

  Dan Balasescu · 2022-11-10 12:47:36 +09:00
  20520e7290
• Apply nullability to osu!taiko skinning classes
  Dean Herbert · 2022-11-09 13:37:06 +09:00
  20b8ab324f
• Remove triangles skin specific implementation from base DrawableHit
  Dean Herbert · 2022-11-08 15:22:00 +09:00
  aa7d0e2c96
• Move strong hit scale to DefaultHitExplosion
  Dean Herbert · 2022-11-07 18:32:12 +09:00
  37cb187d2e
• Merge branch 'taiko-barline-separation' into taiko-fixes-combined
  Dean Herbert · 2022-11-07 18:32:09 +09:00
  2648175275
• Merge branch 'taiko-tick-trackiung' into taiko-fixes-combined
  Dean Herbert · 2022-11-07 18:32:07 +09:00
  688f50e086
• Fix much brokenness with kiai and justment sizing
  Dean Herbert · 2022-11-07 17:19:32 +09:00
  564d078517
• Split out taiko DefaultJudgementPiece and move animations across
  Dean Herbert · 2022-11-07 17:19:32 +09:00
  8745c2f016
• Move first tick tracking logic inside TickPiece
  Dean Herbert · 2022-11-07 15:26:34 +09:00
  1975385cc7
• Move major barline portion to default implementation to allow for further customisation

  Of note, this removes the "major" barline triangles from legacy skins. I
  think this is more correct, as they did not display in stable.

  Dean Herbert · 2022-11-07 14:29:58 +09:00
  c69a4f9333
• Fix one more case
  Dean Herbert · 2022-11-02 17:39:45 +09:00
  bfa5d41d89
• Apply NRT to many taiko classes
  Dean Herbert · 2022-11-02 17:15:25 +09:00
  bc3382f373
• Move more default classes to correct namespace
  Dean Herbert · 2022-11-02 17:15:25 +09:00
  910dd3ad01
• Simplify Circle usage in default CentreHitCirclePiece
  Dean Herbert · 2022-11-02 17:15:25 +09:00
  2407eb063d
• Move DefaultInputDrum to correct location
  Dean Herbert · 2022-11-02 17:15:25 +09:00
  9c758e5425
• Adjust kiai flash period in line with stable
  Dean Herbert · 2022-10-21 15:34:25 +09:00
  d441e98af7
• Apply review: changed DelayUntilTransformsFinished to ArmedState check
  Joppe27 · 2022-10-19 23:31:23 +02:00
  d83c398b58
• Adjust flash intensity and fade values to feel better
  Joppe27 · 2022-10-19 00:51:44 +02:00
  9b123e7365
• Implement kiai flashing for "triangles" taiko skin
  Joppe27 · 2022-10-18 23:55:40 +02:00
  003e4247f9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use TaikoHitObject.DEFAULT_SIZE for default circle piece symbol size
  Salman Ahmed · 2022-04-03 00:21:23 +03:00
  4ce69890d4
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Share colour constants with default drawable piece implementations
  Dean Herbert · 2021-06-11 14:20:08 +09:00
  9c34cb0777
• Adjust namespace
  ekrctb · 2020-12-07 12:30:25 +09:00
  c70b13ecc2
• Move piece files of Taiko ruleset
  ekrctb · 2020-12-07 12:29:14 +09:00
  f78bd7c739