134 Commits

• Fix argon & triangles skins reading legacy slider colour overrides from beatmap skins

  Closes https://github.com/ppy/osu/issues/33383.

  Bartłomiej Dach · 2025-06-03 12:46:09 +02:00
  bea3653c52
• Fix "spins per minute" shows up early #31173

  Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.
  
  Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

  Rudi Herouard · 2025-04-13 23:35:44 +02:00
  7cdbc2c20a
• Remove use of Loop (and transforms) for slider repeat arrow animations

  Less transforms in gameplay is always better.
  
  This fixes repeat arrows animating completely incorrectly in the editor
  (and probably gameplay when rewinding).

  Dean Herbert · 2025-01-02 18:36:58 +09:00
  794765ba85
• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Move to ctor
  Dan Balasescu · 2024-05-23 23:45:04 +09:00
  b1c7afd75b
• Changed Size to be handled by AutoSizeAxes
  Aurelian · 2024-05-23 14:36:49 +02:00
  f17f70dca7
• SliderBody's Size getter updates size to the body/path's Size
  Aurelian · 2024-05-22 18:42:23 +02:00
  c3a2a1361d
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Merge pull request #27383 from Detze/slider-border-thickness

  Rewrite legacy slider path rendering to match stable better

  Bartłomiej Dach · 2024-02-28 10:02:46 +01:00
  71b1fbb9d0
• Remove SliderBorderSize for simplicity
  Salman Ahmed · 2024-02-27 02:20:34 +03:00
  18e26e39fe
• Merge pull request #27364 from EVAST9919/spinner-alloc

  Reduce osu spinner allocations

  Dean Herbert · 2024-02-25 09:36:02 +08:00
  e8d2abc4f7
• Reset lastRecord on resetState for good measure
  Dean Herbert · 2024-02-25 08:18:19 +08:00
  e12f8c03ee
• Store last enqueued RotationRecord in SpinnerSpmCalculator
  Andrei Zavatski · 2024-02-24 20:36:06 +03:00
  9e90f7fb0d
• Simplify implementation
  Dean Herbert · 2024-02-25 00:12:20 +08:00
  824d671cce
• Completely remove transform flow for spm counter
  Andrei Zavatski · 2024-02-24 17:09:49 +03:00
  2696620d12
• Remove repeated TimeStarted check
  Andrei Zavatski · 2024-02-24 16:42:44 +03:00
  4bba0eaf4b
• Fix incorrect operator
  Andrei Zavatski · 2024-02-24 16:41:53 +03:00
  9b526912e9
• Fix Argon and Trianles spinner stutter
  Andrei Zavatski · 2024-02-24 14:22:34 +03:00
  e7d8ca3292
• Improve comment regarding scale adjust of approach circles
  Dean Herbert · 2024-02-21 13:44:04 +08:00
  a11a83ac48
• Adjust slider tick / end misses to show slightly longer
  Dean Herbert · 2024-01-31 17:41:26 +09:00
  ebf637bd3c
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Implement per-axis triangles clamping
  Andrei Zavatski · 2024-01-23 04:54:27 +03:00
  da992ccc55
• Merge pull request #26598 from frenzibyte/fix-storyboard-sprites-2

  Remove handling for non-legacy texture lookup paths in `LegacySkin`

  Dean Herbert · 2024-01-22 17:50:55 +09:00
  993e733fce
• Rename Masking to ClampToDrawable
  Andrei Zavatski · 2024-01-21 05:20:42 +03:00
  1393f52b2b
• Change default masking value to true
  Andrei Zavatski · 2024-01-21 04:57:48 +03:00
  e003ecb593
• Refactor DefaultApproachCircle/LegacyApproachCircle to make sense
  Salman Ahmed · 2024-01-18 11:16:26 +03:00
  1527ab89ef
• Fix so it reacts to PathVersion with Scheduler
  OliBomby · 2024-01-13 12:50:39 +01:00
  fca9b1f536
• make drawables that update from path version update once per frame
  OliBomby · 2024-01-13 02:21:32 +01:00
  5fa7f6ec53
• Adjust slider follow circle animation to not abruptly scale on early ticks
  Dean Herbert · 2023-11-17 19:09:24 +09:00
  66f7b9fae1
• Fix incorrect assertion placement in spinner rotation tracker

  Checking the delta after the application of rate is not correct. The
  delta is in screen-space *before* the rate from rate-changing mods were
  applied; the point of the application of the rate is to compensate for
  the fact that the spinner is still judged in "track time" - but the goal
  is to keep the spinner's difficulty *independent* of rate, which means
  that with DT active the user's spin is "twice as effective" to
  compensate for the fact that the spinner is twice as short in real time.
  
  In another formulation, with DT active, the user gets to record replay
  frames "half as often" as in normal gameplay.

  Bartłomiej Dach · 2023-10-30 21:28:29 +01:00
  e5b51f769c
• Merge pull request #25157 from peppy/spinner-anti-cheese-final

  Fix spinner cheese by accounting for spin directionality

  Bartłomiej Dach · 2023-10-24 08:13:32 +02:00
  0e5a521695
• Update visuals of spinner implementations to show MAX score differently
  Dean Herbert · 2023-10-20 16:11:09 +09:00
  ca3a3f600e
• Update bindable flow to expose every spin, even after max bonus is reached
  Dean Herbert · 2023-10-20 15:38:04 +09:00
  f16400929d
• Merge pull request #25160 from bdach/repeat-arrow-hidden-fade

  Adjust slider repeat transforms to closer match stable

  Dean Herbert · 2023-10-18 18:03:48 +09:00
  54da6f1048
• Fix legacy slider repeats becoming much too large on hit

  They had scale transforms applied to them in two places: the actual
  legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
  `DrawableSliderRepeat` level.
  
  This change moves all of the scale transforms to the skinnable pieces.
  Argon and triangles have received a copy of the previous logic each,
  so behaviour on those skins should not change.

  Bartłomiej Dach · 2023-10-17 14:47:44 +02:00
  f3cda58474
• Add SpinnerSpinHistory and tests
  Dean Herbert · 2023-10-17 20:10:22 +09:00
  af7180a5b5
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Fix incorrect initial rotation transfer value

  Should have been removed as part of https://github.com/ppy/osu/pull/24360.

  Dean Herbert · 2023-10-16 19:34:55 +09:00
  0bb95cfa88
• Tidy up lastAngle usage and add assertion of maximum delta
  Dean Herbert · 2023-10-16 19:34:22 +09:00
  10bab61441
• Rename RateAdjustedRotation to TotalRotation
  Dean Herbert · 2023-10-16 18:25:03 +09:00
  159b24acf7
• Fix large instantaneous delta on first frame

  Happens when the first update frame comes in before any mouse input.

  Dan Balasescu · 2023-10-16 18:17:11 +09:00
  84be714d6b
• Add null checks in disposal flow
  Dean Herbert · 2023-10-02 22:28:33 +09:00
  3aa51301e8
• Update other implementations to use non-beat-sync logic
  Dean Herbert · 2023-10-02 19:20:11 +09:00
  e4ac8362ec
• Adjust reverse arrows to bounce more
  Dean Herbert · 2023-10-02 18:43:50 +09:00
  ad4e988520
• Split out reverse arrow implementations to allow better animation
  Dean Herbert · 2023-10-02 18:43:50 +09:00
  7dd9951c44
• Merge branch 'master' into limit-gameplay-sprite-dimensions
  Dean Herbert · 2023-09-26 16:40:32 +09:00
  990c54519b
• Simplify some maximum size specs
  Dean Herbert · 2023-09-20 12:48:15 +09:00
  8e16b1d507
• Remove slider head circle movement (and remove setting from "classic" mod)
  Dean Herbert · 2023-09-14 17:49:41 +09:00
  e3e7a81ad9
• Change spinner rotation animation to match input 1:1
  Dean Herbert · 2023-07-25 19:21:20 +09:00
  2e9379474d
• Fix SPM calculation division by zero
  ekrctb · 2023-01-20 21:00:01 +09:00
  7e466e1eba