646 Commits

• Dedupe switch returns
  clayton · 2025-08-16 04:55:49 -07:00
  6a16200314
• Map sliderpoint textures directly to HitResult types
  clayton · 2025-08-16 04:54:34 -07:00
  4d1ecab4e3
• Rename class to be more consistent with other skins' judgement pieces
  clayton · 2025-08-16 04:09:40 -07:00
  f2839c7b65
• Fix tick hits in non-legacy skins
  clayton · 2025-08-10 07:15:20 -07:00
  5fc5d0bd5f
• Add sliderpoint10 and sliderpoint30 support
  clayton · 2025-08-10 07:12:59 -07:00
  9542e77d16
• Fix argon & triangles skins reading legacy slider colour overrides from beatmap skins

  Closes https://github.com/ppy/osu/issues/33383.

  Bartłomiej Dach · 2025-06-03 12:46:09 +02:00
  bea3653c52
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Add minimal slider body transparency to "Argon" skins

  Addresses concerns in https://github.com/ppy/osu/discussions/24226.
  
  I basically adjusted opacity down until it started to visually detract
  from the skin. The pro level is lower than I'd want to see, but feels
  like a midpoint that some users may find usable.
  
  This is a band-aid fix until we can get proper support for settings like
  this into the skin editor.

  Dean Herbert · 2025-05-07 13:23:18 +09:00
  981383b52b
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Fix "spins per minute" shows up early #31173

  Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.
  
  Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

  Rudi Herouard · 2025-04-13 23:35:44 +02:00
  7cdbc2c20a
• Fix argon reverse arrow animating weirdly after hit
  Dean Herbert · 2025-04-03 17:41:13 +09:00
  bb8a9c8345
• Fix weird follow circle display when rewinding through sliders in editor

  Closes https://github.com/ppy/osu/issues/31812.

  Dean Herbert · 2025-02-12 16:33:23 +09:00
  84b5ea3dbf
• Avoid binding directly to DHO's bindable
  Dean Herbert · 2025-02-12 16:28:14 +09:00
  f97708e6b3
• Rename ParentObject to DrawableObject

  It's not a parent. The follow circle is directly part of the slider
  itself.

  Dean Herbert · 2025-02-12 16:14:12 +09:00
  ffd8bd7bf4
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Merge branch 'spectator-list-visuals' into spectator-list-ready
  Bartłomiej Dach · 2025-01-16 15:13:04 +01:00
  0c54853710
• Minor refactorings and xmldoc additions
  Dan Balasescu · 2025-01-16 14:00:27 +09:00
  920648c267
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Sync cursor trail rotation with the cursor
  Andrei Zavatski · 2025-01-14 23:12:23 +03:00
  7a6355d7cf
• Add ability for cursor trail to spin
  Andrei Zavatski · 2025-01-14 22:16:32 +03:00
  208824e9f4
• Fix multiple animation inconsistencies pointed out in review
  Dean Herbert · 2025-01-07 16:54:11 +09:00
  8d913e8971
• Remove use of Loop (and transforms) for slider repeat arrow animations

  Less transforms in gameplay is always better.
  
  This fixes repeat arrows animating completely incorrectly in the editor
  (and probably gameplay when rewinding).

  Dean Herbert · 2025-01-02 18:36:58 +09:00
  794765ba85
• Fix legacy hitcircle fallback logic being broken with recent fix

  I was a bit too eager to replace all calls with the new `provider`
  in
  https://github.com/ppy/osu/commit/dae380b7fa927c351e2e413c5b23834f717908d9,
  while it doesn't actually make sense.
  
  To handle the case that was trying to be fixed, using the `provider` to
  check whether the *prefix* version of the circle sprite is available is
  enough alone.
  
  Closes https://github.com/ppy/osu/issues/31200

  Dean Herbert · 2024-12-24 16:05:44 +09:00
  b8d6bba039
• Fix lookups of hit circle slider pieces potentially using wrong source skin

  Addresses https://github.com/ppy/osu/discussions/30927.

  Dean Herbert · 2024-12-10 22:03:07 +09:00
  dae380b7fa
• Fix classic skin spinner's middle pieces displaying in the wrong order

  Closes https://github.com/ppy/osu/issues/30873.
  See [stable
  reference](https://github.com/peppy/osu-stable-reference/blob/3ea48705eb67172c430371dcfc8a16a002ed0d3d/osu!/GameplayElements/HitObjects/Osu/SpinnerOsu.cs#L148-L158).

  Dean Herbert · 2024-11-26 18:12:28 +09:00
  312336de24
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Remove requirement of base calls to ensure user skin container layouts are retrieved
  Dean Herbert · 2024-08-22 19:14:30 +09:00
  1435fe24ae
• Rename Target lookup to Component
  Dean Herbert · 2024-08-22 19:00:28 +09:00
  b57b8168a6
• Move GlobalSkinnableContainers to global scope
  Dean Herbert · 2024-08-22 18:46:07 +09:00
  9a21174582
• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
  Dean Herbert · 2024-08-22 18:39:36 +09:00
  f37cab0c6e
• Fix legacy key counter position not matching stable
  Salman Ahmed · 2024-08-21 00:10:16 +09:00
  20658ef4ee
• Merge pull request #26254 from frenzibyte/mania-combo-counter

  Add argon/classic osu!mania combo counter

  Dean Herbert · 2024-08-15 17:56:28 +09:00
  5710f0f302
• Fix beatmap skin always overriding ruleset HUD components
  Salman Ahmed · 2024-08-15 16:47:10 +09:00
  49c71f7863
• Standardise skin transformer code structure
  Dean Herbert · 2024-08-12 14:27:21 +09:00
  d2eb6ccb8c
• Update in line with new changes
  Dean Herbert · 2024-08-09 14:55:01 +09:00
  80c814008f
• Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer

  This didn't make any sense, so let's do it a better way.

  Dean Herbert · 2024-08-08 16:29:54 +09:00
  60d383448f
• Merge branch 'master' into ruleset-specific-combo-counter
  Dean Herbert · 2024-08-08 03:21:52 +09:00
  3c572abaa7
• Use transformers for per-skin key counter implementation
  Dean Herbert · 2024-08-06 18:17:21 +09:00
  725dc4de9b
• Merge branch 'master' into ruleset-specific-combo-counter
  Bartłomiej Dach · 2024-06-04 15:44:11 +02:00
  5fcea01c13
• Move to ctor
  Dan Balasescu · 2024-05-23 23:45:04 +09:00
  b1c7afd75b
• Changed Size to be handled by AutoSizeAxes
  Aurelian · 2024-05-23 14:36:49 +02:00
  f17f70dca7
• SliderBody's Size getter updates size to the body/path's Size
  Aurelian · 2024-05-22 18:42:23 +02:00
  c3a2a1361d
• Comment in some clarification
  Dean Herbert · 2024-04-22 15:07:11 +08:00
  fb1d20bd39
• Fix cursormiddle not using the same source as cursor
  Dan Balasescu · 2024-04-22 15:01:28 +09:00
  0170c04baf
• Add failing test
  Dan Balasescu · 2024-04-22 15:01:28 +09:00
  40c48f903b
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Update usage of CircularProgress.Current
  Dean Herbert · 2024-03-06 12:13:10 +08:00
  6455c0583b
• Merge pull request #27383 from Detze/slider-border-thickness

  Rewrite legacy slider path rendering to match stable better

  Bartłomiej Dach · 2024-02-28 10:02:46 +01:00
  71b1fbb9d0
• Disable legacy slider AA for now
  Salman Ahmed · 2024-02-27 23:18:29 +03:00
  b3aa9e25d2