297 Commits

• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Fix drawable hold notes continuing to show hit lighting with No Release mod and classic skin

  Closes https://github.com/ppy/osu/issues/33751.

  Bartłomiej Dach · 2025-06-18 17:59:54 +02:00
  176a85763c
• Fix incorrect translation of note freezing logic
  Bartłomiej Dach · 2025-05-20 08:58:11 +02:00
  bd703b60f9
• Fix hold notes being missed after rewinding gameplay

  Closes https://github.com/ppy/osu/issues/27589.
  
  Follows osu! spinner precedent in storing the holding state to the
  judgement result rather than attempting to keep it in the DHO (which is
  prone to getting dropped on pool re-use).

  Bartłomiej Dach · 2025-05-19 12:23:47 +02:00
  59490054db
• Add support for legacy osu!mania barline height and colour spec
  Dean Herbert · 2025-02-28 15:13:13 +09:00
  cb29459a1e
• Add basic setup for mania legacy barline implementation
  Dean Herbert · 2025-02-28 14:43:00 +09:00
  3e8dafa3c5
• Fix hold note light lingering with No Release

  Turns out endHold() is not called in the Tail.IsHit branch of the
  hold notes' CheckForResult method.

  Nathan Du · 2024-07-18 16:08:30 +08:00
  00ed7a7a2f
• Apply further changes to remove remaining weirdness
  Bartłomiej Dach · 2024-02-05 13:37:38 +01:00
  fb80d76b4a
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Change mania scoring to match ScoreV2
  Dan Balasescu · 2023-12-20 18:35:45 +09:00
  104fbbde94
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Rename PerfectBonusNote to NotePerfectBonus
  Dean Herbert · 2023-10-16 15:14:28 +09:00
  4f1546c474
• Add DisplayResult flag and remove unnecessary AlwaysPresent
  Dean Herbert · 2023-10-16 14:57:58 +09:00
  43f619f92a
• Fix MissForcefully not considering the bonus object
  Dean Herbert · 2023-10-16 14:53:36 +09:00
  14fedffcc1
• Adjust method flow to hopefully be more legible
  Dean Herbert · 2023-10-16 13:31:14 +09:00
  e85c039722
• Remove nullability of bonusNote
  Dean Herbert · 2023-10-16 13:14:58 +09:00
  ddbda69751
• Fix hodl tail notes not correctly handling nested bonus judgement
  Dean Herbert · 2023-10-13 17:36:19 +09:00
  125f28219d
• Add nested bonus judgement to DrawableNote for perfect bonus score
  Dean Herbert · 2023-10-13 17:01:48 +09:00
  94b64044e0
• Apply some xmldoc and structural changes
  Dean Herbert · 2023-10-10 16:59:25 +09:00
  8dc9453d8d
• Add mania hold note body + combo break judgement
  Dan Balasescu · 2023-10-09 09:47:00 +09:00
  9415fe4446
• Remove mania hold note ticks
  Dan Balasescu · 2023-08-31 17:30:27 +09:00
  c60f13dd92
• Add barline pooling for mania
  Dan Balasescu · 2023-08-15 13:33:49 +09:00
  6a7b0786c9
• Use IsRewinding in a few more places
  Bartłomiej Dach · 2023-07-08 13:32:24 +02:00
  9dae806734
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix fix logic causing further regression on release
  Dean Herbert · 2023-06-17 01:37:09 +09:00
  3b1f92d8b8
• Fix osu!mania hold notes sometimes looking incorrect after rewind
  Dean Herbert · 2023-06-16 14:54:19 +09:00
  b5de109cb3
• Fix osu!mania hold notes snapping to judgement area too early on early hits

  Closes https://github.com/ppy/osu/issues/23515.

  Dean Herbert · 2023-06-01 16:06:35 +09:00
  98f35f7481
• Remove no-longer-correct remark
  Bartłomiej Dach · 2023-05-08 22:35:41 +02:00
  1ff1730948
• Merge branch 'master' into fix-mania-head-note-animation
  Bartłomiej Dach · 2023-05-08 22:23:01 +02:00
  3f45948664
• Remove clamping of sizingContainer in DrawableHoldNote to fix head note alignment
  Dean Herbert · 2023-05-08 18:14:07 +09:00
  27c10cbdb7
• Add back early return in OnReleased for safety
  Dean Herbert · 2023-05-08 15:43:11 +09:00
  814f0b3fed
• Move logic to Update instead
  Dean Herbert · 2023-05-03 15:18:37 +09:00
  6a59ded1ba
• Merge branch 'master' into mania-fix-hold-note-rewind
  Dean Herbert · 2023-05-03 15:04:59 +09:00
  4013cdcfa8
• remove all non-test usage of SampleControlPoint
  OliBomby · 2023-04-26 13:55:39 +02:00
  d97daee96b
• Fix osu!mania hold note animations not correctly re-applying after rewind

  There's early exit logic in `OnPressed`/`OnReleased` for the sake of
  keeping order correct, but this doesn't account for the fact that
  `DrawableHitObject` resets all animations when the hit state changes.
  
  A bit of an ugly workaround, but seems to work as expected.

  Dean Herbert · 2023-03-14 18:15:19 +09:00
  5aebbac6c5
• Add hitting layer to fix hit lighting not being applied to tail piece

  Taken from https://github.com/ppy/osu/pull/22820#issuecomment-1462626898.

  Dean Herbert · 2023-03-14 17:29:19 +09:00
  300d81c46b
• Add note about why bodyPiece sizing is done as it is

  I think we're going to have to change this as it's quite limiting in
  what you can do with osu!mania skin implementation, but for now I want
  to leave a note as to why this is done, because each time I have to
  trial and error check what breaks when adjusting it.

  Dean Herbert · 2023-03-09 20:26:49 +09:00
  ed3ff62e4f
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  To correctly end a mania hold note, `endHold()` needs to be called. This
  was not happening in a very specific scenario:
  
  - The hold note's head is not hit
  - The user pressed the column's key within the hold note's tail's window,
    but does so to hit the next object (a note in proximity to the hold note's tail).
  - The hit policy forces a miss on the hold note, but `endHold()` is not called
  - `CheckForResult` is not called after this point due to `Judged` being `true`.
  
  Closes #21311.

  Dean Herbert · 2022-11-22 16:15:34 +09:00
  57723107dd
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Fix hold note disappear instantly
  ekrctb · 2022-10-25 19:16:23 +09:00
  92ab39f5c2
• Implement hold "sliding" samples in osu!mania
  Dean Herbert · 2022-10-11 16:31:37 +09:00
  f060e6a780
• Remove manual binding of nested objects in DrawableManiaHitObject

  This is now handled by `Column` itself. Leaving the logic here as well
  will cause a circular bindable flow and stack overflow.

  Dean Herbert · 2022-10-07 18:25:55 +09:00
  52ad766f86
• Fix mania hold note head disappears
  ekrctb · 2022-10-06 19:46:10 +09:00
  ea4dbc8c0f