Dean Herbert
1017a124ab
Merge pull request #28743 from smallketchup82/velopack
...
Migrate update framework to Velopack
2024-09-04 16:09:36 +09:00
Dean Herbert
dfe11dc68a
Use for with exposed IReadOnlyList rather than making internal container public
2024-09-04 15:25:36 +09:00
Dean Herbert
97a51af5a0
Fix one more unnecessary enumerator allocation
2024-09-04 15:22:31 +09:00
Dean Herbert
421f245c31
Fix per-frame allocations in BeatmapCarousel
2024-09-04 14:31:59 +09:00
Dean Herbert
6c89c4eed6
Fix rewind causing weirdness with progress bar animation
2024-09-03 18:50:57 +09:00
Sheppsu
a549cdd5b9
persist analysis settings
2024-09-03 04:49:50 -04:00
Sheppsu
a2b15fcdee
rework code logic to make more sense
...
analysis container creates settings and the settings items are created more nicely
also removed use of localized strings because that can be done separately
2024-09-03 00:59:42 -04:00
Fabep
582ffcfc97
Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;
2024-09-02 19:17:07 +02:00
Fabep
e3457d8501
Mod customisation header's color is now based on the state of the panel rather than the hover of the container.
2024-09-02 19:14:08 +02:00
Bartłomiej Dach
d99b2312cd
Merge branch 'master' into Fabep/master
2024-09-02 14:35:44 +02:00
Dean Herbert
7b13943377
Handle changes to the automatic download setting immediately
2024-09-02 19:20:05 +09:00
Dean Herbert
872d14ed88
Fix incorrect handling of ordered playlist items
2024-09-02 19:18:43 +09:00
Dan Balasescu
5d09aaae27
Merge pull request #29446 from OliBomby/last-anchor
...
Fix path control points losing curve type on save/reload or undo
2024-09-02 18:40:19 +09:00
Bartłomiej Dach
5211e606b5
Fix mod customisation header being non-functional on mobile
...
As expected the previous touch handling would prevent the header from
working entirely when click handling was removed from the header.
2024-09-02 11:33:43 +02:00
Dean Herbert
6227e4f848
Apply NRT to MultiplayerSpectateButton
2024-09-02 16:37:38 +09:00
Dean Herbert
38a62eed44
Add automatic downloading support when spectating a multiplayer room
2024-09-02 16:37:38 +09:00
Sheppsu
1ed94e598a
Merge branch 'master' into replay-analysis-settings
2024-09-01 19:32:25 -04:00
Dean Herbert
e79604cc13
Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session
...
Show daily challenge intro screen once per session
2024-09-01 21:27:16 +09:00
Dean Herbert
f7da7193ff
Update framework
2024-09-01 19:10:08 +09:00
Andrei Zavatski
837fa1b8dc
Use FastCircle for kiai visualisation
2024-08-31 17:32:24 +03:00
Andrei Zavatski
501ea68a21
Merge branch 'master' into fast-circle
2024-08-31 17:31:30 +03:00
Dan Balasescu
d5b52152f4
Merge branch 'master' into velopack
2024-08-31 15:44:21 +09:00
Dean Herbert
6b8b49e4f1
Simplify scroll speed point display code now that it only serves one purpose
2024-08-31 13:14:56 +09:00
Andrei Zavatski
225418dbb3
Rework kiai handling in summary timeline
2024-08-31 01:59:40 +03:00
Andrei Zavatski
f5a2b5ea03
Use FastCircle in demanding places in the editor
2024-08-30 17:45:26 +03:00
Dean Herbert
a09c6e2a25
Merge pull request #29656 from peppy/provide-api-earlier
...
Provide API context earlier to api requests in order to fix missing schedules
2024-08-30 23:15:28 +09:00
Bartłomiej Dach
4811481483
Merge pull request #29639 from peppy/detached-beatmap-cache
...
Improve song select load and reload with large beatmap databases
2024-08-30 15:00:20 +02:00
Bartłomiej Dach
8ffd4aa82c
Fix NRT inspections
2024-08-30 13:41:34 +02:00
Dean Herbert
7b6e62283f
Fix beatmap not being detached on hide/unhide
...
The explicit detach call was removed from `updateBeatmapSet`, causing
this to occur. We could optionally add it back (it will be a noop in all
cases though).
2024-08-30 18:50:08 +09:00
Dean Herbert
de208fd5c3
Add very basic error handling for failed beatmap detach
2024-08-30 18:50:03 +09:00
Dean Herbert
2033a5e157
Add disposal of ManualResetEventSlim
2024-08-30 18:50:02 +09:00
Dean Herbert
1b9942cb30
Mark BeatmapSets as internal
2024-08-30 18:44:04 +09:00
Dean Herbert
291dd5b101
Remove TODO
2024-08-30 18:37:27 +09:00
Dean Herbert
2d745fb67e
Apply NRT to APIRequest
2024-08-30 18:35:31 +09:00
Dean Herbert
dd7133657d
Fix weird test critical failure if exception happens too early in execution
...
Noticed in passing.
```
Exit code is 134 (Unhandled exception. System.NullReferenceException:
Object reference not set to an instance of an object.
at osu.Game.OsuGameBase.onExceptionThrown(Exception ex) in
/Users/dean/Projects/osu/osu.Game/OsuGameBase.cs:line 695
at osu.Framework.Platform.GameHost.abortExecutionFromException(Object
sender, Exception exception, Boolean isTerminating)
at osu.Framework.Platform.GameHost.unobservedExceptionHandler(Object
sender, UnobservedTaskExceptionEventArgs args)
at System.Threading.Tasks.TaskExceptionHolder.Finalize())
```
2024-08-30 18:35:31 +09:00
Dean Herbert
07611bd8f5
Use IAPIProvider interface and correctly support scheduling from DummyAPIAccess
2024-08-30 18:35:31 +09:00
Dean Herbert
5836f497ac
Provide API context earlier to api requests in order to fix missing schedules
...
Closes https://github.com/ppy/osu/issues/29546 .
2024-08-30 18:10:36 +09:00
Fabian Bech Persson
363fc0d5da
Merge branch 'master' into master
2024-08-30 11:06:54 +02:00
Dan Balasescu
ae0931cfc3
Merge pull request #29653 from peppy/fix-multiplayer-event-leak
...
Fix event leak in `Multiplayer` implementation
2024-08-30 16:58:27 +09:00
Dean Herbert
a71bc3a24a
Merge pull request #28737 from OliBomby/doubleclick
...
Add more ways to seek to sample points
2024-08-30 16:22:50 +09:00
Dean Herbert
3bc42db3a6
Fix event leak in Multiplayer implementation
...
Very likely closes #29088 . It's the only thing I could find odd in the
memory dump.
2024-08-30 16:14:19 +09:00
Dean Herbert
60c1e0fa72
Merge pull request #29440 from OliBomby/spacebar-resume
...
Allow play/pause with spacebar while placing hitobjects
2024-08-30 12:58:41 +09:00
OliBomby
ba0c4df2a9
Merge remote-tracking branch 'upstream/master' into doubleclick
2024-08-29 19:34:18 +02:00
OliBomby
8fe7ab131c
dont seek on right-click, only on keyboard request
2024-08-29 19:34:14 +02:00
Dan Balasescu
4e8fb0dcab
Merge branch 'master' into scroll-speed-std
2024-08-30 00:41:05 +09:00
Dean Herbert
dd675fef45
Merge pull request #29644 from smoogipoo/unplayed-filter-query-2
...
Adjust `played` song select filter to accept a boolean value
2024-08-29 23:52:37 +09:00
Dean Herbert
c013974790
Merge branch 'master' into detached-beatmap-cache
2024-08-29 22:49:11 +09:00
Dan Balasescu
fec8fa46fa
Merge pull request #29533 from bdach/fix-sample-bank-stuff-again
...
Fix incorrect bank set / sample addition logic
2024-08-29 21:36:26 +09:00
Dan Balasescu
fde790c014
Rework played filter to a boolean value
2024-08-29 20:59:48 +09:00
Dean Herbert
d1d2591b67
Fix realm changes being applied before detach finishes
2024-08-29 18:42:43 +09:00
Dean Herbert
def1abaeca
Fix some tests not always waiting long enough for beatmap loading
...
These used to work because there was a huge blocking load operation,
which is now more asynchronous.
Note that the change made in `SongSelect` is not required, but defensive
(feels it should have been doing this the whole time).
2024-08-29 18:42:43 +09:00
Joseph Madamba
ef443b0b5d
Hide pinned comment replies initially to match web
2024-08-28 23:05:15 -07:00
Dean Herbert
1776d38809
Remove loadedTestBeatmaps flag
2024-08-28 23:28:44 +09:00
Dean Herbert
e04b5bb3f2
Tidy up test beatmap loading
2024-08-28 23:28:44 +09:00
Dean Herbert
9123d2cb7f
Fix multiple test failures
2024-08-28 23:28:43 +09:00
Bartłomiej Dach
d49cd717d6
Merge pull request #29576 from peppy/allow-seek-in-more-places
...
Allow seeking via music controller overlay on more screens
2024-08-28 12:23:09 +02:00
Dean Herbert
dd4a1104e4
Always debounce external Filter requests (except for tests)
...
The only exception to the rule here was "when screen isn't active apply
without debounce" but I'm not sure we want this. It would cause a
stutter on returning to song select and I'm not even sure this is a
common scenario.
I'd rather remove it and see if someone finds an actual case where this
is an issue.
2024-08-28 19:13:50 +09:00
Dean Herbert
336abadbd1
Allow running initial filter criteria asynchronously
...
This reverts a portion of https://github.com/ppy/osu/pull/9539 .
The rearrangement in `SongSelect` is required to get the initial filter
into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
causing a delayed/scheduled filter application).
2024-08-28 19:13:50 +09:00
Dean Herbert
5ed0c6e91a
Remove song select preloading
...
Really unnecessary now.
2024-08-28 19:13:49 +09:00
Dean Herbert
c2c1dccf2d
Detach beatmap sets asynchronously
2024-08-28 19:13:49 +09:00
Dean Herbert
b1f653899c
Fix enumeration over modified collection
2024-08-28 19:13:49 +09:00
Dean Herbert
81b36d897d
Fix null reference in change handling code
2024-08-28 19:13:49 +09:00
Dean Herbert
081c9eb21b
Fix incorrect cancellation / disposal handling of DetachedBeatmapStore
2024-08-28 17:21:19 +09:00
Fabep
6adaf6a41f
Changed ModCustomisationPanelState names
2024-08-28 10:09:47 +02:00
OliBomby
cadbb0f27a
change sample seek keybind to ctrl shift
2024-08-28 09:57:13 +02:00
Fabep
be0e2efda2
Removed on click event for expanding the Mod Customisation Header.
2024-08-28 09:51:17 +02:00
Dean Herbert
4d42274771
Use bindable list implementation
2024-08-28 16:03:37 +09:00
Dean Herbert
466ed5de78
Add basic detached beatmap store
2024-08-28 16:03:37 +09:00
Dean Herbert
eb70a1b72d
Change middle text to only animate initially
2024-08-28 15:57:42 +09:00
Dean Herbert
47a52d10eb
Revert "Add slight parallax to centre content"
...
This reverts commit 90d06d4496
2024-08-28 15:32:59 +09:00
OliBomby
b5b4f915a9
Automatic seek to sample point on right-click
2024-08-27 19:40:33 +02:00
OliBomby
1117fd56a1
change default seek hotkeys
2024-08-27 19:40:18 +02:00
OliBomby
daad476593
Add float comparison leniency just in case
2024-08-27 19:04:16 +02:00
OliBomby
71044a0766
fix difference in sample time calculation
2024-08-27 19:02:40 +02:00
Bartłomiej Dach
a3b0ff4808
Merge branch 'master' into break-overlay-animation
2024-08-27 11:17:56 +02:00
Bartłomiej Dach
321e509f11
Merge pull request #29615 from peppy/break-overlay-improvements
...
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 11:16:08 +02:00
Dean Herbert
90d06d4496
Add slight parallax to centre content
2024-08-27 16:37:27 +09:00
Bartłomiej Dach
8d7053d367
Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display
...
Fix mod icons potentially showing incorrectly at daily challenge intro
2024-08-27 09:37:11 +02:00
Dean Herbert
6f1664f0a6
Add beat-synced animation to break overlay
...
I've been meaning to make the progress bar synchronise with the beat
rather than a continuous countdown, just to give the overlay a bit more
of a rhythmic feel.
Not completely happy with how this feels but I think it's a start?
I had to refactor how the break overlay works in the process. It no
longer creates transforms for all breaks ahead-of-time, which could be
argued as a better way of doing things. It's more dynamically able to
handle breaks now (maybe useful for the future, who knows).
2024-08-27 16:34:37 +09:00
Dean Herbert
98faa07590
Apply NRT to BreakOverlay
2024-08-27 15:01:51 +09:00
Dean Herbert
797b020747
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 15:01:50 +09:00
Dean Herbert
abdbe510b8
Move break overlay (and cursor) further forward in depth
...
I didn't really want to move the cursor in front of the HUD, but we face
a bit of an impossible scenario otherwise (it should definitely be in
front of the break overlay for visibility).
So I'll deal with it for now.
2024-08-27 14:52:11 +09:00
Dean Herbert
84bceca778
Assume we can always fetch the ruleset
2024-08-26 15:38:58 +09:00
clayton
70d08b9e97
Increase mod icon acronym font weight
2024-08-25 20:42:57 -07:00
clayton
2bb72762ad
Use more contrasting color for mod icon foreground
2024-08-25 20:42:34 -07:00
Salman Ahmed
b54487031a
Add DailyChallengeButton for intro played flag reset logic
2024-08-24 22:19:17 +09:00
Jonas Brandstötter
89a4025c01
Fix Daily Challenge play count using a different colour than osu-web
2024-08-24 11:21:28 +02:00
Dean Herbert
885d832e98
Fix deserialise failing with some old skins
2024-08-23 20:44:45 +09:00
Dean Herbert
1e39af8ac5
Add a bit of logging around medal awarding
...
Might help with https://github.com/ppy/osu/issues/29119 .
2024-08-23 19:49:24 +09:00
Dean Herbert
2a479a84dc
Remove conditional inhibiting seek when beatmap change is not allowed
...
In testing I can't find a reason for this to exist. Blaming back shows
that it existed before we had `AllowTrackControl` and was likely being
used as a stop-gap measure to achieve the same thing. It's existed since
over 6 years ago.
Let's give removing it a try to fix some usability concerns?
Closes https://github.com/ppy/osu/issues/29563 .
2024-08-23 18:21:31 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
...
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Dean Herbert
48cfd77ee8
Component -> Lookup
2024-08-23 14:48:50 +09:00
OliBomby
2de5ecceb8
Merge remote-tracking branch 'upstream/master' into scroll-speed-std
2024-08-22 20:17:14 +02:00
OliBomby
ad8e7f1897
Fix scroll speed visualisation missing on start kiai effect points
...
They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.
2024-08-22 20:17:09 +02:00
OliBomby
998b5fdc12
Add property EditorShowScrollSpeed to Ruleset
2024-08-22 19:53:34 +02:00
OliBomby
adbdb39e9f
move public member to top of file
2024-08-22 19:18:38 +02:00
OliBomby
0db068e423
allow repeating on seek actions
2024-08-22 19:15:53 +02:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
...
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
46d55d5e61
Remove remaining early base lookup calls which were missed
2024-08-22 20:13:28 +09:00
Bartłomiej Dach
b3e961f6c5
Merge pull request #29562 from peppy/remove-migration-leftover-message
...
Remove "leftover files" notification when migration partly fails
2024-08-22 12:32:44 +02:00
