Salman Ahmed
0c5a1410d3
Add fade transition to content during open/close
2024-07-08 07:54:37 +03:00
Salman Ahmed
585e09981f
Allow scrollbar to overlap content
...
The content is already padded enough to have the scrollbar sit on top.
Having the content change padding when the scrollbar appears gives an
unpleasent experience (especially when the scrollbar is hidden at first
but the user increases the content's height by clicking on a dropdown or
something)
2024-07-04 07:36:31 +03:00
Salman Ahmed
33711ba616
Remove scroll-dropdown-into-view logic
2024-07-04 07:34:19 +03:00
Salman Ahmed
8658389854
Clarify how the panel blocks input
2024-07-04 07:34:19 +03:00
Bartłomiej Dach
6fda0db9ba
Fix test
2024-07-03 11:03:52 +02:00
Salman Ahmed
f1012070c4
Merge branch 'master' into mod-select-customisation-panel
2024-07-03 07:36:52 +03:00
Salman Ahmed
92404dfbb0
Merge pull request #28712 from peppy/update-framework-has-flag
...
Update framework
2024-07-03 07:26:54 +03:00
Salman Ahmed
cb350470e5
Merge branch 'master' into update-framework-has-flag
2024-07-03 07:06:13 +03:00
Dean Herbert
4ac9d57705
Merge pull request #28711 from bdach/ternary-state-node-samples
...
Include node samples when changing additions and banks
2024-07-03 10:21:17 +09:00
Dean Herbert
5350945340
Update HasFlag usages
2024-07-03 00:19:04 +09:00
Dean Herbert
9034f6186b
Update framework
2024-07-03 00:15:34 +09:00
Bartłomiej Dach
a7b066f3ee
Include node samples when changing additions and banks
2024-07-02 16:22:15 +02:00
Bartłomiej Dach
6453522b34
Add failing test coverage for changing banks/samples not working on node samples
2024-07-02 16:21:56 +02:00
Salman Ahmed
1d94c96a8e
Display customisation header in disabled state when no customisable mod selected
2024-07-02 14:40:16 +03:00
Bartłomiej Dach
3bf3e9133b
Merge pull request #28689 from smoogipoo/fix-break-conversion
...
Fix `ManiaModInvert` permanently destroying the beatmap
2024-07-02 07:53:16 +02:00
Dan Balasescu
00462f6d56
Merge pull request #28660 from mcendu/no-release-mod
...
Add "No Release" mod
2024-07-02 12:46:27 +09:00
Dan Balasescu
31edca866c
Remove unused code
2024-07-02 12:21:24 +09:00
Dan Balasescu
04da1209f7
Revert "Change breaks list to IReadOnlyList"
...
This reverts commit 2c3b411bb5
2024-07-02 12:16:11 +09:00
Dan Balasescu
db84711214
Revert "Move break cloning back to non-virtual method"
...
This reverts commit f69bc40a4b
2024-07-02 12:16:10 +09:00
Dean Herbert
f69bc40a4b
Move break cloning back to non-virtual method
2024-07-02 12:07:13 +09:00
Dean Herbert
2c3b411bb5
Change breaks list to IReadOnlyList
2024-07-02 11:59:24 +09:00
Dean Herbert
f694ae416e
Fix typo in xmldoc
2024-07-02 11:47:40 +09:00
Dean Herbert
005af280f2
Isolate bindable breaks list to EditorBeatmap
2024-07-02 11:31:55 +09:00
Nathan Du
1eb10e029c
Rewrite no release mod
...
Per the request of spaceman_atlas, the No Release mod is rewritten to
avoid modifications to DrawableHoldNoteTail. The approach is based
on that of the Strict Tracking mod for the osu!(standard) ruleset,
injecting the mod behavior by replacing the normal hold note with
the mod's variant. The variant inherits most bevaior from the normal
hold note, but when creating nested hitobjects, it creates its own
hold note tail variant instead, which in turn is used to instantiate
the mod's variant of DrawableHoldNoteTail with a new behavior.
The time a judgement is awarded is changed from the end of its
Perfect window to the time of the tail itself.
2024-07-01 20:29:30 +08:00
Dan Balasescu
f942595829
Fix ManiaModInvert permanently messing up the beatmap
2024-07-01 15:02:00 +09:00
Dan Balasescu
4cb58fbe47
Add failing test
2024-07-01 15:02:00 +09:00
Dean Herbert
56f4f40334
Merge pull request #28657 from peppy/playfield-skin-components-respect-border
...
Change "playfield" skin layer to respect shifting playfield border in osu! ruleset
2024-07-01 10:35:15 +09:00
Dan Balasescu
2f9bce5274
Merge pull request #28686 from peppy/fix-summary-timeline-break-display
...
Fix summary timeline not correctly updating after changes to breaks
2024-07-01 10:03:16 +09:00
Dean Herbert
8bb51d5a4f
Fix summary timeline not correctly updating after changes to breaks
...
Closes https://github.com/ppy/osu/issues/28678 .
Oops.
2024-06-30 20:32:16 +09:00
Salman Ahmed
901663b3ff
Fix test failure
2024-06-30 11:00:00 +03:00
Nathan Du
463ab46fee
formatting
2024-06-29 16:46:16 +08:00
Nathan Du
679f4735b3
add tests for No Release mod
...
The new test scene is essentially a copy of TestSceneHoldNoteInput,
modified to test the judgement changes applied by the new mod. A base
class might need to be abstracted out for them.
2024-06-29 16:20:07 +08:00
Nathan Du
960d552dc1
Initial implemention of the No Release mod
...
This commit adds a new osu!mania mod No Release that relaxes tail
judgements. The current implementation automatically awards Perfect
(or Meh if the hold note is broken midway) for a hold note tail at
the end of its Perfect window, as long as it is held by then.
Tests are pending for the next commit.
2024-06-28 22:21:08 +08:00
Bartłomiej Dach
18f4fac4c1
Merge pull request #25725 from smoogipoo/fix-juicestream-velocity
...
Fix JuiceStream velocity calculation
2024-06-28 13:42:44 +02:00
Bartłomiej Dach
81c6da98c2
Merge pull request #26465 from LeNitrous/fix/editor-test-exit
...
Fix editor test play not marking hit objects before its start time as judged.
2024-06-28 12:12:17 +02:00
Bartłomiej Dach
deeb2e99a2
Add test for correct juice stream tick counts in editor
...
cda9440a29
2024-06-28 11:58:07 +02:00
Bartłomiej Dach
c70a72ece8
Merge branch 'master' into fix-juicestream-velocity
2024-06-28 11:47:39 +02:00
Dean Herbert
55b80f70f6
Change "playfield" skin layer to respect shifting playfield border in osu! ruleset
2024-06-28 18:12:20 +09:00
Dean Herbert
4bb8a45d75
Merge pull request #28636 from bdach/daily-challenge/watch-room
...
Add client/server models for allowing clients to receive realtime playlist updates
2024-06-28 17:51:40 +09:00
Salman Ahmed
f462aa59df
Add test coverage for the issues that were pointed out recently
2024-06-28 11:23:52 +03:00
Bartłomiej Dach
007bd3973a
Merge pull request #28653 from peppy/featured-artist-even-more-visible
...
Update beatmap listing filter overlay to better imply selected filters
2024-06-28 09:50:21 +02:00
Bartłomiej Dach
a3ea36d2b2
Fix formatting
2024-06-28 09:45:45 +02:00
Bartłomiej Dach
7ac5bd4d37
Ensure past drawable objects also get their results populated in editor test play
2024-06-28 09:37:10 +02:00
Bartłomiej Dach
ace6427d40
Expand test coverage
...
- Covers fail case that wasn't covered before
- Removes arbitrary wait step that was inevitably going to cause
intermittent test failures
2024-06-28 09:30:28 +02:00
Bartłomiej Dach
b36e0f0875
Merge branch 'master' into fix/editor-test-exit
2024-06-28 09:17:40 +02:00
Bartłomiej Dach
030bbf2641
Fix vertical overlaps on multiselection filters when they wrap
2024-06-28 09:07:29 +02:00
Dean Herbert
04c09b5027
Merge pull request #28652 from smoogipoo/fix-dangerous-button-lowpass
...
Fix low pass filter sometimes not applied in dialog overlays
2024-06-28 16:05:35 +09:00
Dean Herbert
fa1527f446
Update design for selected filters to better imply that they are selected
2024-06-28 15:45:09 +09:00
Dan Balasescu
77b00dac7e
Fix low pass filter sometimes not applied in dialog overlays
2024-06-28 15:20:55 +09:00
Dean Herbert
c1bec7a7c3
Simplify colour logic for beatmap overlay filter rows
2024-06-28 14:55:55 +09:00
