54 Commits

• Fix skin editor sometimes dropping anchor/origin specification on paste (#35957)

  * Add failing test for copy->paste not being idempotent
  
  * Ensure all elements on default skins use fixed anchors
  
  `UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with
  manual anchor / origin specs on some drawables, this would get default
  skins into impossible states wherein a drawable would use "closest
  anchor" but also explicitly specify anchor / origin that aren't closest,
  which horribly fails on attempting to copy and paste.
  
  Frankly shocked this has gone unnoticed for this long, and I regret not
  vetoing this "feature" more every time I see its tentacles spread to
  produce breakage of levels yet unseen.
  
  Does this commit contain major levels of suck? For sure. Do I have any
  better ideas that wouldn't consist of a multi-day rewrite or deletion of
  this "feature"? No.
  
  * Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor
  
  Self-explanatory. Should close https://github.com/ppy/osu/issues/29111
  along with previous commit.

  Bartłomiej Dach · 2025-12-11 13:40:48 +09:00
  c4f7dee82b
• Add failing test case

  Co-authored-by: Rodrigo Correia <rodrigo.figueiredo.correia@tecnico.ulisboa.pt>

  Bartłomiej Dach · 2025-03-31 14:25:35 +02:00
  79375eccb7
• Revert default combo counter code to pre-abstractification (and nuke eldritch abstract entity)
  Bartłomiej Dach · 2024-09-11 11:44:59 +02:00
  0e663d1801
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Rename Target lookup to Component
  Dean Herbert · 2024-08-22 19:00:28 +09:00
  b57b8168a6
• Move GlobalSkinnableContainers to global scope
  Dean Herbert · 2024-08-22 18:46:07 +09:00
  9a21174582
• Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
  Dean Herbert · 2024-08-22 18:39:36 +09:00
  f37cab0c6e
• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1
• Update in line with new changes
  Dean Herbert · 2024-08-09 14:55:01 +09:00
  80c814008f
• Store layout version in SkinLayoutVersion instead and refactor migration code
  Salman Ahmed · 2024-07-01 08:30:37 +03:00
  0c34e7bebb
• Add test coverage
  Salman Ahmed · 2024-06-25 05:55:05 +03:00
  dc1fb4fdca
• Add test coverage of skin editor copy-paste
  Bartłomiej Dach · 2023-11-23 09:55:16 +09:00
  4edaaa3083
• Merge branch 'skin-size-editing' into gameplay-hud-redesign/counters
  Bartłomiej Dach · 2023-11-11 21:28:29 +09:00
  ea556abad8
• Use barely better assertion fail message in test
  Bartłomiej Dach · 2023-11-11 20:56:05 +09:00
  ee56b4d205
• Revert test changes

  They were broken because `SerialisedDrawableInfo` is a reference type
  and as such equality checks will use reference equality rather than
  member equality.

  Bartłomiej Dach · 2023-11-11 19:32:46 +09:00
  b247b94ecb
• Remove unused using directive
  Bartłomiej Dach · 2023-11-11 15:52:24 +09:00
  21e1d68b15
• Improve test comparison logic

  Doesn't really help that much with nunit output,
  but at least you can breakpoint and see the json kinda.

  Dean Herbert · 2023-11-10 20:00:51 +09:00
  2e48569982
• Adjust failing test scenes
  Salman Ahmed · 2023-11-05 02:50:14 +03:00
  634795e45f
• Update skin editor cyclic test to match expectations better
  Dean Herbert · 2023-07-19 16:56:16 +09:00
  9d46d00294
• Revert SaveState() calling on initialization
  Terochi · 2023-05-01 12:53:58 +02:00
  4d52ce769b
• Addressed changes
  Terochi · 2023-04-30 16:11:52 +02:00
  8f02bd80f9
• Improved logic
  Terochi · 2023-04-30 12:05:55 +02:00
  949dc1c0f9
• Refactor tests
  Terochi · 2023-04-30 02:32:20 +02:00
  585318400c
• Added tests
  Terochi · 2023-04-30 02:00:35 +02:00
  9a9e02b110
• Add test coverage of cyclic selection triggering when more than one item is selected
  Dean Herbert · 2023-03-21 21:31:10 +09:00
  fb51221c2b
• Add test coverage and fix fail case where a drag selection ends incorrectly with cyclic selection
  Dean Herbert · 2023-03-15 15:16:48 +09:00
  1cf870d956
• Add tests covering drag selection
  Dean Herbert · 2023-03-14 21:04:51 +09:00
  3c4e2d8700
• Add test coverage of cyclic selection in skin editor
  Dean Herbert · 2023-03-07 15:11:47 +09:00
  d2fcdf6e0e
• Add test coverage of bring-to-front / send-to-back operations
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  32a9c066df
• Fix weird nullability in TestSceneSkinEditor
  Dean Herbert · 2023-02-22 18:17:20 +09:00
  90ca635a17
• Add clipboard dependency to SkinEditor specific tests

  This is usually provided by the `SkinEditorOverlay`, which is not always
  present in tests.

  Dean Herbert · 2023-02-16 15:24:38 +09:00
  2fbaf88a3c
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• Move skin editor to overlays namespace
  Dean Herbert · 2023-02-02 14:00:31 +09:00
  8dc2e6872e
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix inspection
  Dan Balasescu · 2022-09-09 08:55:35 +09:00
  28477f3b97
• Add test for object move
  cdwcgt · 2022-09-08 23:47:55 +08:00
  2e775e6886
• Fix intermittent HUD tests
  Dan Balasescu · 2022-07-28 17:58:07 +09:00
  1039338d80
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix test failures in skin editor test scene
  Bartłomiej Dach · 2022-03-26 19:28:07 +01:00
  69cc863611
• Add test coverage of skin editor settings slider not working via keyboard adjustments
  Dean Herbert · 2022-03-21 17:33:56 +09:00
  3643f879e4
• Add missing OverlayColourProvider to SkinEditor test
  Dean Herbert · 2022-03-16 22:23:19 +09:00
  3f61b0d968
• Add basic scene selector
  Dean Herbert · 2022-03-16 19:12:06 +09:00
  d062810ff2
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Enable autoplay in skin editor tests
  Dean Herbert · 2021-05-13 14:55:11 +09:00
  e0e9106921
• Remove unnecessary test step creating needless skins
  Dean Herbert · 2021-05-11 18:39:15 +09:00
  61ea3f2e64
• Update Legacy components to not require skin in ctor
  Dean Herbert · 2021-05-11 18:39:14 +09:00
  004798d61d
• Merge branch 'master' into skin-components-list
  Dean Herbert · 2021-05-06 14:17:33 +09:00
  aff32b0d19
• Add component list to main editor interface and enable basic placement
  Dean Herbert · 2021-04-30 13:10:42 +09:00
  ae9d1dc40b
• Allow skin editor to be invoked from any context

  This is kind of how I see things working going forward, where the editor
  can be applied to anything in the game which supports it (ie. a results
  screen, gameplay screen, etc.) and it will immediately allow changing
  the interface.
  
  This adds a test scene which shows this working with gameplay.

  Dean Herbert · 2021-04-29 16:12:15 +09:00
  de73ac7cec