12907 Commits

• Merge pull request #23309 from peppy/key-counters-fix

  Fix key counters counting during break time

  Bartłomiej Dach · 2023-04-25 21:15:12 +02:00
  5ec8ecb11b
• Merge pull request #23247 from peppy/round-editor-rotation

  Always round editor rotation to integer values

  Dean Herbert · 2023-04-25 21:43:44 +09:00
  14af2063e5
• Add missing binding of IsCounting with contained counters
  Dean Herbert · 2023-04-25 21:37:19 +09:00
  6b4032e34b
• Restructure key counters to use a common flow
  Dean Herbert · 2023-04-25 21:37:19 +09:00
  0a861ffcee
• Stop using Drawable.Name to convey actual UI information
  Dean Herbert · 2023-04-25 20:24:36 +09:00
  7630958633
• Remove pointless default value
  Dean Herbert · 2023-04-25 20:22:12 +09:00
  dd2c289ce9
• Merge branch 'master' into gameplay/argon-key-counter_le-retour
  Dean Herbert · 2023-04-25 19:54:31 +09:00
  d8b4db3a13
• Always round editor rotation to integer values
  Dean Herbert · 2023-04-20 14:30:01 +09:00
  9f4b1f0f24
• Shorten label to just "matches"
  Joseph Madamba · 2023-04-17 20:59:41 -07:00
  c80a25328d
• Revert back to one number with "matching beatmap difficulties" label
  Joseph Madamba · 2023-04-10 23:37:29 -07:00
  d0cbe206a9
• Merge remote-tracking branch 'upstream/master' into fix-beatmap-terminology
  Joseph Madamba · 2023-04-10 23:22:15 -07:00
  f0c8a3202b
• Merge branch 'master' into fix-count-not-updating-when-deleting
  Dean Herbert · 2023-04-11 09:04:02 +09:00
  52bb7891f7
• Adjust BeatmapSetsChanged xmldoc

  Co-Authored-By: Dean Herbert <pe@ppy.sh>

  Joseph Madamba · 2023-04-10 11:28:23 -07:00
  f80de08f24
• Use existing BeatmapSetsChanged action
  Joseph Madamba · 2023-04-10 11:26:18 -07:00
  c7dea71793
• Fix incorrectly implemented localisation
  Bartłomiej Dach · 2023-04-10 15:03:33 +02:00
  73bd0feef5
• Simplify snap implementation
  Bartłomiej Dach · 2023-04-10 14:55:30 +02:00
  6fec476147
• Fix song select beatmap difficulty count not updating when deleting
  Joseph Madamba · 2023-04-09 22:12:51 -07:00
  7f5b99c91b
• Fix overbearing key down handling
  Dean Herbert · 2023-04-08 22:30:36 +09:00
  8d2e852ffd
• Remove redundant method override
  Dean Herbert · 2023-04-08 22:18:07 +09:00
  a1fc4def1d
• Fix tooltip text not resetting when ending an editor rotation
  Micha Lehmann · 2023-04-08 14:28:52 +02:00
  3c4a25e53f
• Add "(snapped)" to the tooltip when snap-rotating in the editor
  Micha Lehmann · 2023-04-08 14:15:49 +02:00
  580d5745c0
• Fix code quality issues and avoid updating bindable twice per operation
  Dean Herbert · 2023-04-08 10:40:36 +09:00
  f72dd86b42
• Improve editor selection rotation value wrapping

  This fixes two issues the previous algorithm had:
  1.  A half-turn rotation used to show up as -180°.
  2.  Rotating more than 180° in one drag event would overwhelm it
      and cause the value to go outside its range.
  
  This comes at the cost of a negligible performance hit,
  since a division (modulo) is performed instead of just addition/subtraction.

  Micha Lehmann · 2023-04-08 01:30:29 +02:00
  c827c2810b
• Snap editor selection rotation when holding shift
  Micha Lehmann · 2023-04-08 01:30:29 +02:00
  f1de560d57
• Merge branch 'master' into gameplay/argon-key-counter_le-retour
  Dean Herbert · 2023-04-06 23:39:57 +09:00
  0c71fa1bbd
• Merge pull request #22868 from peppy/no-epilepsy-warning-storyboard-disable

  Don't show epilepsy warning when storyboards are disabled

  Dean Herbert · 2023-04-06 12:32:38 +09:00
  e6872629f3
• Merge branch 'master' into gameplay/argon-key-counter_le-retour
  tsrk · 2023-04-05 22:57:36 +02:00
  809b817e8e
• Merge branch 'master' into update-skinnable-sound-before-playing
  Bartłomiej Dach · 2023-04-05 22:56:25 +02:00
  ba753a8aac
• Add tests for suppressing epilepsy warning when storyboard disabled
  Bartłomiej Dach · 2023-04-05 20:56:50 +02:00
  6df7614b9d
• Merge branch 'master' into gameplay/key-counter-abstraction
  Bartłomiej Dach · 2023-04-05 19:45:14 +02:00
  432f698697
• Merge branch 'master' into fix-replay-fail-on-exit
  Bartłomiej Dach · 2023-04-03 21:23:23 +02:00
  8cc425774b
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-04-03 15:33:35 +09:00
  b0c09df259
• Merge branch 'master' into fix-ruleset-shader-caching
  Dean Herbert · 2023-03-31 20:04:55 +09:00
  4b294278d6
• Rewrite comment explaining early return on checkScoreCompleted given new usages
  Dean Herbert · 2023-03-31 02:36:17 +09:00
  796cd9c916
• Rename scoreCompleted -> checkScoreCompleted to reflect the fact it doesn't always succeed
  Dean Herbert · 2023-03-31 02:30:04 +09:00
  b25a59fd14
• Add assert ensuring we don't ever get to the results screen with an F rank

  Intentionally an assertion as I want tests to fail, but I don't want
  this to cause crashes for an end user if it does happen to occur.

  Dean Herbert · 2023-03-29 14:11:58 +09:00
  4dd0c2c7a5
• Ensure all preconditions are checked before progressing to results screen after storyboard ends
  Dean Herbert · 2023-03-29 14:00:11 +09:00
  a8bb2e33ac
• Remove duplicate load rule from ShaderPrecompiler
  Dean Herbert · 2023-03-29 12:36:56 +09:00
  aad540629f
• Preload triangle shader on startup
  Dean Herbert · 2023-03-28 14:15:38 +09:00
  5dfac02b11
• Fix incorrect song select matching label by showing both beatmap and difficulty count for less ambiguity
  Joseph Madamba · 2023-03-26 18:08:28 -07:00
  8b30c67580
• Fix select beatmap button not highlighting when creating a multiplayer room using keyboard
  Joseph Madamba · 2023-03-26 16:03:21 -07:00
  3e0bbb2432
• Fix song select search textbox font size incorrectly having increased
  Dean Herbert · 2023-03-22 14:17:39 +09:00
  425be20e46
• Merge branch 'master' into skin-editor-cyclic-selection
  Bartłomiej Dach · 2023-03-21 19:49:55 +01:00
  9ff9cd3b7f
• Don't cycle selection when more than one items are selected
  Dean Herbert · 2023-03-21 21:31:10 +09:00
  e31a90e043
• Merge pull request #22773 from peppy/show-song-select-visible-beatmap-count

  Show count of visible beatmaps at song select

  Dean Herbert · 2023-03-21 18:22:29 +09:00
  5cb8160eee
• Fix importing beatmaps not changing count of visible beatmaps

  Reproduction steps:
  
  1. Go to song select
  2. Open beatmap listing
  3. Import a beatmap that would fit the current filter criteria
  4. The count of visible beatmaps does not change
  
  Fixed by updating the count on `BeatmapSetsChanged` too.

  Bartłomiej Dach · 2023-03-20 20:53:53 +01:00
  ea8da69263
• Privatise setter
  Bartłomiej Dach · 2023-03-20 20:30:54 +01:00
  695ee39b87
• Merge branch 'master' into BitmapUpdatesOnScore
  Cootz · 2023-03-16 12:16:42 +03:00
  556964eae0
• Ensure Player does not fail a score on exit if a replay is currently loaded
  Dean Herbert · 2023-03-16 17:14:20 +09:00
  3b62f87b64
• Move matches string inside text box
  Dean Herbert · 2023-03-16 16:34:31 +09:00
  cd102da3af