77 Commits

• Add helper method and update some other similar preempt calculations
  Dean Herbert · 2025-12-18 22:28:50 +09:00
  09178b5dc4
• Fix osu! stacking not matching stable in very specific edge case

  Closes https://github.com/ppy/osu/issues/36052.
  
  Not much more to say here. Until now the `PreEmpt` typing discrepancy
  has likely gone unnoticed since it's usually only used in visual usages.

  Dean Herbert · 2025-12-18 20:08:56 +09:00
  44f535dcef
• Show effect of beatmap attributes on gameplay metrics in osu!
  Bartłomiej Dach · 2025-08-01 11:07:48 +02:00
  655733c06d
• Merge conditionals
  Bartłomiej Dach · 2025-01-10 14:13:03 +01:00
  0d9a3428ae
• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Respect pre-empt time when auto-generating breaks

  Closes https://github.com/ppy/osu/issues/28703.

  Bartłomiej Dach · 2024-07-23 13:30:13 +02:00
  088e8ad0a2
• Reduce allocations during beatmap selection
  Andrei Zavatski · 2024-02-17 15:46:38 +03:00
  22f5a66c02
• Extract preempt durations to shared constants
  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  605269f65f
• Add note about shared code
  Dean Herbert · 2023-11-24 10:25:23 +09:00
  039f8e6242
• Fix combo/combo colouring issues around spinners
  Dan Balasescu · 2023-11-23 13:54:05 +09:00
  7998204cfe
• Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch

  As discussed, it isn't used in stable like this. Was a mistake.

  Dean Herbert · 2023-10-20 18:57:14 +09:00
  3fb74cb5f9
• Centralise and repair circle size calculations game-wide
  Dean Herbert · 2023-10-18 19:50:42 +09:00
  3a5490892c
• Fix circle scale not matching stable due to missing multiplier

  This multiplier has to exist.
  
  I'm not guaranteeing that the rest is correct here. Should we be doing
  proper cross-testing on this? Maybe, but it's going to be hard to get
  right. We could likely check as far as "game pixels", but there's still
  a chance that the osu-framework could be doing something weird in the
  rest of the hierarchy where playfield scale is involved.
  
  Closes https://github.com/ppy/osu/issues/25162. Tested to fix the linked
  replay.

  Dean Herbert · 2023-10-18 18:35:14 +09:00
  6ae82c5e73
• Simplify some maximum size specs
  Dean Herbert · 2023-09-20 12:48:15 +09:00
  8e16b1d507
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix OsuHitObject not using property wrapper properly
  Salman Ahmed · 2022-07-19 07:52:12 +03:00
  d8cce5fe36
• Fix osu! and catch hitobjects no longer scaled to 1 by default
  Salman Ahmed · 2022-07-19 07:00:13 +03:00
  8f80a22ef9
• Change bindable properties in all HitObjects to be lazily initialised
  Salman Ahmed · 2022-07-19 05:39:10 +03:00
  1051009827
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• updated bdach's suggestion
  Roxie Wattz · 2021-10-25 17:15:43 -07:00
  cf7fbf4b63
• Made StackedEndPosition virtual

  Done to allow overriding in the other object classes.

  Roxie is Flux3on · 2021-10-24 18:14:37 -07:00
  861cd4852a
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Rename property, reword xmldoc and improve readability of update code
  Dean Herbert · 2021-07-21 17:32:56 +09:00
  399c3b0be8
• Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
  Salman Ahmed · 2021-07-20 14:15:43 +03:00
  9d92b795fa
• Consider "combo offsets" as legacy logic and separate from combo information
  Salman Ahmed · 2021-05-05 07:43:08 +03:00
  cd6d070b4a
• Add explanatory comments + const
  smoogipoo · 2021-02-10 22:06:19 +09:00
  20a6405fd2
• Adjust osu! hitobject fade-ins to support AR>10
  smoogipoo · 2020-12-10 00:37:19 +09:00
  47a93d8614
• Use Bindable{Float,Double}s everywhere

  To avoid further floating-point comparison bugs, remove all usages of
  Bindable<{float,double}>, replacing them with their
  Bindable<Float,Double> counterparts.

  Bartłomiej Dach · 2020-02-01 22:50:29 +01:00
  434c0d92e4
• Fix sliders not moving with stacking change
  smoogipoo · 2019-10-21 16:24:06 +09:00
  5f8d46f666
• Move scoring distance constant to a central/shared location
  Dean Herbert · 2019-10-17 16:36:47 +09:00
  f3ed71d336
• Add bindables for IHasComboInformation properties
  smoogipoo · 2019-09-26 16:55:08 +09:00
  bbf0544a8d
• Refactor HitWindows for legibility
  Dean Herbert · 2019-09-06 15:24:14 +09:00
  f925e781a9
• Adjust slider snaking and hitcircle fading to match stable
  Dean Herbert · 2019-08-09 20:18:02 +09:00
  6264a6a1c9
• Centralise osu! circle radius specification
  Dean Herbert · 2019-07-22 14:40:02 +09:00
  e50b70d615
• Adjust namespaces
  smoogipoo · 2019-02-21 19:05:52 +09:00
  d8c55bc729
• Update with framework bindable changes
  smoogipoo · 2019-02-21 18:56:34 +09:00
  bca347427f
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• OpenTK -> osuTK
  smoogipoo · 2018-11-20 17:14:59 +09:00
  f27bd3ef3e
• Use bindables for hitobject events
  smoogipoo · 2018-11-09 13:58:46 +09:00
  cc8531790a
• Remove IHasEditablePosition
  smoogipoo · 2018-11-08 13:03:11 +09:00
  c6350c6efd
• Make circle piece respond to hitobject scale
  smoogipoo · 2018-10-26 15:26:19 +09:00
  22c545ea8c
• Make the hitobject masks move within their placement/selection
  smoogipoo · 2018-10-25 18:16:25 +09:00
  ea6db8b793
• Fix StackHeight changes not causing position updates
  smoogipoo · 2018-10-03 17:06:18 +09:00
  1cd11a6e5b
• Implement combo offsets
  smoogipoo · 2018-08-15 11:47:31 +09:00
  31f324945e
• Add common custom words to dotsettings dictionary

  Also fixes some typos and reduces spelling suggestions to hints.

  Dean Herbert · 2018-07-05 15:54:41 +09:00
  1d6609d9f3
• Fix combo index being wrong
  Dean Herbert · 2018-06-29 01:34:47 +09:00
  9d4bc7b630
• Move ruleset-specific hitwindows to post-converted hitobjects
  smoogipoo · 2018-05-17 13:35:15 +09:00
  f67d263596
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5