76563 Commits

This Branch

This Branch

All Branches

• Fix hidden settings flow content still being interactive

  `AlwaysPresent` is a code smell here. Rather than doing this, let's just
  using masking as we usually do.
  
  Closes https://github.com/ppy/osu/issues/36748.

  Dean Herbert · 2026-02-25 14:35:24 +09:00
  047ea7c09d
• Fix flow animating its display initially when it shouldn't
  Dean Herbert · 2026-02-25 14:34:50 +09:00
  cb597c4120
• Tidy up how SettingsSubsection headings are created

  Previously we were always making header content in the base class then
  overwriting it, which felt ick.

  Dean Herbert · 2026-02-25 14:34:49 +09:00
  99ab245cf0
• Rename one more missed song select v2 class
  Dean Herbert · 2026-02-25 02:18:18 +09:00
  ee8d99034c
• Merge pull request #36746 from bdach/fix-thing-again
  Dean Herbert · 2026-02-24 21:48:06 +09:00
  5b1d4ceb9d
• Attempt to fix "copy labels from issues" workflow permissions again

  It's still broken:
  
  https://github.com/ppy/osu/actions/runs/22310482792/job/64540909415
  
  and I'm not sure what else it could be other than this, so I'm giving it
  one more honest try before I throw up hands.
  
  For better or worse,
  https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#permissions
  explicitly lists that the `pull-requests` permission allows tagging PRs,
  so I'm holding out hope that this is it. Still terrible marks for
  documentation here, both to the github action, as well as everything to
  do with `GITHUB_TOKEN`.

  Bartłomiej Dach · 2026-02-24 13:34:06 +01:00
  ccb0224a1b
• Merge pull request #36745 from peppy/song-select-cleanup

  Various song select class cleanup

  Bartłomiej Dach · 2026-02-24 13:24:18 +01:00
  5602281bd9
• Remove V2 suffix from migrated classes
  Dean Herbert · 2026-02-24 20:23:29 +09:00
  fabce18552
• Combine old classes to provide better starting point for migration
  Dean Herbert · 2026-02-24 20:23:28 +09:00
  cb12d35d8f
• Remove no longer used class
  Dean Herbert · 2026-02-24 20:23:28 +09:00
  efc9a27d2d
• Merge pull request #36738 from peppy/user-button-animation-fix

  Fix transient user stats animation changing speed after first display

  Bartłomiej Dach · 2026-02-24 08:19:02 +01:00
  e2cbfb970e
• Move spacing local to usages
  Dean Herbert · 2026-02-23 15:59:09 +09:00
  f39615a374
• Move toolbar button text local to single usage in ToolbarUserButton
  Dean Herbert · 2026-02-23 15:58:57 +09:00
  4916c87f14
• Move transformation logic local to transient drawable
  Dean Herbert · 2026-02-23 15:47:01 +09:00
  a09489d4c0
• Update resources
  Dean Herbert · 2026-02-23 03:37:40 +09:00
  d139f5997c
• Fix spectator player cells not having initial shadow edge effect set (#36729)

  - Fixes https://github.com/ppy/osu/issues/36727
  
  Copies/sets the non-maximised edge effect initially:
  
  
  https://github.com/ppy/osu/blob/c144cf188a37ebc965b25818938527c02013efc4/osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/PlayerGrid.Cell.cs#L83-L88

  Joseph Madamba · 2026-02-21 23:19:32 +09:00
  29a39cbfb7
• Fix reversing straight perfect curve sliders positioning them weirdly (#36698)
  Arthur Araujo · 2026-02-20 16:57:42 +01:00
  c144cf188a
• Adjust nightcore sample playback to not stop randomly and be closer to stable (#36702)

  - Closes https://github.com/ppy/osu/issues/30293
  - Fixes https://osu.ppy.sh/community/forums/topics/2179339?n=1
  
  Aside from fixing the off-by-one error that I mentioned in
  https://github.com/ppy/osu/issues/30293#issuecomment-2413801663, this
  also:
  
  - Brings back the behaviour wherein if timing points are arranged very
  weird and nightcore would play e.g. two first beats in a timing point
  back-to-back, the second timing point is silent.
  - Brings back the behaviour wherein the finish sample only plays if
  `OmitFirstBarLine` on the timing point is disabled.
  
  However:
  
  - This does not bring back the behaviour wherein hat samples only play
  if the slider tick rate is even because that only kind of makes sense in
  common time, and if common time is mixed with waltz time or other time
  signatures, it just gets weird.
  - Also stable has zero attempt for compensating for waltz time anyway,
  lazer's behaviour is bespoke, so that is not going to match any way you
  cut it.
  
  My testing procedure essentially consisted of getting stable to log when
  it was playing nightcore samples and cross-checking the first 30sec or
  so of https://osu.ppy.sh/beatmapsets/534385#osu/1131956 (check out the
  timing of that beatmap, for something ranked it is DEEPLY messed up).
  
  I guess I can add test cases if deemed required but I already wasted
  much more time than I would have liked here...

  Bartłomiej Dach · 2026-02-20 12:53:12 +09:00
  1e8b9a7639
• Merge pull request #36696 from peppy/multiplayer-freestyle-select

  Migrate multiplayer freestyle select screen to use `SongSelectV2`

  Bartłomiej Dach · 2026-02-19 12:16:51 +01:00
  69c2747883
• Merge branch 'master' into multiplayer-freestyle-select
  Bartłomiej Dach · 2026-02-19 10:55:30 +01:00
  d3b48364c5
• Merge pull request #36694 from peppy/freestyle-select-update

  Migrate playlist freestyle select screen to use `SongSelectV2`

  Bartłomiej Dach · 2026-02-19 10:55:07 +01:00
  9ae99648fb
• Disable footer buttons on freestyle song select

  - The mods button should not be visible because it is not hooked up
    properly to actually work with selecting user mods. As written it
    would show (and feign the ability to modify) required mods on the
    playlist item.
  
    You could probably adjust the logic to make user mods controllable via
    this button but this is simpler for now.
  
  - The random and options buttons could perhaps remain, but they are of
    very limited use on this screen anyway.
  
  The previous iteration disabled all footer buttons altogether, so I'm
  just following precedent here mostly.

  Bartłomiej Dach · 2026-02-19 10:07:51 +01:00
  f9f927fa45
• Disallow use of scoping button when at freestyle song select
  Dean Herbert · 2026-02-19 01:47:03 +09:00
  1153d17153
• Privatise setter
  Bartłomiej Dach · 2026-02-18 14:42:04 +01:00
  e15cb08b44
• Merge pull request #36695 from peppy/loading-layer-block-non-positional

  Add ability for `LoadingLayer` to block all keyboard input

  Bartłomiej Dach · 2026-02-18 14:40:31 +01:00
  25d630898b
• Migrate multiplayer freestyle select screen to use SongSelectV2
  Dean Herbert · 2026-02-18 20:50:17 +09:00
  48544733c3
• Add ability for LoadingLayer to block all keyboard input
  Dean Herbert · 2026-02-18 20:50:14 +09:00
  d33a6d5512
• Fade out header line for now to avoid visual overlap
  Dean Herbert · 2026-02-18 20:48:17 +09:00
  110f11fa5e
• Add test coverage of actual user flows involving freestyle select screen

  Of note, this test scene still doesn't use the new footer properly.
  Should these even be here? Maybe it's better to leave these real world
  flows to a `Navigation` style test so we're not dealing with weird test
  setups that kinda do something but don't... or maybe do it in three
  different ways (two footers present, three back buttons etc.)
  
  Dunno. But this kind of covers what I want (except it doesn't cover the
  new footer usage).

  Dean Herbert · 2026-02-18 20:48:16 +09:00
  fb8c228d32
• Migrate playlist freestyle select screen to use SongSelectV2
  Dean Herbert · 2026-02-18 20:30:14 +09:00
  93d1a61dc2
• Add ability for LoadingLayer to block all keyboard input
  Dean Herbert · 2026-02-18 20:01:38 +09:00
  83587e2265
• Add "spin" keyword for menu cursor rotation
  Dean Herbert · 2026-02-18 17:21:03 +09:00
  f15e086bb0
• Merge pull request #36687 from peppy/legacy-key-counter-skinnable-font

  Fix legacy key counter not using skin's font

  Bartłomiej Dach · 2026-02-18 08:26:21 +01:00
  9fa78123a6
• Ensure state resets back to initial display on rewind
  Dean Herbert · 2026-02-18 02:25:09 +09:00
  7445efaecd
• Use default overlap of 1

  Matches closer to stable spec.

  Dean Herbert · 2026-02-18 02:22:00 +09:00
  86ab507e2e
• Update resources
  Dean Herbert · 2026-02-17 16:44:26 +09:00
  cc9a5ede29
• Show initial key placeholder / trigger name using non-skinned font

  In stable, there was support for mixed fonts (some coming from the
  user's skin, with fallback missing characters generated from TTF
  backend).
  
  We don't really have support for this so this is a simple in-between for
  the time being.

  Dean Herbert · 2026-02-17 16:02:13 +09:00
  6e03d5b00e
• Add basic support for scoreentry- skinnable text
  Dean Herbert · 2026-02-17 15:54:31 +09:00
  71583bc06f
• Prevent tagging beatmaps when played with conversion mods (#36684)

  Closes #36553.
  Supersedes #36614.
  
  As discussed in #36614, the only exception to this is `ModClassic`.

  Vanni · 2026-02-17 14:49:59 +09:00
  94cec71502
• Fix osu! editor composer scale handles not updating correctly when selected object is changed (#36681)

  Before:
  
  
  https://github.com/user-attachments/assets/d0a0373d-2d46-48a9-9ea5-bac82a612f32
  
  After:
  
  
  https://github.com/user-attachments/assets/f5785b54-d7fc-4ce0-86b0-60c96ff22bc3
  
  ---
  
  Closes https://github.com/ppy/osu/issues/36677.
  
  Kinda shocking this went by unnoticed for this long.

  Bartłomiej Dach · 2026-02-17 00:50:16 +09:00
  42bf25442b
• Use directory of last-selected sample as initial directory in sample set add controls (#36680)

  Closes https://github.com/ppy/osu/issues/36470.
  
  Applied directly to relevant control for now.

  Bartłomiej Dach · 2026-02-17 00:46:30 +09:00
  fc4e29793d
• Restore previous beatmap when leaving scoped mode (#36582)

  Resolves #36288.
  
  If the current selection is still available after leaving scoped mode,
  it's left as is. If it's not, the selection from before entering scoped
  mode is restored.
  
  
  https://github.com/user-attachments/assets/b1ac3de1-7c7f-4949-82a9-1dd0459f3f61
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Krzysztof Gutkowski · 2026-02-17 00:40:29 +09:00
  8e26cf4e1b
• Fix extra lives in Easy mod potentially getting reapplied during gameplay (#36678)

  Closes https://github.com/ppy/osu/issues/36676.

  Bartłomiej Dach · 2026-02-16 19:02:59 +09:00
  810edebe87
• Preserve bookmarks when creating a new difficulty from scratch (#36675)

  Closes #33395
  
  Copies the bookmarks from `referenceWorkingBeatmap` while creating a new
  difficulty from scratch. I adapted the tests in
  `TestSceneEditorBeatmapCreation` to include the bookmark checks.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Arthur Araujo · 2026-02-16 12:50:04 +09:00
  2f459dd94e
• Update resources
  Dean Herbert · 2026-02-15 23:25:46 +09:00
  87f323a2e5
• Add explanations for scoring mode used in ranked & total score tooltips (#36663)

  Because people get confused by how this works.
  
  Shows on results screen where the post-play statistics updates go.
  
  
  https://github.com/user-attachments/assets/ef3a91d1-86dd-4029-8f0f-bdf0b727ca6c

  Bartłomiej Dach · 2026-02-14 01:24:42 +09:00
  94d9de955f
• Fix corner radius for user tag glow (#36659)

  Fixes incorrect glow corner radius around user tag buttons
  
  Before:
  <img width="267" height="123" alt="image"
  src="https://github.com/user-attachments/assets/3e602e84-bb13-46f7-942c-85ddf3954946"
  />
  After:
  <img width="227" height="102" alt="image"
  src="https://github.com/user-attachments/assets/4dca2e3d-80e2-4b6c-988e-d14f371cfbe8"
  />

  Neti · 2026-02-13 14:48:07 +09:00
  2026.213.0 860427e4ae
• Add user role to MultiplayerRoomUser (#36652)

  - Related to https://github.com/ppy/osu-server-spectator/issues/406
  
  Adding this field to this model has several vague reasons that I can't
  fully formulate yet, but I can't really see myself going forward
  *without* this.
  
  - People were very excited about having referees displayed on the room
  participants' list, and so adding the referees as real
  `MultiplayerRoomUser`s helps this. Having the role could even be used
  client-side to show a special icon or other status on the participants
  list. (Which isn't done yet, could be as an aesthetic follow-up after
  the basics are in place.)
  - Server-side, having this field is convenient for things like
  permission checks or just plain logic, as with two hubs you just need to
  do different *stuff* on a `MultiplayerRoomUser`.

  Bartłomiej Dach · 2026-02-12 00:57:03 +09:00
  5afd6c6835
• Refactor UpdateableTeamFlag for use on team overlay (#36286)

  Part of #32584.
  
  Very much inspired by the respective component for displaying profile
  pictures on the user overlay
  
  * allow disabling interactivity/tooltips
  * add option to show placeholder on null team instead of hiding
  component entirely
  * move setting corner radius out to respective parent components to
  allow for easier overriding

  Krzysztof Gutkowski · 2026-02-10 23:18:36 +09:00
  2026.211.0 50426eb3c8
• Update resources
  Dean Herbert · 2026-02-10 22:08:07 +09:00
  56bc80ffb9