1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-15 02:57:51 +08:00
Commit Graph

8141 Commits

Author SHA1 Message Date
Bartłomiej Dach
7bc3edb05a
Fix code quality inspection 2023-07-26 20:52:03 +02:00
Dean Herbert
2dace742a3 Add test coverage of score arriving on disk when exporting from results screen after play 2023-07-26 15:21:43 +09:00
Bartłomiej Dach
653f01f4ce
Merge pull request #24359 from peppy/fix-unknown-mod-test-failure
Fix `TestSceneUnknownMod` failing due to null reference
2023-07-25 22:40:03 +02:00
Bartłomiej Dach
3b9f250c1b
Merge branch 'master' into menu-star-fountains 2023-07-25 21:58:13 +02:00
Bartłomiej Dach
d75e6f78d6
Adjust cyclic selection test to hitcircle lifetime adjustments
As it turns out, the tightening of hitcircle lifetimes in editor caused
the test to fail, since the objects were too far apart and at the
starting time of the test, the first object was fully faded out and as
such not alive, therefore leading cyclic selection to fail to select it.

To fix, bring all three objects closer together time-wise so that this
does not happen and the test can continue to exercise its original
behaviour.
2023-07-25 18:54:13 +02:00
Dean Herbert
157b1f301b Rename AllowTrackAdjustments to more understandable ApplyModTrackAdjustments 2023-07-25 20:20:53 +09:00
Dean Herbert
060ad36d60 Add test coverage of music control in editor from external 2023-07-25 20:20:53 +09:00
Dean Herbert
c1d93607e0 Fix TestSceneUnknownMod failing due to null reference 2023-07-25 19:06:13 +09:00
Bartłomiej Dach
21df0e2d60
Migrate test to SelectionRotationHandler 2023-07-23 20:56:22 +02:00
Bartłomiej Dach
2ef843261b
Adjust failing test after metrics changes 2023-07-21 19:08:40 +02:00
Dean Herbert
ca3d1538ae Merge branch 'master' into editor-metrics 2023-07-21 14:26:32 +09:00
Dean Herbert
b29a2081ac Merge branch 'master' into menu-star-fountains 2023-07-21 14:21:16 +09:00
Bartłomiej Dach
c77d3cd6bd
Merge pull request #24294 from peppy/toggle-all-freemods
Add ability to toggle all free mods quickly at multiplayer song select
2023-07-20 22:32:53 +02:00
Bartłomiej Dach
48024cd17f
Add test coverage of double click behaviour 2023-07-20 20:51:17 +02:00
Bartłomiej Dach
f60a6e9893
Fix test step descriptions 2023-07-20 20:47:33 +02:00
Bartłomiej Dach
708dd355cd
Merge branch 'master' into editor-cyclic-selection 2023-07-20 20:19:46 +02:00
Bartłomiej Dach
210e114f7d
Merge branch 'master' into editor-prefer-closest 2023-07-20 19:16:09 +02:00
Dan Balasescu
733ce4c382 Fix incorrect dependency caching
These are tested framework-side to throw exceptions, but the
test is ignored for the source generated version because it quietly
allows this scenario.

The source gen project should eventually have an analyser for these
unsupported cases, or we could consider relaxing this particular case.
2023-07-20 22:30:49 +09:00
Bartłomiej Dach
f3a95d4c13
Merge branch 'master' into menu-star-fountains 2023-07-19 21:26:41 +02:00
Dean Herbert
eb149942e5 Add ability to toggle all free mods quickly at multiplayer song select 2023-07-19 19:08:32 +09:00
Dean Herbert
94c5b8ed32 Apply NRT to TestSceneComposerSelection 2023-07-19 17:22:25 +09:00
Dean Herbert
d33b174243 Add test coverage of beatmap editor cyclic selection 2023-07-19 17:21:20 +09:00
Dean Herbert
9d46d00294 Update skin editor cyclic test to match expectations better 2023-07-19 16:56:16 +09:00
Dean Herbert
4e4dcc9846 Add test coverage of selection preferring closest objects 2023-07-19 16:56:16 +09:00
Dean Herbert
7f336b8dac Merge branch 'master' into editor-metrics 2023-07-19 15:00:51 +09:00
Dean Herbert
2e3d1fe950 Fix regression in time jumping behaviour 2023-07-19 13:38:04 +09:00
Bartłomiej Dach
a42992d3fd
Remove unused local variable 2023-07-16 17:10:26 +02:00
Bartłomiej Dach
72bf43e297
Add failing test covering exit dialog crash 2023-07-16 16:55:20 +02:00
Dean Herbert
56acc9e3dd Change BeatDivisorControl to retrive bindable divisor via DI 2023-07-14 14:03:25 +09:00
Bartłomiej Dach
cdbb6f90be
Merge pull request #24199 from peppy/revert-to-default-design-change
Update design of "revert to default" button
2023-07-13 23:44:24 +02:00
Bartłomiej Dach
ff56e35093
Merge pull request #24197 from peppy/allow-autoplay-failure
Allow autoplay to fail
2023-07-13 23:44:07 +02:00
Bartłomiej Dach
e7dbe3c938
Fix broken test 2023-07-13 22:28:26 +02:00
Bartłomiej Dach
cef0dd1d61
Merge pull request #24190 from novialriptide/emoji-fix
Replace emoji unicode with `[emoji]`
2023-07-13 22:05:12 +02:00
Bartłomiej Dach
6b9dabbd3c
Rewrite test scene to show non-themed and themed variants 2023-07-13 21:54:30 +02:00
Bartłomiej Dach
ae7ed697ec
Adjust failing test after permitting autoplay and no fail combo 2023-07-13 21:22:48 +02:00
Bartłomiej Dach
4859b8c994
Add some extra text coverage against potential emoji-to-link misparses 2023-07-13 20:51:52 +02:00
Bartłomiej Dach
9b771ee798
Merge pull request #24202 from peppy/save-preset-on-select
Allow saving changes to mod presets using enter key
2023-07-13 19:50:16 +02:00
Bartłomiej Dach
4b06b6f34e
Crudely fix crashes when switching between TestResultsWithPlayer cases
In the visual test browser, if two `TestResultsWithPlayer` test cases
are ran consecutively, the second would die on `SoloStatisticsWatcher`
seeing duplicated online score IDs. This surfaced after
6ef39b87fe, which changed
`TestResultsScreen` to inherit `SoloResultsScreen` rather than
`ResultsScreen`.

This is probably _not_ a very good fix, but I'm trying to be pragmatic
for now. `SoloStatisticsWatcher` should probably not live in
`OsuGameBase`.
2023-07-13 19:06:02 +02:00
Dean Herbert
1698caa078 Add kiai fountains to main menu 2023-07-13 22:13:40 +09:00
Dean Herbert
20e4e2581a Change IBeatSyncProvider.Clock to always be non-null 2023-07-13 22:13:40 +09:00
Dean Herbert
6ef39b87fe Reorder tests for testability 2023-07-13 18:12:46 +09:00
Dean Herbert
654a7057fc Add actual statistics changes to better visualise layout 2023-07-13 18:12:46 +09:00
Dean Herbert
aebbffacf2 Show online stats on TestSceneStatisticsPanel
Fix test regression
2023-07-13 18:12:37 +09:00
Dean Herbert
b7ab46d87b Add full statistics score to TestSceneResultsScreen 2023-07-13 18:12:35 +09:00
Dean Herbert
6529c810fa Change order and test population in TestSceneStatisticsPanel to give better visible results 2023-07-13 18:12:19 +09:00
Dean Herbert
db37de45ac Allow saving changes to presets in popover using "select" binding 2023-07-13 17:53:26 +09:00
Dean Herbert
f5c472c0fe Don't hide mod select overlay when pressing select binding with no search 2023-07-13 17:50:07 +09:00
Dean Herbert
94201579f6 Update design of "revert to default" button
I keep getting feedback that the old design looked like anything *but* a
button to revert defaults. Including people clicking it expecting
opposite behaviour.

This is intended to be a temporary design until we get the full new UI
components online (where this is moved to the right-hand-side).
2023-07-13 14:26:03 +09:00
Dean Herbert
1bfe5a18cb Rename RestoreDefaultValueButton to RevertToDefaultButton
Because I can't find it every time I search.
2023-07-13 13:46:50 +09:00
Zyf
82364b4f9f Use OsuScoreProcessor in the scoring test scene 2023-07-11 02:46:32 +02:00
Bartłomiej Dach
2af8c7bc24
Add failing test case for chat message length limit enforcement 2023-07-09 21:40:27 +02:00
Bartłomiej Dach
055e4a78f0
Merge branch 'master' into taiko-hitsounding-final-attempt 2023-07-08 18:10:04 +02:00
Bartłomiej Dach
e2aaef6663
Merge branch 'master' into no-dismiss-all-progress-notifications 2023-07-08 14:19:57 +02:00
Bartłomiej Dach
832c1c0009
Merge branch 'master' into fix-gameplay-samepl-trigger-source-rewind 2023-07-08 13:33:04 +02:00
Dean Herbert
d72765b6f8
Merge pull request #24114 from peppy/editor-save-local-score-management
Ensure scores always have the correct linked `BeatmapInfo`
2023-07-07 15:40:54 +09:00
Dean Herbert
f8be6d41f7 Play basic notification test first 2023-07-07 13:23:45 +09:00
Dean Herbert
8978f2ddd8 Remove all usage of !something!.something
aka don't mix NRT forgiving syntax with not syntax
2023-07-07 10:15:33 +09:00
Dean Herbert
2e98ab0a48 Expose rewinding state of IGameplayClocks
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 19:08:42 +09:00
Dean Herbert
7a3a14e50d Add sample trigger tests covering rewinding of gameplay 2023-07-06 19:08:42 +09:00
Dean Herbert
af3f9086e5 Expose rewinding state of IGameplayClocks
The implementation of this requires a bit of a special case
for 0, so makes sense to implement in a central place.
2023-07-06 14:16:31 +09:00
Dean Herbert
a98a36872e Bring realm library up-to-date 2023-07-06 13:37:43 +09:00
Dean Herbert
9ff6b3fcd3 Merge branch 'master' into editor-save-local-score-management 2023-07-06 12:28:44 +09:00
Dean Herbert
51b0d18c04 Fix weird test assertion output 2023-07-05 18:44:27 +09:00
Bartłomiej Dach
b0f6b22fa7
Add assertions covering correctness of judged flags on entry 2023-07-04 23:48:46 +02:00
Bartłomiej Dach
2b098bdf61
Add test coverage for mixed pooled/non-pooled usages 2023-07-04 23:41:06 +02:00
Bartłomiej Dach
e2ddcb2349
Silence a few remaining nullability warnings 2023-07-04 22:39:26 +02:00
Dean Herbert
d74b1e148d Make ScoreInfo.BeatmapInfo nullable 2023-07-04 14:50:34 +09:00
Bartłomiej Dach
21f758947d
Merge branch 'master' into availability-fixes 2023-07-02 20:38:37 +02:00
Dean Herbert
537404440d Set the beatmap locally available for participants list tests 2023-06-29 13:17:42 +09:00
Bartłomiej Dach
0940ab1e11
Add failing tests covering correct flip handling 2023-06-28 20:48:02 +02:00
Dean Herbert
3883c28b15 Add visual display in participants list when availability is still being established 2023-06-28 16:02:46 +09:00
Dean Herbert
bc26d52dbd
Merge pull request #24067 from bdach/fix-difficulties-not-deleting-from-db
Fix delete difficulty flow not actually deleting the difficulty from realm
2023-06-28 12:06:01 +09:00
Dean Herbert
076f41be12
Merge pull request #24059 from peppy/add-editor-rotate-hotkeys
Add support for `Ctrl` + `<` / `>` to rotate selection in editor
2023-06-28 12:03:34 +09:00
Bartłomiej Dach
d72a8da295
Add test coverage for deleted difficulties staying in realm 2023-06-27 23:40:12 +02:00
Bartłomiej Dach
444f71541a
Add test coverage for rotate hotkeys 2023-06-27 22:10:53 +02:00
Bartłomiej Dach
7052f87eb8
Add even more safety against unloaded components 2023-06-27 21:21:14 +02:00
Bartłomiej Dach
af66ccbfdf
Merge branch 'master' into hud/kc-skinnable 2023-06-27 20:35:47 +02:00
Bartłomiej Dach
9681ee7eeb
Fix broken test step 2023-06-27 20:29:27 +02:00
Bartłomiej Dach
ada9c48bde
Attempt to fix more test failures 2023-06-27 20:17:58 +02:00
Dean Herbert
8bd6f7a46a Rename ClicksPerSecondCalculator to ClicksPerSecondController 2023-06-27 16:38:46 +09:00
Dean Herbert
e21583ff1b Refactor InputCountController to not require being added to foreign body via Attach
I've made the flow match `ClicksPerSecondCalculator` as close as
possible. Hopefully this reads better.
2023-06-27 16:36:00 +09:00
Dean Herbert
e99de0eb5d Add safety to tests to ensure loaded 2023-06-27 16:04:34 +09:00
Bartłomiej Dach
9c87d42f2b
Attempt to remedy HUD overlay test failure by waiting more 2023-06-26 22:41:31 +02:00
Bartłomiej Dach
e998be0eee
Use == true rather than ?? false 2023-06-26 22:29:20 +02:00
Bartłomiej Dach
7200855d46
Rename Judgement{Tally -> CountController} 2023-06-26 19:30:04 +02:00
Bartłomiej Dach
8d91580dc1
Rename {KeyCounter -> InputCount}Controller 2023-06-26 19:27:42 +02:00
Dean Herbert
14c95f4584 Apply NRT to FilterCriteria 2023-06-26 17:54:11 +09:00
Dean Herbert
0c869367e1
Merge branch 'master' into hud/kc-skinnable 2023-06-26 15:53:16 +09:00
Dean Herbert
ac0c988d49 Fix weirdly named test method and add xmldoc 2023-06-26 13:21:29 +09:00
Joseph Madamba
25c9bf4061
Improve and refactor LoginPanel test scene to use LoginOverlay 2023-06-25 11:39:32 -07:00
tsrk
350d722c8d
Merge branch 'master' into hud/kc-skinnable 2023-06-25 15:42:08 +02:00
Dean Herbert
cf43cd2bdc Rename test scene to match updated class name 2023-06-25 21:26:10 +09:00
Bartłomiej Dach
a7202721ff
Merge branch 'master' into no-confirmation-on-update-restart 2023-06-25 13:35:21 +02:00
Bartłomiej Dach
25842105ce
Merge pull request #23976 from peppy/gameplay-sample-trigger-source-correctness
Adjust `GameplaySampleTriggerSource` to only switch samples when close enough to the next hit object
2023-06-25 08:23:55 +02:00
Bartłomiej Dach
f8d2f2f7e1
Fix more issues discovered by CI that can be fixed game-side 2023-06-24 19:04:05 +02:00
Bartłomiej Dach
d7ae430ec2
Merge branch 'master' into framework-update 2023-06-24 18:47:52 +02:00
Bartłomiej Dach
e273c223a8
Fix some more missed CI inspections 2023-06-24 17:11:38 +02:00
Bartłomiej Dach
e3a89a6273
Fix remaining obvious CI inspections 2023-06-24 16:07:01 +02:00
Dean Herbert
2bda63c2c8 Merge branch 'master' into mass-nrt 2023-06-24 09:59:15 +09:00
Dean Herbert
58e6b3782b Fix a couple of remaining issues 2023-06-24 09:58:36 +09:00