Dean Herbert
d4ce712672
Add note about weird taiko iteration
2025-02-10 17:57:01 +09:00
James Wilson
9f90ebb2f7
Calculate hit windows in performance calculator instead of databased difficulty attributes ( #31735 )
...
* Calculate hit windows in performance calculator instead of databased difficulty attributes
* Apply mods to beatmap difficulty in osu! performance calculator
* Remove `GreatHitWindow` difficulty attribute for osu!mania
* Remove use of approach rate and overall difficulty attributes for osu!
* Remove use of hit window difficulty attributes in osu!taiko
* Remove use of approach rate attribute in osu!catch
* Remove unused attribute IDs
* Code quality
* Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set
2025-02-07 19:21:12 +09:00
Dean Herbert
4f6fd68a91
Fix inspections
2025-02-07 13:54:35 +09:00
Dean Herbert
40ea7ff238
Add better documentation for interval change code
2025-02-05 18:48:48 +09:00
Dean Herbert
8447679db9
Initial tidy-up pass on IntervalGroupingUtils
2025-02-05 15:47:18 +09:00
Dean Herbert
325483192a
Tidy up xmldoc and remove another unused field
2025-02-05 15:33:06 +09:00
Dean Herbert
fc93390284
Remove unused HitObjectInterval
2025-02-05 15:10:15 +09:00
Dean Herbert
709ad02a51
Simplify TaikoRhythmData's ratio computation
2025-02-05 15:09:51 +09:00
Dean Herbert
fa844b0ebc
Rename Colour / Rhythm related fields and classes
2025-02-05 15:08:15 +09:00
tsunyoku
f3c17f1c2b
Use correct English
2025-01-27 12:56:33 +00:00
tsunyoku
71b89c390f
Rename class, rename children to hit objects and groups, make fields un-settable
2025-01-27 12:54:22 +00:00
tsunyoku
13c956c248
Account for floating point errors
2025-01-26 20:15:13 +00:00
tsunyoku
a7aa553445
Fix incorrect startTime calculation
2025-01-26 16:21:07 +00:00
tsunyoku
8f17a44976
Remove unused default value
2025-01-23 10:29:04 +00:00
tsunyoku
753e9ef7c7
Keep old behaviour of double.PositiveInfinity being the default for Interval
2025-01-22 13:26:12 +00:00
tsunyoku
2c0d6b14c8
Fix incorrect namespace
2025-01-22 13:24:30 +00:00
tsunyoku
14c68bcc58
Replace weird IntervalGroupedHitObjects inheritance layer
2025-01-21 15:58:33 +00:00
tsunyoku
1c4bc6dffd
Revert Precision.DefinitelyBigger usage
2025-01-21 15:01:32 +00:00
tsunyoku
764b0001ef
Fix typo in ColourEvaluator
2025-01-21 14:56:51 +00:00
tsunyoku
e0882d2a53
Make rescale a static method
2025-01-21 14:33:40 +00:00
tsunyoku
20a76d832d
Rename rhythm preprocessing objects to be clearer with intent
2025-01-21 14:29:07 +00:00
tsunyoku
ef8867704a
Add xmldoc to explain IHasInterval.Interval
2025-01-21 14:28:15 +00:00
tsunyoku
b8c79d58a7
Refactor StaminaEvaluator
2025-01-21 14:25:28 +00:00
tsunyoku
9919179b0b
Format ReadingEvaluator
2025-01-21 14:24:46 +00:00
tsunyoku
dbe36887f6
Refactor ColourEvaluator
2025-01-21 14:24:27 +00:00
tsunyoku
fa20bc6631
Remove EffectiveBPMPreprocessor
2025-01-21 14:24:04 +00:00
Dean Herbert
c8b05ce114
Tidy up code quality of RhythmEvaluator
2025-01-21 13:40:55 +09:00
James Wilson
a77dfb1068
Use correct HitWindows class for osu!taiko hit windows in difficulty calculator ( #31579 )
...
* Use correct `HitWindows` class for osu!taiko hit windows in difficulty calculator
* Remove redundant (and incorrect) hit window creation
* Balance rhythm against hit window changes
2025-01-20 17:04:31 +05:00
StanR
22e839d62b
Replace indexed skill access with skills.OfType<...>().Single() ( #30034 )
...
* Replace indexed skill access with `skills.First(s is ...)`
* Fix comment
* Further refactoring to remove casts
---------
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2025-01-20 09:39:35 +00:00
Eloise
e57565435e
osu!taiko new rhythm penalty for long intervals using stamina difficulty ( #31573 )
...
* Replace long interval nerf with a new one that uses stamina difficulty
* Turn tabs into spaces
* Update unit tests
---------
Co-authored-by: StanR <hi@stanr.info>
2025-01-20 11:40:52 +03:00
Jay Lawton
2d0bc6cb62
Rebalance stamina length bonus in osu!taiko ( #31556 )
...
* adjust straincount to assume 1300
* remove comment
---------
Co-authored-by: StanR <hi@stanr.info>
2025-01-19 22:40:09 +00:00
Jay Lawton
e04727afb1
Improve convert considerations in osu!taiko ( #31546 )
...
* return a higher finger count
* implement isConvert
* diffcalc cleanup
* harshen monostaminafactor accuracy curve
* readd comment
* adjusts tests
2025-01-19 21:55:34 +00:00
Eloise
8354cd5f93
Penalise the reading difficulty of high velocity notes using "note density" ( #31512 )
...
* Penalise reading difficulty of high velocity notes at high densities
* Use System for math functions
* Lawtrohux changes
* Clean up density penalty comment
* Swap midVelocity and highVelocity back around
* code quality pass
---------
Co-authored-by: Jay Lawton <jaime@merkids.com>
Co-authored-by: StanR <hi@stanr.info>
2025-01-18 13:52:47 +00:00
Natelytle
5b4ba9225d
Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils ( #31520 )
...
* Move error function implementation to osu.Game.Rulesets.Difficulty.Utils
* Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs
2025-01-17 19:37:34 +00:00
Jay Lawton
a42c03cea4
osu!taiko further considerations for rhythm ( #31339 )
...
* further considerations for rhythm
* new rhythm balancing
* fix license header
* use isNormal to validate ratio
* adjust tests
---------
Co-authored-by: StanR <hi@stanr.info>
2025-01-17 16:15:22 +05:00
Jay Lawton
a83f917d87
osu!taiko star rating and performance points rebalance ( #31338 )
...
* rebalance
* revert pp scaling change
* further rebalancing
* comment
* adjust tests
2025-01-16 21:14:05 +00:00
Jay Lawton
9da8dcd815
osu!taiko stamina balancing ( #31337 )
...
* stamina considerations
* remove consecutive note count
* adjust multiplier
* add back comment
* adjust tests
* adjusts tests post merge
* use diffcalcutils
---------
Co-authored-by: StanR <hi@stanr.info>
2025-01-16 10:30:02 +00:00
Jay Lawton
0a21183e54
reading mono nerf ( #31510 )
2025-01-15 10:34:21 +00:00
Natelytle
5bed7c22e3
Remove lower cap on deviation without misses ( #31499 )
2025-01-14 19:12:08 +00:00
Jay Lawton
4095b2662b
Add consistentRatioPenalty to the Colour skill. ( #31285 )
...
* fix colour
* review fix
Co-authored-by: StanR <castl@inbox.ru>
* remove cancelled out operand
* increase nerf, adjust tests
* fix automated spacing issues
* up penalty
* adjust tests
* apply review changes
* fix nullable hell
---------
Co-authored-by: StanR <castl@inbox.ru>
2025-01-07 11:36:56 +00:00
Jay Lawton
824497d82c
Rewrite of the Rhythm Skill within osu!taiko ( #31284 )
...
* implement bell curve into diffcalcutils
* remove unneeded attributes
* implement new rhythm skill
* change dho variables
* update dho rhythm
* interval interface
* implement rhythmevaluator
* evenhitobjects
* evenpatterns
* evenrhythm
* change attribute ordering
* initial balancing
* change naming to Same instead of Even
* remove attribute bump for display
* Fix diffcalc tests
---------
Co-authored-by: StanR <hi@stanr.info>
2024-12-27 16:30:30 +03:00
Jay Lawton
f6a36f7b2e
Implement Reading Skill into osu!taiko ( #31208 )
2024-12-21 13:19:14 +03:00
Jay Lawton
d8c3d899eb
remove particular condition on convert nerf ( #31196 )
...
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-19 17:22:16 +00:00
Jay Lawton
ecd6b41928
Increase accscalingshift and include countok in hit proportion ( #31195 )
...
* revert acc scaling shift to previous values
* increase variance in accuracy values across od
* move return values, move nullcheck into return
---------
Co-authored-by: James Wilson <tsunyoku@gmail.com>
2024-12-19 14:45:11 +00:00
Jay Lawton
4ca88ae2d6
Refactor TaikoDifficultyCalculator and add DifficultStrain attributes ( #31191 )
...
* refactor + countdifficultstrain
* norm in utils
* adjust scaling shift
* fix comment
* revert all value changes
* add the else back
* remove cds comments
2024-12-19 11:32:59 +00:00
YaniFR
0f2f25db53
Adjust DifficultyValue curve to avoid lower star rating of osu!taiko being too inflated ( #31067 )
...
* low sr
* merge two line
* update decimal
* fix formatting
---------
Co-authored-by: StanR <hi@stanr.info>
2024-12-18 21:11:51 +03:00
Jay Lawton
79a3afe06f
Implement considerations for Relax within osu!taiko diffcalc ( #30591 )
2024-12-18 18:16:27 +03:00
Bartłomiej Dach
3cfa455369
Fix strong drum rolls being counted for double the combo in legacy scoring attributes
2024-11-29 10:54:32 +01:00
StanR
78c97d2cd7
Add DifficultyCalculationUtils
2024-11-07 20:36:00 +05:00
Dean Herbert
795477372f
Merge pull request #30456 from smoogipoo/revert-taiko-convert-diffcalc-change
...
Bring back convert nerf to fix overweighted taiko difficulty
2024-11-04 20:00:58 +09:00
