1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-22 04:07:25 +08:00
osu-lazer/osu.Game/Screens/Play
Bartłomiej Dach 9d54f1a092
Fix some maps requiring multiple intro skips that weren't there on stable
Closes https://github.com/ppy/osu/issues/25633.

The reason why that particular beatmap did not have a double skip
on stable is here:

    e53980dd76/osu!/GameModes/Play/Player.cs#L1761-L1770

The particular place of interest is the `leadInTime < 10000` check.
If `leadInTime < 10000`, then `leadIn == leadInTime`, and it turns out
that `AudioEngine.Time` will always be more than or equal to `leadIn`,
because it's also the gameplay start time:

    e53980dd76/osu!/GameModes/Play/Player.cs#L2765

This essentially means that if the `leadInTime` is less than 10000,
that particular check is just dead. So a double skip can only occur
if the gameplay starts at time -10000 or earlier due to the storyboard.
2024-04-03 16:12:20 +02:00
..
Break Adjust blurred icons position due to size handling differences 2024-03-31 01:55:34 +03:00
HUD Merge branch 'master' into argon-pp-counter 2024-03-08 10:32:16 +08:00
PlayerSettings Merge pull request #26591 from peppy/offset-awareness 2024-01-22 14:59:31 +01:00
ArgonKeyCounter.cs Use left aligned text for non-rotate key counter 2023-11-06 16:32:12 +09:00
ArgonKeyCounterDisplay.cs Refactor KeyCounterDisplay to use autosize 2023-11-12 17:19:25 +09:00
BeatmapMetadataDisplay.cs Refactor IWorkingBeatmap.Background to GetBackground() 2023-06-08 16:19:32 +09:00
BreakOverlay.cs Make ScoreProcessor.Rank read-only 2024-01-04 17:13:24 +09:00
BreakTracker.cs Partial everything 2022-11-27 00:00:27 +09:00
ComboEffects.cs Replace various local implementations of rewinding checks with new property 2023-07-07 15:21:24 +09:00
DelayedResumeOverlay.cs Add sounds to countdown 2024-03-21 11:45:48 +08:00
DimmableStoryboard.cs Partial everything 2022-11-27 00:00:27 +09:00
FailAnimationContainer.cs Use AliveEntries where we don't need startTime order 2024-02-03 19:54:08 +03:00
FailOverlay.cs Apply NRT to touched files 2024-02-27 23:58:28 -08:00
GameplayClockContainer.cs Add logging for GameplayClockContainer starting or stopping 2024-03-06 04:37:11 +08:00
GameplayClockExtensions.cs Rename GameplayAdjustments -> AdjustmentsFromMods 2022-09-08 17:14:06 +09:00
GameplayMenuOverlay.cs Refactor test to only allow init of actions 2024-02-27 23:24:16 -08:00
GameplayOffsetControl.cs Disable positional interaction for now 2023-12-24 03:00:51 +09:00
GameplayState.cs Expose beatmap storyboard as part of GameplayState 2024-02-29 05:39:36 +03:00
HotkeyExitOverlay.cs Automated pass 2023-06-24 01:00:03 +09:00
HotkeyRetryOverlay.cs Automated pass 2023-06-24 01:00:03 +09:00
HUDOverlay.cs Add local function to perform iteration to better explain the "why" 2024-02-26 09:04:39 +08:00
IGameplayClock.cs Expose rewinding state of IGameplayClocks 2023-07-06 19:08:42 +09:00
ILocalUserPlayInfo.cs Automated pass 2023-06-24 01:00:03 +09:00
MasterGameplayClockContainer.cs Fix some maps requiring multiple intro skips that weren't there on stable 2024-04-03 16:12:20 +02:00
OffsetCorrectionClock.cs Remove "pause rate adjust" flow 2024-01-18 14:21:02 +09:00
PauseOverlay.cs Apply NRT to touched files 2024-02-27 23:58:28 -08:00
Player.cs Merge branch 'master' into taiko-slider-storyboard 2024-02-29 08:50:58 +01:00
PlayerConfiguration.cs Add a gameplay configuration flag to disable fail animation 2024-01-04 17:13:24 +09:00
PlayerLoader.cs Merge pull request #26937 from frenzibyte/fix-osu-logo-blocking-load 2024-03-21 21:52:25 +08:00
PlayerLoaderDisclaimer.cs Remove redundant cast 2024-03-16 13:18:42 +08:00
PlayerTouchInputDetector.cs Fix touch device not always activating when it should 2024-01-16 17:12:40 +01:00
ReplayPlayer.cs Change ResultsScreen constructor boolean params to init-only properties 2024-02-22 20:15:03 +01:00
ReplayPlayerLoader.cs Automated pass 2023-06-24 01:00:03 +09:00
ResumeOverlay.cs Fix catch by moving cursor-specific handling local 2024-03-04 16:08:17 +09:00
RoomSubmittingPlayer.cs Add additional gameplay metadata to room score request 2024-02-10 17:20:17 +09:00
SaveFailedScoreButton.cs Apply NRT to touched files 2024-02-27 23:58:28 -08:00
ScreenSuspensionHandler.cs Partial everything 2022-11-27 00:00:27 +09:00
ScreenWithBeatmapBackground.cs Fix song select potentially updating background parameters when not the current screen 2023-02-16 18:45:22 +09:00
SkipOverlay.cs Fix various other inspections 2023-10-17 17:48:51 +09:00
SoloPlayer.cs Show selected submission failure messages even in solo 2024-02-15 10:55:08 +01:00
SoloSpectatorPlayer.cs Fix some NRT changes 2024-02-28 11:03:09 -08:00
SoloSpectatorScreen.cs Add extra test coverage and handle case where still at loading screen 2023-11-24 15:05:39 +09:00
SpectatorPlayer.cs Fix some NRT changes 2024-02-28 11:03:09 -08:00
SpectatorPlayerLoader.cs Automated pass 2023-06-24 01:00:03 +09:00
SpectatorResultsScreen.cs Change ResultsScreen constructor boolean params to init-only properties 2024-02-22 20:15:03 +01:00
SquareGraph.cs Fix some new nullable inspections 2023-10-30 15:10:10 +09:00
SubmittingPlayer.cs Move away from Solo namespace 2024-02-29 01:21:17 +03:00