1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-17 16:13:33 +08:00
Files
osu-lazer/osu.Game.Tests/Visual/UserInterface
T
Bartłomiej Dach 97ddc8e160 Fix footer buttons still being able to fire their action when temporarily hidden by overlay content (#37231)
In human words: I read [this forum
thread](https://osu.ppy.sh/community/forums/topics/2195138?n=1) today
and was horrified to see the user there opening the F3 options menu in
song select *when the F1 mod overlay was pulled up*, which is (a) not
intended UX, (b) looks terrible, and (c) just wrecks the game
behaviourally wholesale from start to end.

So with this change you don't get to open options via F3 while inside
mod overlay at all.

The `Action` shadowing is pretty ugly but I don't have better ideas.
Initially I tried to mess with `Enabled` (as I did once previously, see
https://github.com/ppy/osu/commit/36628e24f92c286b87c118c7c1bb9bc582895571),
but it's much more complicated in this case because the enabled state
needs to be restored when the buttons reappear, or it could change
independently while the buttons are temporarily hidden, etc. So I'd
rather just not deal with all that and invent a parallel scheme.
97ddc8e160 · 2026-04-08 00:40:50 +09:00
History
..
2024-11-21 13:06:01 +01:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2025-11-20 10:12:43 +01:00
2026-01-12 23:38:17 -05:00
2025-06-04 19:58:04 +02:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2024-05-06 08:53:41 +02:00
2023-06-24 01:00:03 +09:00
2024-06-27 06:41:44 +03:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2022-11-27 00:00:27 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00
2023-06-24 01:00:03 +09:00