1322 Commits

• Fix footer buttons still being able to fire their action when temporarily hidden by overlay content (#37231)

  In human words: I read [this forum
  thread](https://osu.ppy.sh/community/forums/topics/2195138?n=1) today
  and was horrified to see the user there opening the F3 options menu in
  song select *when the F1 mod overlay was pulled up*, which is (a) not
  intended UX, (b) looks terrible, and (c) just wrecks the game
  behaviourally wholesale from start to end.
  
  So with this change you don't get to open options via F3 while inside
  mod overlay at all.
  
  The `Action` shadowing is pretty ugly but I don't have better ideas.
  Initially I tried to mess with `Enabled` (as I did once previously, see
  https://github.com/ppy/osu/commit/36628e24f92c286b87c118c7c1bb9bc582895571),
  but it's much more complicated in this case because the enabled state
  needs to be restored when the buttons reappear, or it could change
  independently while the buttons are temporarily hidden, etc. So I'd
  rather just not deal with all that and invent a parallel scheme.

  Bartłomiej Dach · 2026-04-08 00:40:50 +09:00
  97ddc8e160
• Add ability to search for users (#37225)

  This was a private request for roundtable event usage. It’s also a
  common feature request, so I decided to spend a bit of time getting this
  working well-enough.
  
  
  https://github.com/user-attachments/assets/acceb57f-2979-43d0-9fc2-33e977bd2dd5
  
  
  ---
  
  ### Delay loading spinner / loading layer initial load briefly to avoid
  flickering
  
  There's cases in this overlay where loading takes a few milliseconds.
  The loading spinner gets annoying. This also happens elsewhere, so this
  could be considered a global fix. Separate PR? probably...
  
  ### Ingest loading state of dashboard child content to show more correct
  loading layer
  
  Each display had their own loading layer implementation, but this is
  already too deep (inside the scroll content) and doesn't display great
  when for instance, results don't take up the full screen height.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-04-07 14:14:49 +02:00
  c570db6c40
• Add method for silently dismissing progress notifications without completion (#37227)

  This was used in one place, but I foresee this being a more common
  scenario. This also fixes an edge case where the dismiss process would
  fail if completion happened on an async thread before the
  `NotificationOverlay`'s scheduler could handle the initial ingress.

  Dean Herbert · 2026-04-07 13:43:14 +02:00
  a3a530c25d
• Assorted test deflaking (#37191)

  A few quick ones from https://github.com/ppy/osu/issues/37190.
  
  ## [Rewrite `TestSceneDeleteLocalScore` to have less context menu
  containers (and hopefully no longer
  flake)](https://github.com/ppy/osu/commit/ea0bc5b72374056d1749f8058f4874b7ef66a241)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23890777748#user-content-r3s3.
  
  This is a speculative fix but I'm feeling somewhat confident about this
  one.
  
  `BeatmapLeaderboardWedge` has TWO separate `ContextMenuContainer`s
  itself, and the test mentioned here was bringing a third. I have a
  feeling that the test flaking may have something to do with the fact
  that the test logic would attempt to click a menu item on specifically
  ONE of the three context menus. My bet is that when it fails, it's
  because it's trying the wrong one, but I don't have reproduction.
  
  ## [Wait for text to appear in flaking
  `TestSceneDrawableRoomPlaylist.TestSelectableMouseHandling`
  test](https://github.com/ppy/osu/commit/9d62eea8b56a0eb013e8116db0d38424b500876f)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23888446400#user-content-r1s1.
  
  Speculative. Banking on the fact that it takes time to load the sprite
  texts.
  
  ## [Remove all tests from `TestSceneWikiMarkdownContainer` dependent on
  existence of wiki on
  dev](https://github.com/ppy/osu/commit/8f319f91c98510b84e915bb61ec147618a584ce1)
  
  Deletes a flaky as seen in
  https://github.com/ppy/osu/actions/runs/23878899702#user-content-r2s2.
  
  The year is 2026 and LLM scrapers hammer [the
  entire](https://sourcehut.org/blog/2025-04-15-you-cannot-have-our-users-data/)
  [internet](https://blog.metabrainz.org/2025/12/11/we-cant-have-nice-things-because-of-ai-scrapers/)
  all over to scrape whatever ounce of Human Content there is left to feed
  the Moloch so that it can regurgitate it back in the form of The Most
  Average Speech You've Ever Read. We are not immune to this, and as such
  the LLM homunculi have hit the dev.ppy.sh wiki instance enough times for
  it to just completely [be banished to the
  blagole](https://www.youtube.com/watch?v=AfA_2Ku1aJY).
  
  Which means I get to freely delete flaky tests that should never have
  been running as part of CI because they're completely useless now and
  it's not like we're ever turning them back on again.
  
  ## [Use equality check in
  `TestSceneBeatmapCarouselScrolling.TestScrollPositionMaintainedOnRemove_SecondSelected`
  that's less sensitive to floating
  point](https://github.com/ppy/osu/commit/6f2a1de58f7e816830c430e89117ee4c594f529d)
  
  As seen in
  https://github.com/ppy/osu/actions/runs/23826420794#user-content-r0s1.

  Bartłomiej Dach · 2026-04-04 00:17:31 +09:00
  090fe44f86
• Keep any stateful dropdown menu open on click (#37021)

  Right click is a very obfuscated UX which most users won't find. This
  makes more sense to the average user (probably).
  
  Caveat: clicking away actually sends clicks to underlying UI. This is
  not the case in macOS or windows (locally, same app; globally it still
  sends clicks to other windows).
  
  Coming from https://github.com/ppy/osu/discussions/36926.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-21 22:18:02 +09:00
  1016bca280
• Remove duplicated CollectionDropdown class (#37020)

  Arguably we should just nuke the now playing overlay playlist window
  completely as the functionality was gimped when search was removed. Now
  it doesn't seek to the currently playing track, nor play sequentially,
  nor do anything useful.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-18 10:42:01 +01:00
  f84caf1182
• Fix "Deselect all" mods button becoming enabled when system mods are applied (#36913)

  Closes https://github.com/ppy/osu/issues/36906.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-03-10 12:40:54 +01:00
  14743a14eb
• Refactor ShearedButton to allow easier relative sizing (#36802)

  This commit rearranges the contents of `ShearedButtons` to be more
  independent of each other in regards to sizing. Thanks to that, the
  custom logic related to enabling autosizing is no longer necessary.
  Witdh and height are no longer set via the constructor, and can be
  freely configured using the initializer syntax.
  
  Additionally, this allows the button to use relative sizing without
  having to resort to any hackery with `Size` (this will come in handy for
  me when implementing the new footer on multiplayer screens).
  
  Given that most of the `ShearedButton`s currently in use set their width
  explicitly, I did not set `AutoSizeAxes = Axes.X` like it would be by
  default previously. Instead it is set on the only two such buttons (show
  converts/selected mods on ssv2). I suppose it might be a good idea to
  have it set that by default if no `Width` is specified, as right now
  it'll just not show anything.
  
  Also I've set the margin on the text field by default in all cases
  instead of only when autosizing like how it was previously, since
  otherwise it would be a pain to set that on each button instance when
  needed. I've checked all affected components and could not find any text
  overflowing issues that this could cause.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-03-06 02:09:05 +09:00
  b76a7e1bb6
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Update TestSceneDeleteLocalScore to use newer leaderboard
  Dean Herbert · 2026-03-03 16:45:14 +09:00
  7e7421e1ea
• Remove all song select v1 files

  This contains no code changes (that would need review), only file
  deletion and extraction where required in a few odd cases.

  Dean Herbert · 2026-03-03 16:45:14 +09:00
  1a8d2855d4
• Refactor TestSceneScreenFooter to test entire OsuScreens (#36718)

  Part of the `ScreenFooter` refactor, which intends to move the footer
  content handling to `OsuScreen`. This commit updates the `ScreenFooter`
  test to operate on entire `OsuScreen`s, in order to better test the
  entire flow of pushing a screen, and having it create and add its own
  content to the footer.
  
  This should be 80-90% identical to the original test case structure
  wise, just that instead of manually manipulating the footer with
  `SetButtons()`, various screens with the appropriate buttons are being
  moved around the screen stack.
  
  Additionally this adds some more tests handling common use cases, as
  well as removes `TestLoadOverlayAfterFooterIsDisplayed()`, since as far
  as I understand the behaviour described in it doesn't actually happen in
  production code. From what I can see, Screens instantiate their overlays
  in `load()`, and then register them in `LoadComplete()`. There seems to
  be no case where a `ShearedOverlayContainer` is created in the middle of
  a screen's lifecycle.

  Krzysztof Gutkowski · 2026-03-01 22:36:07 +09:00
  b88cba0829
• Migrate sheared overlay tests to ScreenTestScene (#36736)

  Part of the screen footer refactor.
  
  Once footer content is being managed by `OsuScreen`, the current tests
  which simply create the tested overlay and `ScreenFooter` in a container
  will no longer work.
  
  This PR refactors them to use `ScreenTestScene` with the setup being
  creating a dedicated testing `OsuScreen` which does the bare minimum to
  create the tested overlay and necessary components (eg.
  `FooterButtonFreeModsV2` for `TestSceneFreeModsOverlay`).
  
  Most of the changes here can be described as
  `%s/<...>Overlay/screen.Overlay/g`, with some minor touchups as
  necessary, given that we're now testing a more complete flow which
  checks more things that were previously not handled by the tests.
  
  ## [Move footer to front in
  ScreenTestScene](https://github.com/ppy/osu/commit/f8740e0403b3c0badd60d394c737f2aa912a9ed6)
  
  Self-explanatory. Without it the footer would show below the actual
  overlay, breaking tests depending on manual input. For the sake of tests
  not breaking in CI, both #36718 and this have this included - would
  prefer the former to be merged first since it was already reviewed
  there.
  
  ## `TestSceneModSelectOverlay`
  
  There were a few tests (`TestColumnHidingOnIsValidChange`,
  `TestColumnHidingOnTextFilterChange`, and
  `TestHidingOverlayClearsTextSearch`) that would create a custom overlay
  instance instead of the globally provided one. I've tested both and the
  tests run fine with the default overlay, so they're now using that
  instead.
  
  ## `TestSceneFreeModSelectOverlay`
  
  Updated to use footer v2.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Krzysztof Gutkowski · 2026-02-28 04:22:58 +09:00
  105342e5bf
• Add ability for LoadingLayer to block all keyboard input
  Dean Herbert · 2026-02-18 20:01:38 +09:00
  83587e2265
• Add missing wait step to fix flaky test in TestSceneModPresetColumn

  See
  https://github.com/ppy/osu/actions/runs/21799682256/job/62893024859?pr=36627

  Dean Herbert · 2026-02-09 12:50:40 +09:00
  f39b310eb5
• Implement sorting and display styles for currently online users (#33649)

  - Adds sorting and display styles.
  - Saves sort/display modes to the config.
  - Improves performance, especially on the 2nd+ time opening the overlay.
  
  
  https://github.com/user-attachments/assets/e32b50d0-58a1-4eef-b18c-988fb497e545
  
  ---
  
  Coming off some recent feedback in
  https://github.com/ppy/osu/discussions/33426#discussioncomment-13431275,
  I decided to take a bit of a detour and get a little bit more
  functionality in.
  
  Sorting by rank, although it should technically work, doesn't work right
  now. This is because the osu!web API doesn't return user rank on
  `/user/` lookups - it's only returned for the friends request. I'm
  leaving this open as a discussion topic.
  - We can make osu!web return the rank and osu! will require no further
  changes to work correctly, or
  - We can try to implement additional paths through
  `osu-server-spectator` which would blow this PR out of proportion and is
  best left for a task of its own.
  
  For simplicity, I've re-implemented this display mostly as its own
  component for now, lifting code from `FriendDisplay` which was recently
  overhauled. These implementations should eventually be combined somehow
  but that's dependent on:
  1. Figuring out the styling - friends can display offline users for
  which it makes no sense to display the "spectate" button.
  2. Figuring out how to handle the different users/presence pathways.
  It's mostly a code complexity issue.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2026-02-05 01:22:36 +09:00
  1230da33a5
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Add some more extra test coverage
  Bartłomiej Dach · 2026-01-23 13:18:48 +01:00
  259c5708f1
• Add failing tests
  Bartłomiej Dach · 2026-01-23 07:50:20 +01:00
  d80934c344
• Merge pull request #36392 from iwa/feat/numeric-hotkeys-for-presets-mod-select

  Mod Select: Support numeric row hotkeys to quick select Presets

  Dean Herbert · 2026-01-23 03:28:52 +09:00
  6f038bff48
• Add test coverage
  Dean Herbert · 2026-01-23 01:13:49 +09:00
  98c6f6afcd
• Merge branch 'master' into new-settings/overlay
  Dean Herbert · 2026-01-22 18:38:17 +09:00
  42302c45ec
• Update editor slider controls to new design (#36346)

  (partially) Closes: #36233
  Surpasses: #36244 
  
  This PR meant to be one of the last steps that finally make editor use
  the new forms. Initially it meant to only change one
  SliderWithTextBoxInput in "Effects section" in timing screen, however
  soon after it was obvious that there's many other places that still
  using it. This currently won't affect
  IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for
  example, since I think it needs more consideration.
  Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at
  all, as it's going to be replaced with modern FormSliderBar
  
  Comparison:
  |master|this PR|
  |:---:|:---:|
  |<img width="510" height="316"
  alt="532203751-eb965923-d3a8-441d-a7c8-5c364a6328ad"
  src="https://github.com/user-attachments/assets/268b45b8-e235-494f-91a5-d00db057dba8"
  />|<img width="540" height="321"
  alt="535466527-3a700a8b-bc3c-4610-998f-a4e55ee03eed"
  src="https://github.com/user-attachments/assets/20cd4b58-b0bd-49bc-8c48-7de5cf8556b3"
  />|
  |<img width="694" height="639"
  alt="534509844-f00e4da4-53c4-45e8-80ea-1be62da6c83b"
  src="https://github.com/user-attachments/assets/398c4484-a867-4df1-9de3-0940aa748a01"
  />|<img width="720" height="433" alt="изображение"
  src="https://github.com/user-attachments/assets/b6359443-a224-4a55-b171-07e8f013cf46"
  />|
  |<img width="715" height="353"
  alt="534509421-a6ac950f-16e8-4a16-bca6-1a781f82135f"
  src="https://github.com/user-attachments/assets/4854312b-772f-4b81-a800-89e58d4c715d"
  />|<img width="710" height="296" alt="изображение"
  src="https://github.com/user-attachments/assets/a7fed53e-e006-4285-92c9-bb84cb603f60"
  />|
  |<img width="717" height="374"
  alt="534509478-80222623-7766-481d-8682-088276d415ee"
  src="https://github.com/user-attachments/assets/8143b6dc-4599-45d5-bd3b-f059caf3d93d"
  />|<img width="718" height="328" alt="изображение"
  src="https://github.com/user-attachments/assets/bffa04de-983c-45ae-a1ec-373701ea0e49"
  />|
  |<img width="702" height="446"
  alt="534509935-58954060-7ac1-4392-8754-a58f909e86aa"
  src="https://github.com/user-attachments/assets/2bb67a2d-3f57-42a1-96ce-b30b4891e1a4"
  />|<img width="722" height="386" alt="изображение"
  src="https://github.com/user-attachments/assets/01b7fff4-7f31-4aac-90c9-353b15f4964e"
  />|

  De4n · 2026-01-16 20:08:52 +09:00
  e05b6f44b9
• Fix double-clicking form slider bar not propagating default to other bindables when TransferValueOnCommit is true (#36354)

  - Addresses https://github.com/ppy/osu/pull/36346#discussion_r2692322683
  
  The inner slider bar binds its `Current` to
  `currentNumberInstantaneous`:
  
  
  https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L225-L236
  
  But the current bindable of the form component doesn't update because of
  this.
  
  
  https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L285-L293
  
  Fixed it by just moving the `ResetToDefault` action up another level.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Joseph Madamba · 2026-01-16 19:48:36 +09:00
  a8ada50549
• Fix weirdly defined constant
  Dean Herbert · 2026-01-15 19:01:32 +09:00
  cd433fea50
• Fix toasts showing "no key bound" for operations which can't have keys bound

  Supersedes and closes https://github.com/ppy/osu/pull/35781.
  Closes https://github.com/ppy/osu/issues/36294.

  Dean Herbert · 2026-01-15 17:52:30 +09:00
  b4ba327c1c
• Merge pull request #36324 from frenzibyte/better-form-button

  Update form button UI/UX and support text wrapping

  Dean Herbert · 2026-01-14 19:47:50 +09:00
  91718447db
• Introduce and use constants and classes for new settings overlay
  Salman Alshamrani · 2026-01-14 02:15:07 -05:00
  7ea1bbf91e
• Improve form dropdown UX (#36325)

  Addresses concerns in
  https://github.com/ppy/osu/pull/36193#issuecomment-3728177951 (excluding
  the last part, that is too involved and I can't imagine any workaround
  for it due to how strict the `Dropdown` structure is). Also adds
  truncation/padding to header label and search bar.
  
  Preview:
  
  
  https://github.com/user-attachments/assets/8885cb90-44dc-42ee-af21-cb33f7723e63

  Salman Alshamrani · 2026-01-13 16:20:03 +09:00
  f892d5fbaa
• Add visual test
  Salman Alshamrani · 2026-01-12 23:38:17 -05:00
  df1304af9e
• Add test cases requiring text wrapping
  Salman Alshamrani · 2026-01-05 16:13:37 -05:00
  4f2dfccb0f
• Fix tests not having colour providers
  Salman Alshamrani · 2025-12-23 05:58:57 -05:00
  a3a5b2ca92
• Use switch button for form checkbox controls
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  339aad42a7
• Add extra form controls in test scene
  Salman Alshamrani · 2025-12-23 05:56:17 -05:00
  c6a8d9a150
• Add another failing test
  Bartłomiej Dach · 2025-12-22 10:04:18 +01:00
  daaea093f0
• Add failing test
  Bartłomiej Dach · 2025-12-19 12:17:06 +01:00
  32454caaa9
• Merge branch 'master' into custom-sample-set-selection
  Dean Herbert · 2025-12-17 19:30:24 +09:00
  61bf68f336
• Add double-click-nub-to-reset function to form slider bars

  See https://github.com/ppy/osu/pull/35742#issuecomment-3561517030.

  Bartłomiej Dach · 2025-11-24 10:32:42 +01:00
  9d88c761d3
• Fix tests
  Bartłomiej Dach · 2025-11-20 10:12:43 +01:00
  47faf774b0
• Use new sliders-with-text-input in editor toolboxes

  Addresses https://github.com/ppy/osu/discussions/35732.
  
  And yes, I renamed "perfect curve threshold" to "bias" so that the text
  can fit. Sue me.

  Bartłomiej Dach · 2025-11-19 13:22:20 +01:00
  4b59a4657f
• Add failing drawable date seconds update test
  Joseph Madamba · 2025-10-28 19:39:07 -07:00
  9a965a2546
• Make bank selection controls dropdowns instead of text boxes

  Longstanding complaint. Text boxes make no sense if anything that isn't
  the three legacy values gets deleted on save anyway.

  Bartłomiej Dach · 2025-10-24 11:52:45 +02:00
  1f2f86b016
• Extract all pieces of local user-related state to APIAccess subcomponent

  Something I've asked to be done for a long time. Relevant because I've
  complained about this on every addition of a new piece of user-local
  state: friends, blocks, and now favourite beatmaps.
  
  It's just so messy managing all this inside `APIAccess` next to
  everything else, IMO.

  Bartłomiej Dach · 2025-10-23 10:53:58 +02:00
  5eda9a0fd7
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Fix main menu key tests
  Dean Herbert · 2025-09-11 16:09:17 +09:00
  0c68a91b4c
• Split main menu buttons into multiplayer section (#136)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-09-08 13:54:06 +09:00
  449038d070
• Add matchmaking
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  111b98ef8e
• Add test steps to mod icon test scene for exercising all rulesets
  Bartłomiej Dach · 2025-08-21 09:00:46 +02:00
  e47a60f303
• Make UserAvatarNotification abstract since it has no actual usage
  Dean Herbert · 2025-07-29 15:02:18 +09:00
  aa4afa8776
• Merge pull request #33575 from smoogipoo/package-manager-tachyon

  Add Tachyon support for package managed installations

  Dean Herbert · 2025-06-18 19:46:18 +09:00
  b870ac0f03