62006 Commits

This Branch

This Branch

All Branches

• Update framework
  Dean Herbert · 2023-06-25 12:00:14 +09:00
  5806153cfd
• Fix more issues discovered by CI that can be fixed game-side
  Bartłomiej Dach · 2023-06-24 19:04:05 +02:00
  f8d2f2f7e1
• Merge branch 'master' into framework-update
  Bartłomiej Dach · 2023-06-24 18:47:52 +02:00
  d7ae430ec2
• Merge pull request #24021 from peppy/mass-nrt

  Apply NRT to all files where it can be easily applied

  Bartłomiej Dach · 2023-06-24 18:31:32 +02:00
  511451770c
• Update framework
  Dean Herbert · 2023-06-25 00:38:19 +09:00
  ca402c4d2f
• Change OpenUserProfile argument type to always use IUser
  Salman Ahmed · 2023-06-24 18:12:35 +03:00
  9a5f033a0f
• Fix some more missed CI inspections
  Bartłomiej Dach · 2023-06-24 17:11:38 +02:00
  e273c223a8
• Fix wrong disable
  Bartłomiej Dach · 2023-06-24 17:07:42 +02:00
  df2dcf85b4
• Fix nullability-related warnings in Android project
  Bartłomiej Dach · 2023-06-24 17:05:52 +02:00
  34e2540331
• Fix remaining obvious CI inspections
  Bartłomiej Dach · 2023-06-24 16:07:01 +02:00
  e3a89a6273
• Revert nullability enables in tournament client

  Not trivial to fix right now and I'm not fixing in a 1k-line changeset.

  Bartłomiej Dach · 2023-06-24 16:05:19 +02:00
  caf5673b68
• Revert nullability enable in BeatmapBackground

  Due to varying expectations in handling of `Beatmap`. Some places allow
  or expect null and some don't. Needs to be looked at closer separately.

  Bartłomiej Dach · 2023-06-24 15:40:06 +02:00
  2c1a44da89
• Revert nullability enable in Score (and related changes)

  Causes several knock-on inspections in `OsuGame` et al. Probably best
  addressed in a separate pass, because treatment is mixed at best (some
  places nullcheck, some expect non-null).

  Bartłomiej Dach · 2023-06-24 15:35:07 +02:00
  66ef199fa4
• Match field NRT annotation in ctor argument
  Bartłomiej Dach · 2023-06-24 15:17:14 +02:00
  8fdd599b39
• Mark override as null-accepting

  `ModelBackedDrawable<T>.CreateDrawable()` is R#-annotated to accept
  a potentially null model. Apply nullability there too for better reading
  experience.

  Bartłomiej Dach · 2023-06-24 15:07:04 +02:00
  1f2f522a1e
• Trim redundant BDL nullability spec
  Bartłomiej Dach · 2023-06-24 14:35:23 +02:00
  354e85a2e1
• Merge branch 'master' into mass-nrt
  Dean Herbert · 2023-06-24 09:59:15 +09:00
  2bda63c2c8
• Fix a couple of remaining issues
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  58e6b3782b
• Apply required nullability changes
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  3585c3f1d5
• Merge pull request #24009 from peppy/fix-touch-input-controls-floating-fruits

  Change "floating fruits" mod to only apply adjustments to the playfield

  Bartłomiej Dach · 2023-06-23 23:26:20 +02:00
  23aa1752c3
• Merge pull request #23890 from cdwcgt/tournament-chatcolor

  Tint username of team members in tournament chat according to the team colour

  Salman Ahmed · 2023-06-23 23:22:40 +03:00
  318260bbfd
• Fix OpenUserProfile links having multiple argument types
  Salman Ahmed · 2023-06-23 22:38:16 +03:00
  ff17685bc3
• Merge branch 'master' into tournament-chatcolor
  Salman Ahmed · 2023-06-23 22:23:33 +03:00
  c5771912db
• Reword and fix typo
  Salman Ahmed · 2023-06-23 22:20:25 +03:00
  7a771609f9
• Add test coverage for tournament players with profile colours
  Salman Ahmed · 2023-06-23 22:04:29 +03:00
  4a2f259f7e
• Merge branch 'master' into diffcalc-total-scorev1
  Dan Balasescu · 2023-06-24 02:46:15 +09:00
  5fadadc3d0
• Add automated commit to blame ignore revs
  Dean Herbert · 2023-06-24 01:56:38 +09:00
  ad6650cbfa
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Add flag to disable computing legacy scoring values
  Dan Balasescu · 2023-06-24 01:03:18 +09:00
  06565871d6
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix incorrect calculation of difficulty
  Dan Balasescu · 2023-06-24 00:58:45 +09:00
  87447f41d0
• Merge branch 'master' into no-confirmation-on-update-restart
  Dean Herbert · 2023-06-23 15:33:01 +09:00
  1dc7c05c12
• Add test coverage of confirm-for-operations
  Dean Herbert · 2023-06-23 15:30:21 +09:00
  a76037b643
• Show ongoing operations in exit confirmation dialog

  Also changes the button to a dangerous button, forcing user acknowledgement

  Dean Herbert · 2023-06-23 15:20:19 +09:00
  f66b787b12
• Reorganise resolved fields in MainMenu
  Dean Herbert · 2023-06-23 15:19:47 +09:00
  693b7c9906
• Expose all notifications from INotificationOverlay

  Also fixes `HasOngoingOperations` not actually working.

  Dean Herbert · 2023-06-23 15:19:21 +09:00
  7fa07805b0
• Merge pull request #23971 from tybug/comment-logged-out

  Disable posting comments when logged out

  Dean Herbert · 2023-06-23 15:15:27 +09:00
  d86424467e
• Remove unused code
  Dean Herbert · 2023-06-23 14:47:32 +09:00
  20aedc82ac
• Rename ExitConfirmOverlay to be more explicit about purpose
  Dean Herbert · 2023-06-23 14:46:38 +09:00
  6df617d536
• Move confirmation bypass implementation to MainMenu to allow for more correct logic
  Dean Herbert · 2023-06-23 14:42:56 +09:00
  11a97e1bb8
• Change "floating fruits" mod to only apply adjustments to the playfield

  Avoids things like touch screen inputs also being flipped.
  
  Note that these adjustments can't be applied directly to the playfield
  due to how playfields are used in various rulesets (basically relying on
  the `PlayfieldAdjustContainer` to get things in the right place).
  
  Closes #24000.

  Dean Herbert · 2023-06-23 14:18:43 +09:00
  08b3c0cce0
• Add Schedule to ensure correct thread for UI code
  Dean Herbert · 2023-06-23 14:07:33 +09:00
  343271751a
• Bind to API.State instead of API.User
  Dean Herbert · 2023-06-23 14:05:02 +09:00
  ce1579f2fe
• Add note about swells and their ticks
  Dean Herbert · 2023-06-23 14:01:10 +09:00
  d53996336c
• Fix nested logic not being completely correct (favouring already-passed rather than near-future)
  Dean Herbert · 2023-06-23 13:48:13 +09:00
  64b726d5ec
• Merge branch 'master' into comment-logged-out
  Bartłomiej Dach · 2023-06-22 23:19:00 +02:00
  c06b825d9b
• Rename test helpers
  Bartłomiej Dach · 2023-06-22 23:10:16 +02:00
  2c1c20e0a7
• Document why things were done in DummyAPIAccess
  Bartłomiej Dach · 2023-06-22 23:08:30 +02:00
  1672608a87
• Rename and xmldoc members
  Bartłomiej Dach · 2023-06-22 23:00:52 +02:00
  786deec296
• Merge pull request #23999 from peppy/fix-catch-legacy-combo-floating

  Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active

  Bartłomiej Dach · 2023-06-22 22:49:31 +02:00
  361ae15824