62006 Commits

This Branch

This Branch

All Branches

• Merge pull request #23888 from peppy/fix-intro-playing-twice

  Fix music sometimes restarting twice if exiting song select with no beatmap selected

  Bartłomiej Dach · 2023-06-22 22:49:15 +02:00
  0ce4d17e30
• Merge pull request #23974 from peppy/fix-multiplayer-present-beatmap

  Fix presenting beatmaps while in a multiplayer room not working

  Bartłomiej Dach · 2023-06-22 22:48:48 +02:00
  a753c89dea
• Merge pull request #23975 from peppy/skin-editor-beatmap-skin-disable

  Disable beatmap skinning support when entering the skin editor

  Bartłomiej Dach · 2023-06-22 22:45:44 +02:00
  bede12a3e8
• adjust DummyAPIAccess to more closely match APIAccess

  wrt logging in and out

  Liam DeVoe · 2023-06-22 16:01:12 -04:00
  21bed336c6
• Merge branch 'master' into skin-editor-beatmap-skin-disable
  Bartłomiej Dach · 2023-06-22 20:30:51 +02:00
  a11b3a67fb
• Remove unused using directive
  Bartłomiej Dach · 2023-06-22 20:24:44 +02:00
  aea5eb37dc
• Remove redundant parentheses
  Bartłomiej Dach · 2023-06-22 20:02:10 +02:00
  79606317ab
• Merge pull request #23967 from peppy/save-replay-hotkey

  Add hotkey to save replay

  Bartłomiej Dach · 2023-06-22 19:50:57 +02:00
  2b9cbaa4da
• Merge branch 'master' into save-replay-hotkey
  Bartłomiej Dach · 2023-06-22 18:51:30 +02:00
  65d4506ef2
• Merge pull request #23972 from peppy/notifications-during-pause

  Allow notifications while the game is paused (or in break time)

  Bartłomiej Dach · 2023-06-22 18:31:39 +02:00
  28dc5640a3
• Fix combo counter on legacy skins flipping when "Floating Fruits" mod is active

  Closes #23989.

  Dean Herbert · 2023-06-22 18:46:43 +09:00
  4be8eede88
• Fix typo in comment

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-06-22 00:02:02 +09:00
  07a00e8afd
• Allow nullable to fix test usages

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-06-22 00:01:48 +09:00
  7b4cbea362
• Don't require exit confirmation when there are no ongoing operations that could be interrupted
  Dean Herbert · 2023-06-21 19:06:28 +09:00
  59b1f08d53
• Add method to queue a restart after app is exited (when supported)
  Dean Herbert · 2023-06-21 19:06:28 +09:00
  c3f772f0da
• Fix potential null ref in ResultsScreen
  Dean Herbert · 2023-06-21 17:50:06 +09:00
  655491ae2d
• Add FireAndForget to stray Task.Run
  Dean Herbert · 2023-06-21 17:48:55 +09:00
  1907beb0c9
• Improve and combine logic that exists in two classes
  Dean Herbert · 2023-06-21 17:48:12 +09:00
  9ca772421d
• Make IGameplayClock optional in GameplaySampleTriggerSource to ease testing
  Dean Herbert · 2023-06-21 17:33:42 +09:00
  4ff5275208
• Change skin editor flow to always save on toggle

  This also moves the beatmap skin disable toggle to on toggle, in line
  with review feedback.
  
  I've decided to always apply the disable, not just on the `Player`
  screen. It should be assumed that if a user is in the skin editor they
  are never going to need access to this anyway.

  Dean Herbert · 2023-06-21 16:14:47 +09:00
  cb0f642ad7
• Use bindable lease instead of reimplementing the same thing locally
  Dean Herbert · 2023-06-21 16:09:54 +09:00
  366dd96875
• add test for comment when logging in and out
  Liam DeVoe · 2023-06-21 02:17:51 -04:00
  6de7328fef
• fix cancel test for new button layout
  Liam DeVoe · 2023-06-21 02:15:02 -04:00
  dd4f271158
• use two separate buttons for posting / login
  Liam DeVoe · 2023-06-21 00:58:43 -04:00
  cc764afe3e
• move commitButton.Text update to appropriate method
  Liam DeVoe · 2023-06-21 00:37:54 -04:00
  8460873e61
• Fix one remaining seek
  Bartłomiej Dach · 2023-06-20 23:32:38 +02:00
  a7172e7469
• Fix taiko test scene failing due to missing gameplay clock dependency

  `GameplayClock` is inscrutable.
  
  `TestManualClock` is lifted from another test scene because of
  `FramedBeatmapClock`'s intensely confusing tendency to not work if it is
  given a non-adjustable `ManuelClock` instead.

  Bartłomiej Dach · 2023-06-20 23:30:52 +02:00
  29697d4999
• Fix errors in tests due to mismatching NRT annotations
  Bartłomiej Dach · 2023-06-20 21:57:32 +02:00
  2f77675fe7
• Apply NRT to GameplaySampleTriggerSource
  Dean Herbert · 2023-06-20 21:03:55 +09:00
  cb07f2399f
• Update test expectations
  Dean Herbert · 2023-06-20 21:02:34 +09:00
  92e89c7df7
• Use IGameplayClock to ensure our clock source is correct
  Dean Herbert · 2023-06-20 20:47:56 +09:00
  04dad6c6e8
• Fix nested lookups
  Dean Herbert · 2023-06-20 20:45:02 +09:00
  0e86102681
• Add back optimisation and increase time allowance slightly
  Dean Herbert · 2023-06-20 20:30:07 +09:00
  786d5a394b
• Adjust GameplaySampleTriggerSource to only switch samples when close enough to the next hit object

  Closes #23963.
  
  To simplify things, I've removed the optimisation of using
  `AliveObject`s because it would break the way this whole lookup works.

  Dean Herbert · 2023-06-20 20:06:07 +09:00
  555ce7684b
• Disable beatmap skinning when entering the skin editor
  Dean Herbert · 2023-06-20 19:18:17 +09:00
  d7b486e2ac
• Merge pull request #23973 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-06-20 18:53:55 +09:00
  c815f8cd23
• Apply more correct fix for double-playing menu track
  Dean Herbert · 2023-06-20 18:35:51 +09:00
  2e02b4a85b
• Merge branch 'master' into fix-intro-playing-twice
  Dean Herbert · 2023-06-20 18:34:22 +09:00
  0a81170bca
• Don't show song select screen when local user doesn't have permission to add an item
  Dean Herbert · 2023-06-20 18:27:19 +09:00
  10ed3787a0
• Fix presenting beatmaps while in a multiplayer room not working
  Dean Herbert · 2023-06-20 18:23:59 +09:00
  dc1b4a39aa
• Update framework
  Dean Herbert · 2023-06-20 17:43:52 +09:00
  ff8350bac6
• Allow notifications while the game is paused (or in break time)

  RFC. This is to allow notifications to show at the pause screen
  (specifically for #23967, where exports are now happening).
  
  Not sure about the break time part of this, but might be fine? The
  toasts are immediately flushed before break time ends.

  Dean Herbert · 2023-06-20 16:57:35 +09:00
  7b69b92eab
• Also add hotkey to export replays
  Dean Herbert · 2023-06-20 16:54:37 +09:00
  4bd121d3b8
• Fix OsuAnimatedButton not flashing when triggered via code
  Dean Herbert · 2023-06-20 16:34:22 +09:00
  7c5813c05a
• Apply NRT and hotkey support to save replay button at results screen
  Dean Herbert · 2023-06-20 16:29:15 +09:00
  1e0e29847f
• update CommentEditor test components
  Liam DeVoe · 2023-06-19 22:08:45 -04:00
  343052410b
• rename GetTextBoxPlaceholder to GetPlaceholderText
  Liam DeVoe · 2023-06-19 22:05:18 -04:00
  60eedbafd1
• use runOnceImmediately instead of duplicating logic
  Liam DeVoe · 2023-06-19 18:20:16 -04:00
  f7dde53f9b
• extract button text properties to methods, show login overlay on click
  Liam DeVoe · 2023-06-19 18:10:37 -04:00
  591277e0f9
• resolve protected API in comments superclass
  Liam DeVoe · 2023-06-19 17:36:40 -04:00
  d5d494f07b