Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dan Balasescu
968640c951
Enable NRT by default
2022-06-17 16:34:09 +09:00
Dan Balasescu
ea191da496
Merge pull request #18728 from peppy/fix-unsafe-sample-playback
...
Fix unsafe sample playback in `GameplaySampleTriggerSource`
2022-06-17 12:26:46 +09:00
Salman Ahmed
c9a02aafd8
Merge pull request #18739 from bdach/unpin-xamarin-on-ci
...
Revert Xamarin regression workaround in Android CI build definition
2022-06-17 00:10:19 +03:00
Salman Ahmed
8ee6a49ad9
Merge branch 'master' into unpin-xamarin-on-ci
2022-06-16 23:30:07 +03:00
Bartłomiej Dach
b74bb83176
Merge pull request #18737 from frenzibyte/fix-up-down
...
Fix toolbar music button handling keys while not hovered
2022-06-16 22:29:35 +02:00
Bartłomiej Dach
6f2f4dda37
Merge branch 'master' into fix-up-down
2022-06-16 21:44:56 +02:00
Bartłomiej Dach
9141a7a907
Revert Xamarin regression workaround in Android CI build definition
...
This commit is a revert of 53e52d2c4b
2022-06-16 21:03:29 +02:00
Bartłomiej Dach
73ec43338a
Merge pull request #18731 from peppy/database-migration-reliability
...
Fix database migration potentially hard crashing during backup process without informing the user why
2022-06-16 19:53:05 +02:00
Salman Ahmed
e4ddf03ad6
Fix toolbar music button handling keys while not hovered
2022-06-16 20:22:57 +03:00
Salman Ahmed
42378dbb88
Improve test coverage to ensure volume is unaffected when mouse is away
2022-06-16 20:22:57 +03:00
Bartłomiej Dach
651862fee0
Merge branch 'master' into database-migration-reliability
2022-06-16 17:19:58 +02:00
Dean Herbert
bf6c6682bc
Move null to finally
2022-06-16 23:37:24 +09:00
Dean Herbert
7809566f16
Add explanatory comments
2022-06-16 23:31:49 +09:00
Dean Herbert
7b0fad6461
Null disposal token after use
2022-06-16 23:29:33 +09:00
Dean Herbert
c7287556e5
Merge pull request #18695 from frenzibyte/first-run-setup-notification-interruption
...
Silence important notifications during first-run setup
2022-06-16 23:01:43 +09:00
Bartłomiej Dach
9c4f6d2ce0
Merge branch 'master' into first-run-setup-notification-interruption
2022-06-16 15:14:40 +02:00
Bartłomiej Dach
d8657ee9e1
Merge pull request #18734 from peppy/bmm-cleanup-2
...
Remove `RealmArchiveModelManager` from hierarchy
2022-06-16 15:14:06 +02:00
Bartłomiej Dach
c90edf49a7
Merge branch 'master' into bmm-cleanup-2
2022-06-16 13:33:20 +02:00
Bartłomiej Dach
6df4b16a89
Merge pull request #18733 from peppy/bmm-cleanup
...
More model importer clean-ups (delete `BeatmapModelManager`)
2022-06-16 13:32:55 +02:00
Dean Herbert
d48fbdb439
Merge branch 'bmm-cleanup' into bmm-cleanup-2
2022-06-16 19:48:54 +09:00
Dean Herbert
e66ccfd980
Add back missing notification flow
2022-06-16 19:48:18 +09:00
Dean Herbert
448eee051a
Update filename to match new class name
2022-06-16 19:41:14 +09:00
Dean Herbert
3860f0b3e5
Remove unused GetWorkingBetamap method
2022-06-16 19:08:59 +09:00
Dean Herbert
ce3d3a967c
Reimplement missing methods
2022-06-16 19:05:25 +09:00
Bartłomiej Dach
a635664a86
Fix invalid method reference in comment
...
`BeatmapModelManager.Save()` was moved to `BeatmapManager`, not to
`BeatmapImporter`.
2022-06-16 12:01:53 +02:00
Dean Herbert
72c5b9009d
Remove local realm fields in manager classes
2022-06-16 18:56:53 +09:00
Dean Herbert
f3984d98e6
Remove RealmArchiveModelManager from hierarchy
2022-06-16 18:53:13 +09:00
Dean Herbert
8a5755ca52
Remove pointless override in test implementation
2022-06-16 18:27:16 +09:00
Dean Herbert
04e4c5ef88
Move and adjust implementation regions to restore sanity
2022-06-16 18:26:13 +09:00
Dean Herbert
4d9e3d1982
Rename Score/Skin ModelManager classes to Importer for now
2022-06-16 18:11:50 +09:00
Dean Herbert
1f3e1b2d97
Combine BeatmapManager and BeatmapModelManager into one class
2022-06-16 18:07:04 +09:00
Dean Herbert
8ea3042435
Move file extensions specification to common class
2022-06-16 18:00:27 +09:00
Dean Herbert
84dba36cf5
Update usages of BeatmapModelManager which only require importing to use BeatmapImporter
2022-06-16 17:59:24 +09:00
Dean Herbert
4c372539a1
Consolidate remaining methods in BeatmapModelManager
2022-06-16 17:59:24 +09:00
Dean Herbert
251923c106
Convert NotificationOverlay to NRT
2022-06-16 17:28:08 +09:00
Dean Herbert
6b30ee0950
Tidy up DI and binding logic
2022-06-16 17:26:43 +09:00
Dean Herbert
953ca8c2dd
Merge pull request #18715 from bdach/ruleset-mod-hardening
...
Add several protections when creating game-global available mods
2022-06-16 17:18:49 +09:00
Dean Herbert
4526f8c07d
Move database backup creation to async thread where possible
2022-06-16 17:01:17 +09:00
Dean Herbert
17dbb599d1
Don't backup collection database
...
This is no longer required due to recent changes which mean the
collection database will retain beatmap references even if they aren't
loaded locally (see https://github.com/ppy/osu/pull/18619 ).
2022-06-16 16:48:53 +09:00
Dean Herbert
739a696467
Ensure reading of existing databases when making backups doesn't create a file
2022-06-16 16:48:06 +09:00
Dean Herbert
ec53d87c30
Fix unsafe sample playback in GameplaySampleTriggerSource
...
Resolves https://github.com/ppy/osu/issues/18727 .
Added delay from `Schedule` should be minimal as it is always called
from the `Update` thread (input propagation) anyway.
2022-06-16 16:04:57 +09:00
Dean Herbert
1c3cc985bc
Merge pull request #18720 from bdach/twemoji-flags
...
Update flag sizes after switch to twemoji assets
2022-06-16 15:55:05 +09:00
Dean Herbert
0c9f4fc8eb
Merge branch 'master' into twemoji-flags
2022-06-16 15:06:49 +09:00
Dean Herbert
ac554ca51f
Update resources
2022-06-16 15:06:34 +09:00
Dean Herbert
e778c90930
Merge pull request #18723 from smoogipoo/ci-template-tests
...
Run template tests on CI
2022-06-16 15:04:54 +09:00
Dan Balasescu
88376da2cf
Run template tests on CI
2022-06-16 13:47:30 +09:00
Bartłomiej Dach
f88c568c8d
Update flag sizes after switch to twemoji assets
...
The old flags used a size of 150x100, while the new assets based on
twemoji use a size of 150x108. Update existing usages to match this new
aspect ratio better.
2022-06-15 21:45:47 +02:00
Salman Ahmed
e7dcbddbeb
Fix potential null reference
2022-06-15 18:53:49 +03:00
Bartłomiej Dach
1acbb87aa6
Ensure AvailableMods.Value is never null
2022-06-15 17:40:16 +02:00
