1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-30 07:47:35 +08:00
Commit Graph

8625 Commits

Author SHA1 Message Date
ansel
b38cf8c56c Use empty string as default 2023-01-11 02:26:25 +03:00
Bartłomiej Dach
62e12277d8
Rename things yet again 2023-01-10 19:30:01 +01:00
Bartłomiej Dach
502478614a
Merge branch 'master' into user-profile/decouple-from-api-user 2023-01-10 19:13:33 +01:00
Dean Herbert
23a78e6fad Combine commit button enabled handling 2023-01-10 23:59:17 +09:00
ansel
23e4cfb469 Show spinner next to buttons and get rid of EditorCommitButton 2023-01-09 23:37:36 +03:00
Salman Ahmed
dbc19777e0 Move stable import buttons under "debug" section 2023-01-09 21:22:21 +03:00
Bartłomiej Dach
6027e7cc4e
Fix one more missed related symbol 2023-01-09 18:22:49 +01:00
Bartłomiej Dach
0026861bd4
Merge branch 'master' into user-profile/decouple-from-api-user 2023-01-09 17:47:59 +01:00
Bartłomiej Dach
4dec3cae57
Rename UserProfileData-related symbols 2023-01-09 17:46:08 +01:00
Bartłomiej Dach
fdf0d4bd62
Rename UserProfile{ -> Data} 2023-01-09 17:37:28 +01:00
Endrik Tombak
44e9fb638c Merge branch 'master' of https://github.com/ppy/osu into songs-folder-check 2023-01-09 14:53:40 +02:00
Endrik Tombak
f5c8ba420c Revert message change 2023-01-09 14:53:16 +02:00
Dean Herbert
07dae7dc21 Merge branch 'master' into overlay-panels-context-menu 2023-01-09 19:04:56 +09:00
Endrik Tombak
15eebd1f50 Only show message about Songs folder 2023-01-09 11:47:13 +02:00
Dean Herbert
13b00928c8 Rename loading spinner bool to reflect that it has a setter 2023-01-09 15:52:18 +09:00
Dean Herbert
d2f4ffcc5b Merge branch 'master' into comment-editor-1 2023-01-09 15:52:17 +09:00
Joseph Madamba
f6b1dfc7b0 Fix channel listing items overflowing at high ui scaling 2023-01-08 13:27:10 -08:00
Joseph Madamba
0f6735564e Move and rename nomination response model to singular 2023-01-07 10:54:48 -08:00
ansel
927773d565 Display submitted comments locally 2023-01-07 04:15:43 +03:00
ansel
32e90829e3 Integrate comment editor into container 2023-01-07 02:59:24 +03:00
ansel
387326db0d Make commit action abstract 2023-01-06 22:51:57 +03:00
Joseph Madamba
7f970f3cd8 Display nominators on beatmap set overlay 2023-01-06 11:33:39 -08:00
Salman Ahmed
3862184f9c
Merge branch 'master' into improve-filter-tab-item-ux 2023-01-06 15:37:21 +03:00
Salman Ahmed
0ade4d92d1 Fix multiple highlighting issues with beatmap listing tab items 2023-01-06 15:13:31 +03:00
Salman Ahmed
3d053ac758
Merge branch 'master' into filter-tab-item-bold 2023-01-06 15:11:57 +03:00
Dean Herbert
0ab1418aa6
Merge pull request #22034 from frenzibyte/fix-toolbox-group-animation
Fix settings toolbox group not animating on expansion
2023-01-06 19:59:31 +08:00
Dean Herbert
4319937bc7 Also add an underline to better accent current filters 2023-01-06 20:36:10 +09:00
Dean Herbert
3c74d27deb Also add an underline to better accent current filters 2023-01-06 20:35:58 +09:00
Dean Herbert
458fe382ed Make selected tab items more bold 2023-01-06 20:06:41 +09:00
Dean Herbert
464f251c0c
Merge branch 'master' into beatmap-set-link-genre-language 2023-01-06 17:09:06 +08:00
Salman Ahmed
7d8aff8f7e Fix settings toolbox group not animating on expansion 2023-01-05 14:35:57 +03:00
Bartłomiej Dach
a124c967df
Add proper offline & loading state handling to user profile overlay 2023-01-02 17:23:09 +01:00
Bartłomiej Dach
c759b743dc
Add support for switching rulesets on profile overlay 2023-01-02 17:23:06 +01:00
Bartłomiej Dach
a2e726502f
Add ruleset selector to profile overlay 2023-01-02 17:23:04 +01:00
Bartłomiej Dach
7683ab68b0
Use UserProfile in profile ruleset selector 2023-01-02 17:23:01 +01:00
Bartłomiej Dach
1722f3a125
Add ruleset to UserProfile 2023-01-02 17:22:55 +01:00
Bartłomiej Dach
4dd7727f71
Remove test-specific workaround in overlay 2023-01-02 17:21:14 +01:00
Bartłomiej Dach
d7294ac3e6
Substitute APIUser for UserProfile in overlay 2023-01-02 17:21:09 +01:00
Bartłomiej Dach
608d8ee7d4
Add UserProfile model to be used in user profile overlay
As `APIUser` implements `IEquatable`, attempting to replace an `APIUser`
with another `APIUser` with the same online ID has no effect on the user
profile overlay. This is a significant hurdle in implementing support
for viewing the profile for different rulesets, as in that case the
profile is basically reloaded for the same user, but slightly different
data.

To facilitate this, wrap `APIUser` in a new `UserProfile` class. This
will mean that the equality rules can be changed locally to the user
profile overlay without impacting other components that depend on the
`APIUser` equality rules. The ruleset that the user profile is being
displayed with will eventually be added to `UserProfile`, too.
2023-01-02 17:21:00 +01:00
Bartłomiej Dach
88e90d5fa0
Enable NRT in user profile overlay 2023-01-01 23:49:11 +01:00
Bartłomiej Dach
2698d58c46
Merge branch 'master' into remember-chat-textbox-per-channel 2023-01-01 17:29:38 +01:00
Dean Herbert
9a4f0cad2c Fix incorrect domain root being used for recent activity entries on profile overlay
Closes https://github.com/ppy/osu/issues/21980.
2023-01-01 17:48:05 +08:00
Dean Herbert
87250ad847 Add search keywords for beatmap colours / hitsound overrides 2023-01-01 14:32:28 +08:00
Bartłomiej Dach
0d70f2c0fd
Use alternative workaround 2022-12-30 09:08:17 +01:00
Bartłomiej Dach
f625c5d744
Fix gradient showing when toggling toolbar with mouse above window 2022-12-29 23:35:45 +01:00
Bartłomiej Dach
bf975eb48a
Fix toolbar gradient not showing when mouse is hovered over buttons 2022-12-29 23:03:53 +01:00
Dean Herbert
ccf713c885 Fix incorrect hard link validity check in stable import screen 2022-12-29 23:18:12 +08:00
Dean Herbert
f9f6918fc3
Merge branch 'master' into add_linux_hardlink 2022-12-29 21:29:57 +08:00
Bartłomiej Dach
c5f7da9a4e
Fix hover propagating through toolbar buttons
Closes #21920.

Weirdly enough this was semeingly fixed once before in ancient times in
3891f467a3, but then unfixed again in
566e09083f. The second change is no longer
needed since the toolbar became opaque in #9447.
2022-12-29 13:19:14 +01:00
Joseph Madamba
c326745f96 Save / sync chat text box messages per channel 2022-12-28 16:09:40 -08:00
Joseph Madamba
b40d114e76 Remove context menu from news card for now 2022-12-28 15:00:57 -08:00
Bartłomiej Dach
10c11e974d
Fix broken spacing 2022-12-28 22:24:21 +01:00
Bartłomiej Dach
49b0ec9ddb
Fix broken condition 2022-12-28 22:24:18 +01:00
Bartłomiej Dach
d4b3965967
Change warning message about file duplication
- It was being glued in an ugly way that would have prevented sanely
  localising it.

- Even on Linux, the filesystem (whichever one the user has chosen out
  of the multitude available) still needs to support hard links for them
  to have a chance of working.
2022-12-28 22:04:08 +01:00
BlauFx
d63be3ff17 Change name of variable 2022-12-28 15:02:44 +01:00
BlauFx
f32564652b Mention the filesystem should be NTFS on Windows 2022-12-28 14:33:38 +01:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1 2022-12-28 17:46:01 +05:00
BlauFx
b2aa2e1602 Add hardlink support for Linux 2022-12-28 13:32:49 +01:00
Salman Ahmed
b4c5e18da0 Add keywords to ease search of "first object visibility" setting 2022-12-28 13:23:50 +03:00
Dean Herbert
61029b126d Add link to hard link explanation wiki page 2022-12-27 17:56:23 +08:00
Joseph Madamba
bb58976838 Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu 2022-12-26 17:54:15 -08:00
Joseph Madamba
8bc8b0d0af Remove redundant context menu container 2022-12-26 15:38:07 -08:00
Joseph Madamba
84e3858a86 Move context menu / popover container one level to account for header 2022-12-26 15:37:46 -08:00
Berkan Diler
c7ca4bbba5 Use generic Enum methods 2022-12-26 20:36:39 +01:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection 2022-12-26 05:17:40 +03:00
Joseph Madamba
973fd90af2 Fix parameters with the same default value inspection 2022-12-25 16:15:02 -08:00
Joseph Madamba
f959b02dc8 Use empty drawables for spacing badges instead 2022-12-25 16:05:59 -08:00
Joseph Madamba
b9dfb8b602 Add localisation for context menu strings 2022-12-25 10:12:02 -08:00
Joseph Madamba
2c2f347e25 Add context menus to overlay panels/cards 2022-12-25 09:57:42 -08:00
Joseph Madamba
b871d6f078 Remove unused fields 2022-12-24 13:35:17 -08:00
Joseph Madamba
ae967e08b0 Add badges when needed instead of using alpha 2022-12-24 13:27:46 -08:00
Joseph Madamba
4f6b3644f3 Fix title/artist overflowing to right side 2022-12-24 12:40:32 -08:00
Joseph Madamba
df645ef3cb Change title/artist idle colour to white 2022-12-24 11:42:05 -08:00
Joseph Madamba
9d073f4228 Link beatmap set title and artist to listing search 2022-12-24 11:26:09 -08:00
Bartłomiej Dach
301eb71e22
Fix wrong member names 2022-12-24 10:39:05 +01:00
Dean Herbert
2c060ac8d4 Add localisation support for new button's strings 2022-12-24 17:32:04 +08:00
Dean Herbert
91bde14fb3 Add button to settings to show lazer upgrade guide 2022-12-24 15:42:24 +08:00
Joseph Madamba
2dbcf05fe4 Use enum values as ids in fallback instead 2022-12-23 11:13:27 -08:00
Joseph Madamba
494886ef92 Rename Text to Metadata 2022-12-23 11:11:15 -08:00
Bartłomiej Dach
9a2cc04361
Fix wrong path being used in fail handler 2022-12-23 16:44:03 +01:00
Dean Herbert
a677c8be06 Change path on error 2022-12-23 21:17:42 +08:00
Dean Herbert
5eccafe190 Fix wiki overlay showing error message when load is cancelled 2022-12-23 16:45:40 +08:00
Berkan Diler
08d2fbeb8e Use new ArgumentNullException.ThrowIfNull throw-helper API 2022-12-22 21:27:59 +01:00
Salman Ahmed
28fc2f34b5
Merge branch 'master' into restore-default-button-hit-area 2022-12-22 13:32:57 +03:00
Joseph Madamba
e1e6d76f30 Check id for genre/language instead and fallback to name if not defined 2022-12-21 11:02:04 -08:00
Bartłomiej Dach
3ec31a5f51
Fix language selector in first run dialog not updating after changing language in settings 2022-12-21 19:30:21 +01:00
Joseph Madamba
1d39e8d0ce Refactor MetadataSection to use generics and inheritance 2022-12-21 10:18:47 -08:00
Dean Herbert
19f66c806e Fix language dropdown in settings not updating after changing language in first run dialog
Closes #21744.
2022-12-21 16:31:55 +08:00
Bartłomiej Dach
cebd5f6dc2
Fix restore default button having a minuscule hit area
Another casualty of edc78205d5. This
particular button was actually *relying* on receiving positional events
from its entire bounding box rather than `Content`, in order for the
button to be htitable more easily, which broke as other buttons were
fixed to behave more in line with expectations.

Upon closer inspection this is another case of a weird carried-over
construction. The button doesn't really need to inherit `OsuButton` or
do any of the arcane stuff that it was doing, so it's now a plain
`OsuClickableContainer` with less `Content` hackery.
2022-12-20 20:47:58 +01:00
Bartłomiej Dach
378486cbe0
Merge branch 'master' into argon-pro-skin 2022-12-20 19:34:56 +01:00
Bartłomiej Dach
bf074adb13
Remove unused using directive 2022-12-20 18:24:26 +01:00
Bartłomiej Dach
8ead606065
Merge branch 'master' into ui-scale-only-show-one-screen 2022-12-20 18:23:37 +01:00
Dean Herbert
2f0c772dcb
Add argon pro skin 2022-12-20 21:18:51 +09:00
wiskerz76
439b8ac56a Fix file select popup getting stuck when switching first run screens while selecting
Closes #21663
Supersedes #21724
2022-12-20 17:59:23 +09:00
Dean Herbert
c119d41a2d Only show song select for now at ui scale adjust first run screen
Having both was a bit too much. Still not happy with this but it's a bit
less sensory overload.

I think while it's cool being able to show nested screens like this, it
needs more thought to actually be a good experience.
2022-12-20 17:52:56 +09:00
Joseph Madamba
01f09529a8 Link beatmap set genre and language to listing filters 2022-12-19 22:54:33 -08:00
Bartłomiej Dach
64a45aa0e0
Merge branch 'master' into wiki-heading-id-attributes 2022-12-20 06:34:47 +01:00
Bartłomiej Dach
7c282d9def
Enable generic attribute support for wiki markdown containers 2022-12-19 21:32:38 +01:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management 2022-12-19 20:19:51 +01:00
Bartłomiej Dach
186ccc64fd
Fix welcome screen language buttons not working 2022-12-19 18:19:26 +01:00
Dean Herbert
b64a5cbda6 Merge branch 'master' into guard-url-protocols 2022-12-19 15:46:45 +09:00
Joseph Madamba
6e62033bc4 Fix some comment actions not being lowercased 2022-12-18 20:20:15 -08:00
Dean Herbert
ba54551313 Merge branch 'master' into guard-url-protocols 2022-12-16 18:23:16 +09:00
Dean Herbert
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
Dan Balasescu
cbee72897a
Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times
Use `LocalisableString`s for date and time formats
2022-12-16 16:17:14 +09:00
Dean Herbert
232f590ba3
Merge pull request #21628 from peppy/go-hard-file-writes
Use hard links on windows when importing beatmaps from a legacy osu! install
2022-12-16 14:52:57 +09:00
Susko3
0f34d908c7 Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
Dean Herbert
9813bc9544 Reword disclaimer and fix translation keys 2022-12-15 22:46:31 +09:00
Dean Herbert
d2b98b803d Turn on featured artist filter by default and add disclaimer when toggling for the first time 2022-12-15 18:42:47 +09:00
Dean Herbert
0763b86236 Add more padding around text in dialog popups 2022-12-15 17:32:27 +09:00
Dean Herbert
78bc94d3cb Set featured artists filter to enabled by default 2022-12-15 16:57:39 +09:00
Dean Herbert
a7f3e13946 Fix MultipleSelectionFilter not correctly handling initial selection 2022-12-15 16:56:09 +09:00
Dean Herbert
f4316a9827
Fix incorrect grammar in hard link explanation text
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-12-14 11:30:01 +09:00
Dean Herbert
b8904fe747 Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
Dean Herbert
cb16d62700 Hook up ImportParameter flow with IModelImporter caller methods 2022-12-13 21:29:32 +09:00
Andrei Zavatski
15bd82add8 Fix DrawableUsername being affected 2022-12-12 18:24:49 +03:00
Dean Herbert
02b3bbf0d3
Merge pull request #21616 from Joehuu/changelog-build-masking
Fix changelog single build dates disappearing before being off screen
2022-12-12 18:28:48 +09:00
Dean Herbert
05b5949810 Use explicit casts 2022-12-12 17:38:39 +09:00
Dean Herbert
e2d8909e73 Add link to change folder location if it isn't on the same drive as import path 2022-12-12 13:44:09 +09:00
Dean Herbert
726943cb14 Add information attempting to explain hard links to the end user 2022-12-12 13:44:09 +09:00
Dean Herbert
d8de99bbe4 Check for hard link support in first run overlay 2022-12-12 13:44:09 +09:00
Dean Herbert
731184eb39 Revert "Merge pull request #21614 from EVAST9919/button-fix"
This reverts commit 4bd196684f, reversing
changes made to a1d22ef77a.
2022-12-12 13:43:01 +09:00
Joseph Madamba
e76c56b03b Fix changelog single build dates disappearing before being off screen 2022-12-11 20:10:06 -08:00
Andrei Zavatski
1332568796 Fix SettingsButton receiving input at padded area 2022-12-12 03:10:13 +03:00
Bartłomiej Dach
5857471915
Merge branch 'master' into nominated-ranked-beatmaps 2022-12-07 23:54:25 +01:00
Dean Herbert
62b0436bcf Reverse depth of profile sections to allow for overflowing expanded beatmap cards
Closes #21554.
2022-12-07 16:38:17 +09:00
Joseph Madamba
56e94e49a3 Display nominated ranked beatmaps in user profile 2022-12-06 23:36:11 -08:00
Dean Herbert
49f5ac57b8 Fix first run beatmap screen button colours looking incorrect with new triangle effect
Addresses #21500.
2022-12-03 18:48:54 +09:00
ansel
1763618488 Fix spinner presense check & field click 2022-11-30 13:58:03 +03:00
ansel
43628903a7 Make spinner bigger 2022-11-30 13:57:09 +03:00
ansel
1cc7ffce39 Keep button's text 2022-11-30 13:40:47 +03:00
ansel
bedc771e99 Remove useless check 2022-11-30 13:32:01 +03:00
ansel
a8422961dc Rename button spinner prop again 2022-11-30 13:30:57 +03:00
ansel
5ea824534b Use default button 2022-11-30 13:25:59 +03:00
ansel
642e0ac718 Increase footer height to look better with default buttons 2022-11-30 13:25:18 +03:00
ansel
956acbc86f Use fixed width 2022-11-30 13:11:54 +03:00
Dean Herbert
4a747182b4 Merge branch 'master' into comment-editor-1 2022-11-30 17:22:59 +09:00
Dean Herbert
f7b7b58718 Adjust colour and tween to feel better 2022-11-30 16:20:01 +09:00
Dean Herbert
24ee363563 Only hover when hovering actual text 2022-11-30 16:18:36 +09:00
Dean Herbert
80b0e4a99d Rename Colour to avoid conflict with Drawable.Colour 2022-11-30 16:15:50 +09:00
Dean Herbert
7fca5ee28d Move DrawableUsername into own file
It's too large at this point to be a nested class.
2022-11-30 16:15:50 +09:00
Dean Herbert
6524914dbd Merge branch 'master' into chat-profile-highlight-v2 2022-11-30 16:00:52 +09:00
ansel
e30d97c94e Comments 2022-11-29 14:39:59 +03:00
ansel
84aaf5fedf Change ways to access submit button state 2022-11-29 14:37:35 +03:00
ansel
6c126f5223 Remove useless local actions on click 2022-11-29 14:25:51 +03:00
Dean Herbert
61c702c02e Add new IDependencyInjectionCandidate interface to non-drawable cached classes 2022-11-29 14:45:26 +09:00
Bartłomiej Dach
8f78d6179b Fix multiple issues with settings items unhiding on search 2022-11-29 14:41:49 +09:00
Bartłomiej Dach
24deb5f5f4 Remove all unnecessary usage of IHasFilterableChildren 2022-11-29 14:40:52 +09:00
ansel
16962d9a57 Localize deleted string 2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c Localize actions 2022-11-29 07:01:52 +03:00