8974 Commits

• Merge branch 'master' into more-ui-sfx
  Dean Herbert · 2021-06-18 23:24:19 +09:00
  b1fd812805
• replace 'songselect' hover/click sounds with 'button' ones for now
  Jamie Taylor · 2021-06-18 21:03:46 +09:00
  6e4fc26e16
• Move xmldoc to method
  Dean Herbert · 2021-06-18 16:50:31 +09:00
  0bc68a7018
• Reorder methods to make more sense
  Dean Herbert · 2021-06-18 16:46:40 +09:00
  19507e107e
• Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor
  Dean Herbert · 2021-06-18 16:45:01 +09:00
  a7f40dc6d4
• Remove the synchronous version of PrepareScoreForResults

  Replaces all existing usages with the `async` version.

  Dean Herbert · 2021-06-18 16:24:08 +09:00
  45122594e5
• Add note about delay parameter
  Dean Herbert · 2021-06-18 16:18:20 +09:00
  f3426e38b4
• Remove exit override behaviour

  I don't actually know under what scenario this could have been hit, and
  actually caused expected behaviour. Consider that in the scenario I
  describe in the comment (which I added yesterday), the user is
  requesting a pause or exit which would be "cancelled showing the results
  instead". But in such a scenario, `PerformExit` would first be run,
  which cancels the `resultsDisplayDelegate` in the first place.
  
  The only special case would be pressing the close button on the window
  decoration? Which I don't think should be a special case in the first
  place, so I'm just going to remove this for the time being to keep
  things simple.

  Dean Herbert · 2021-06-18 16:12:35 +09:00
  3819a1f03b
• Remove unnecessary (and no longer correct) exception
  Dean Herbert · 2021-06-18 16:08:31 +09:00
  7ef8eac773
• Move all storyboard outro skip logic out of updateCompletionState

  This method should only be called to trigger the score completion
  portion of player progression. The storyboard skip/end logic is now
  handled separately in `progressToResults`.

  Dean Herbert · 2021-06-18 15:50:43 +09:00
  2bf855fcca
• Move score preparations back below ShowResults check
  Bartłomiej Dach · 2021-06-17 19:04:52 +02:00
  f282326f9a
• Fix malformed xmldoc tag

  Oops. Made a typo in the PR suggestion.

  Bartłomiej Dach · 2021-06-17 19:02:56 +02:00
  3a1444e75d
• Apply suggestions from code review

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-06-18 01:07:54 +09:00
  9facfe8964
• Merge branch 'master' into player-completion-refactoring
  Dean Herbert · 2021-06-17 23:51:42 +09:00
  e0a3696145
• Merge branch 'master' into player-pause-exit-results-flow-refactoring
  Bartłomiej Dach · 2021-06-17 16:05:09 +02:00
  aae2923e14
• Reword comments slightly
  Bartłomiej Dach · 2021-06-17 16:04:58 +02:00
  10b0d066be
• Use xmldoc-specific syntax for nicer formatting
  Bartłomiej Dach · 2021-06-17 15:26:50 +02:00
  561dbea9e1
• Refactor and redocument updateCompletionState() and surrounding methods
  Dean Herbert · 2021-06-17 19:13:53 +09:00
  d03c6da60c
• Remove special casing for user exit during storyboard outro
  Dean Herbert · 2021-06-17 18:11:15 +09:00
  246ab41cc6
• Rewrite xmldoc and inline comments for PerformExit
  Dean Herbert · 2021-06-17 18:10:59 +09:00
  7cbebe6d11
• Consume new behaviour to fix UserTile discrepancy

  Closes https://github.com/ppy/osu/issues/13522.

  Dean Herbert · 2021-06-17 16:31:12 +09:00
  808b2baa41
• Fix potential null ref when no beatmap is selected
  Dean Herbert · 2021-06-14 15:06:24 +09:00
  83402a70db
• Avoid refresh if score is not related to current display
  Dean Herbert · 2021-06-14 14:28:14 +09:00
  f8b09b7c81
• Debounce schedule at base class
  Dean Herbert · 2021-06-14 14:26:40 +09:00
  fc442713bb
• Add support for song select leaderboard to handle newly imported scores
  Dean Herbert · 2021-06-14 14:20:23 +09:00
  8dd48d48f6
• Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring

  Show osu!taiko centre/rim colouring in editor timeline

  Dean Herbert · 2021-06-11 15:10:24 +09:00
  04413f1634
• Merge pull request #13438 from bdach/more-metadata-fields

  Add remaining metadata fields to editor setup screen

  Dan Balasescu · 2021-06-11 14:17:34 +09:00
  97375d9625
• Show osu!taiko centre/rim colouring in editor timeline

  Closes #13443.

  Dean Herbert · 2021-06-11 14:17:30 +09:00
  bc3b7233ab
• Merge branch 'master' into more-metadata-fields
  Bartłomiej Dach · 2021-06-11 06:35:51 +02:00
  7fd26ff3b0
• Give more space for time values to allow for negative offsets
  Dean Herbert · 2021-06-11 13:25:09 +09:00
  38bf04d7ff
• Add test coverage for romanised data transfer
  Bartłomiej Dach · 2021-06-10 22:18:39 +02:00
  417aaacc53
• Add romanised author & title fields
  Bartłomiej Dach · 2021-06-10 22:17:45 +02:00
  e41a5a0fcd
• Add star keyword to FilterQueryParser criteria
  ilsubyeega-desu · 2021-06-11 02:46:29 +09:00
  f65f074131
• Add source and tags text boxes to metadata section
  Bartłomiej Dach · 2021-06-10 14:13:59 +02:00
  252fe0a6cc
• Split common method for metadata textbox creation
  Bartłomiej Dach · 2021-06-10 13:55:34 +02:00
  5a2e710095
• Merge pull request #13330 from nekodex/results-screen-sfx

  Add sound effects to the results screen

  Dean Herbert · 2021-06-10 18:27:17 +09:00
  4a4a561ca4
• Remove unused resolved skin
  Dean Herbert · 2021-06-10 17:30:04 +09:00
  0667354fbd
• Combine cases which return the same value
  Dean Herbert · 2021-06-10 17:29:36 +09:00
  4f8000a574
• Merge branch 'master' into results-screen-sfx
  Dean Herbert · 2021-06-10 17:25:35 +09:00
  5e80f454ce
• Merge branch 'master' into no-unranked-display
  Dan Balasescu · 2021-06-10 17:09:46 +09:00
  a44fd887ee
• Fix background being dimmed forever after toggling statistics in results screen
  Joseph Madamba · 2021-06-09 23:26:57 -07:00
  cc38556f61
• Merge pull request #13384 from bdach/fixed-label-width

  Align label widths of editor setup screen controls

  Dean Herbert · 2021-06-10 14:55:49 +09:00
  9a3ca09501
• Remove unused using statement
  Dean Herbert · 2021-06-10 12:37:56 +09:00
  209d217024
• Merge branch 'master' into results-screen-sfx
  Dean Herbert · 2021-06-10 11:28:35 +09:00
  3d508f9266
• Add ability to navigate score panels with left/right arrows
  Joseph Madamba · 2021-06-09 17:03:46 -07:00
  e3f3c37953
• Merge branch 'master' into fix-results-exit-transition
  Bartłomiej Dach · 2021-06-09 19:40:56 +02:00
  89cdea8123
• Merge pull request #13381 from smoogipoo/improve-hit-error-judgements

  Improve hit error judgement displays

  Dean Herbert · 2021-06-09 19:40:17 +09:00
  b02b8ae2bc
• Fix wrong naming scheme for applause samples
  Dean Herbert · 2021-06-09 19:35:05 +09:00
  31b46afa71
• Simplify tick calculation/playback method
  Dean Herbert · 2021-06-09 19:31:53 +09:00
  7d86dafd4f
• Move consts closer to usage
  Dean Herbert · 2021-06-09 19:24:35 +09:00
  57bc34f224