7280 Commits

Author	SHA1	Message	Date
Dean Herbert	f6f24220c2	Fix LegacyScoreDecoderTest incorrectly comparing unset beatmap IDs ... This has been wrong from the outside, but hidden by the fact that the default values are equal. I've changed to MD5Hash which actually asserts that the correct beatmap has likely arrived. Found this in my realm changes, where it fails due to the beatmap ID being a differing Guid in each case.	2022-01-08 15:28:13 +09:00
Bartłomiej Dach	66613cbaa4	Wait for async continuation in score submission test ... The previous assert step was optimistically assuming that the async continuation that writes the value of `FakeImportingPlayer.ImportedScore` always completes before it, but that's not necessarily true even if the continuation is instant (it is still subject to things like task scheduling and TPL thread pool limits). To ensure no spurious failures, swap out the assert step for an until step instead.	2022-01-06 13:09:25 +01:00
Bartłomiej Dach	84765b99b3	Handle score submission request in submission test scene ... Was previously not handled at all, therefore displaying request failures in the test log output. While that was mostly a red herring and shouldn't have caused any actual *test* failures, it is still better to handle this explicitly in a realistic manner.	2022-01-06 12:57:26 +01:00
Dean Herbert	5ed69338a6	Add omission of pages when there are too many	2022-01-04 19:05:14 +09:00
Dean Herbert	86f72b71b1	Prepare tests and general structure to support omission of pages	2022-01-04 18:46:44 +09:00
Dean Herbert	5a11ee7810	Use OverlayColourProvider and fix font weight	2022-01-04 18:14:42 +09:00
Dean Herbert	d10b8c79b3	Remove pointless test coverage of DrawablePage	2022-01-04 17:53:24 +09:00
Dean Herbert	ee4f5c0e79	Rename button classes to make more sense	2022-01-04 17:52:40 +09:00
Dean Herbert	1c899e4402	Fix post-merge issues	2022-01-04 16:46:42 +09:00
Dean Herbert	69e7ee0f48	Merge branch 'master' into page-selector	2022-01-04 16:44:22 +09:00
Dean Herbert	f6b1405fa0	Merge branch 'master' into fix-listing-terminal-breakage	2022-01-04 11:49:02 +09:00
Bartłomiej Dach	7cdba2f7c3	Add test coverage of score submission if player is exited during import	2022-01-03 22:00:47 +01:00
Bartłomiej Dach	2660f41339	Add failing test case for old cards not expiring correctly	2022-01-03 19:28:14 +01:00
Dean Herbert	04d8fd3a58	Improve reliability of TestStoryboardSkipOutro ... Aims to resolve failures as seen at https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true. Have run quite a lot locally with no failures (while removing the skip step 100% fails).	2022-01-01 15:32:39 +09:00
Dean Herbert	f53a675ca3	Fix TestSceneMultiSpectatorLeaderboard not waiting for user population	2021-12-31 00:48:31 +09:00
Joseph Madamba	7de43e3aba	Fix most open compound words in identifiers being closed	2021-12-27 20:26:28 -08:00
Joseph Madamba	98524d60a4	Fix clear identifier typos	2021-12-27 20:26:28 -08:00
Bartłomiej Dach	34b0101ff4	Add visual test coverage of "hidden by ruleset" combo option	2021-12-26 16:49:18 +01:00
Bartłomiej Dach	2b4c2f7ff3	Add failing test for storyboard sample playback with beatmap hitsounds off	2021-12-26 14:25:05 +01:00
Dean Herbert	8ad53138a6	Merge pull request #16234 from smoogipoo/fix-initial-button-colour ... Fix OsuAnimatedButton animating when initially disabled	2021-12-25 15:34:40 +09:00
Dean Herbert	ac1a452e20	Merge pull request #16239 from peppy/sanitise-test-directory-usage ... Fix some more test directory usage weirdness	2021-12-25 12:09:18 +09:00
Dean Herbert	1c0dc204c4	Fix some regressing behaviour due to CleanRunHeadlessGameHost's naming structure changing	2021-12-24 20:24:37 +09:00
Dean Herbert	4b88e257e5	Update usages of CleanRunHeadlessGameHost to match new signature	2021-12-24 20:17:34 +09:00
Dean Herbert	2ee3e61983	Merge branch 'master' into beatmap-card/extra-on-listing	2021-12-24 19:02:51 +09:00
Dan Balasescu	c973739b08	Fix OsuButton event binding + inital-enablement colour	2021-12-24 11:56:12 +09:00
Dan Balasescu	03d159d723	Refactor OsuAnimatedButton test scene	2021-12-24 11:56:12 +09:00
Bartłomiej Dach	5cbaa028eb	Use extracted ruleset config cache implementation in DI	2021-12-23 19:02:10 +01:00
Bartłomiej Dach	27c5cc5bd8	Add testing for beatmap card size switching	2021-12-23 15:55:51 +01:00
Bartłomiej Dach	1876617d8e	Implement beatmap card size tab control	2021-12-23 15:55:36 +01:00
Bartłomiej Dach	1040590844	Add cancellation support to game-side IResourceStores	2021-12-23 10:33:17 +01:00
Dean Herbert	d31c9db08b	Adjust testing methodology to improve reliability of mosue wheel volume adjust tests ... There was previously a potential in headless runs for timing discrepancies to cause the volume to never get adjusted. As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.	2021-12-23 13:25:24 +09:00
Dan Balasescu	e1b539fa9e	Merge pull request #16213 from peppy/working-beatmap-live ... Tidy up `WorkingBeatmap`	2021-12-23 13:02:37 +09:00
Bartłomiej Dach	02fa1c21b7	Adjust existing placeholder test to demonstrate failure case	2021-12-22 15:03:20 +01:00
Dean Herbert	f3f491374b	Remove unused load checks	2021-12-22 18:17:00 +09:00
Dean Herbert	967419c9ac	Remove BeatmapSetInfo and Metadata from interface ... There were very few accesses to this, and after realm they should all be done via the `BeatmapInfo`, so let's remove this.	2021-12-22 18:17:00 +09:00
Dean Herbert	ea7d2c06fc	Merge pull request #16206 from peppy/fix-collection-import-test-cleanup ... Fix `ImportCollectionsTest.TestSaveAndReload` not cleaning up before run	2021-12-22 18:16:48 +09:00
Dean Herbert	a866572ca8	Add comment regarding host name choice	2021-12-22 15:44:47 +09:00
Dean Herbert	cfdfe81afb	Merge pull request #16205 from smoogipoo/fix-multiplayer-tests ... Fix multiplayer test failures when checking for parted room	2021-12-22 13:42:05 +09:00
Dean Herbert	f81e32149b	Fix ImportCollectionsTest.TestSaveAndReload not cleaning up before/after run	2021-12-22 13:38:20 +09:00
Dean Herbert	a88800c99a	Merge pull request #16198 from smoogipoo/fix-current-item-before-population ... Fix delete button showing on current item before beatmap retrieval	2021-12-22 13:15:07 +09:00
Dan Balasescu	24c6f8fafa	Fix multiplayer test failures when checking for parted room	2021-12-22 12:55:37 +09:00
Dan Balasescu	ee64ab6383	Fix delete button test failures ... Can be tested by adding a Thread.Sleep() in DrawableRoomPlaylistItem.load().	2021-12-22 09:55:19 +09:00
Bartłomiej Dach	e35a8cab65	Merge branch 'master' into fix-custom-directory-tests	2021-12-21 13:08:27 +01:00
Dean Herbert	df975fb29e	Merge pull request #16181 from dekrain/statics-reset-no-sb ... Split session statics reset method to prevent unloading seasonal backgrounds	2021-12-21 18:52:04 +09:00
Dean Herbert	0bda7892f7	Merge pull request #16197 from bdach/beatmap-card/renames ... Rename beatmap card-related classes	2021-12-21 18:51:34 +09:00
Dean Herbert	4a3a5054fd	Ensure CustomDataDirectoryTest methods use a fresh directory to avoid IO errors ... Resolves test failures like https://github.com/ppy/osu/runs/4592088736?check_suite_focus=true.	2021-12-21 18:42:39 +09:00
Dan Balasescu	e2f8c71081	Fix test	2021-12-21 18:38:31 +09:00
Dan Balasescu	4ba5a939db	Merge pull request #16178 from bdach/lounge-background-screen-correct ... Fix lounge screen showing information sourced from wrong playlist item	2021-12-21 17:36:23 +09:00
Dan Balasescu	a53c67b2ea	Merge pull request #16194 from peppy/fix-results-screen-wait-test ... Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step	2021-12-21 16:56:49 +09:00
Bartłomiej Dach	b6a458a07e	Cover seasonal backgrounds not resetting on inactivity in test	2021-12-21 08:50:25 +01:00