101 Commits

Author	SHA1	Message	Date
Dan Balasescu	136cdcfb29	Merge pull request #29059 from frenzibyte/fix-results-fetching-twice ... Fix results screen fetching scores twice when scrolled to edge	2024-08-05 14:23:47 +09:00
Bartłomiej Dach	09a1fd2cd1	Merge pull request #29057 from frenzibyte/daily-challenge-replay-download-button ... Fix daily challenge not showing a replay button in results screen	2024-07-26 08:03:17 +02:00
Bartłomiej Dach	8dbd4d70ff	Fix crash when toggling extended statistics visibility during results load ... Closes https://github.com/ppy/osu/issues/29066. Initially I fixed this at where the assert is right now: 9790c5a574/osu.Game/Screens/Ranking/ResultsScreen.cs (L333) but because of the weird way that visible state management is done in this screen that made it possible for the extended statistics to be visible *behind* the score panels, without the score panels making way for it. So this is in a way safer, because it prevents the visibility state of the extended statistics from changing in the first place if there is no score selected (yet). This can be also seen in playlists, at least.	2024-07-25 11:45:17 +02:00
Salman Ahmed	615f07d54c	Fix results screen fetching more scores twice	2024-07-25 09:16:09 +03:00
Salman Ahmed	dad8e28446	Fix replay download button not added when no score is selected initially	2024-07-25 07:40:17 +03:00
Bartłomiej Dach	cb49147d1e	Apply NRT to ScorePanelList	2024-05-14 15:19:43 +02:00
Bartłomiej Dach	da953b34a7	Apply nullability annotations to ResultsScreen & inheritors	2024-04-25 10:58:28 +02:00
Dean Herbert	4cffc39dff	Don't require hold for quick exit at results screen	2024-04-20 04:53:31 +08:00
Dean Herbert	f92833b588	Add ability to quick exit from results screen	2024-04-18 12:02:49 +08:00
Dean Herbert	85364d25dc	Merge pull request #27276 from bdach/medals ... Add flow for displaying achieved medals	2024-03-06 12:31:55 +08:00
Bartłomiej Dach	1e53503608	Show user statistics after completing a playlists / multiplayer score	2024-02-22 20:35:50 +01:00
Bartłomiej Dach	0074bdc5a1	Change ResultsScreen constructor boolean params to init-only properties	2024-02-22 20:15:03 +01:00
Bartłomiej Dach	611e3fe76b	Delay medal display when wanting to show results animation	2024-02-20 16:31:31 +01:00
Bartłomiej Dach	eae43f5fd9	Consume SoloStatisticsWatcher updates in toolbar button	2024-02-13 14:28:24 +01:00
Dean Herbert	fb24c66342	Mark ResultsScreen.Score as nullable ... Is nullable in playlist results at very least.	2024-01-29 16:43:26 +09:00
Dean Herbert	eb90ee5415	Add safety in ResultsScreen.Exit to ensure HitEvents are not holding references ... This is a catch-all safety disconnecting `ScoreInfo` from `HitObject`s.	2024-01-29 16:16:17 +09:00
Bartłomiej Dach	9d2c82452c	Revert "simplify the code even more" ... This reverts commit 9bc9db9138.	2024-01-15 18:47:49 +01:00
wooster0	9bc9db9138	simplify the code even more	2024-01-15 20:58:43 +09:00
wooster0	8ad697ff4c	apply some suggestions/corrections	2024-01-09 21:28:46 +09:00
wooster0	2c64db0628	Use already existing message placeholder + localized string	2024-01-04 12:15:48 +09:00
wooster0	0c85fd496f	Don't leave scores screen empty if no scores are present yet ... Addresses https://github.com/ppy/osu/discussions/23787 I originally wanted to set `allowShowingResults` to false if there are no results but because this involves an API request to fetch the scores that would mean all the scores would have to be fetched all at once so that it knows whether to hide or show the "View results" button on a beatmap. Because that would slow things down and be very inefficient, this still allows the user to view the scores screen but if there aren't any scores, it shows a text, which I think is at least for now better than nothing. As for the testing of this, I wasn't sure how to not generate scores only for one specific test so I opted into not using `SetUpSteps` and doing it that way.	2023-12-31 22:42:32 +09:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Nabile Rahmani	b658b0e346	Fix and use score user's IsBot property in results screen animation ... While a mod-created replay did flag itself as performed by a bot, the extension method converting it into a Score did not copy all the generated properties. As noted, it might be preferable for ModCreatedUser to inherit APIUser and forward it as-is to the Score instance. Related to PR #24675	2023-08-29 23:28:50 +02:00
Bartłomiej Dach	f7d5ac9f92	Privatise setter	2023-08-01 18:09:48 +02:00
Dean Herbert	df504e1fc2	Show extended statistics in multiplayer spectator automatically	2023-08-01 20:02:36 +09:00
Dean Herbert	3485b72eaa	Disallow interacting with the global track state in Player and Editor	2023-07-25 20:20:53 +09:00
Dean Herbert	82babbf8fa	Adjust results screen transition tweens to feel better	2023-07-07 17:39:54 +09:00
Dean Herbert	655491ae2d	Fix potential null ref in ResultsScreen	2023-06-21 17:50:06 +09:00
Bartłomiej Dach	600ada46be	Add protected method for customising statistics panel	2022-12-24 14:34:54 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Dean Herbert	6761f869f9	Modify flow to avoid weird bindable and value resetting	2022-08-16 14:17:35 +09:00
Jamie Taylor	6ce8e74e6b	Add panel appearance sounds	2022-07-22 21:03:46 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dean Herbert	832d37b2c2	Update screen transition events to use new event args	2022-04-22 00:52:44 +09:00
Joseph Madamba	a09589f833	Fix score panels sometimes jumping when toggling statistics fast	2021-11-17 23:15:51 -08:00
Dean Herbert	3de8125eac	Update UI cases where repeat should not be handled	2021-11-18 13:13:36 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
smoogipoo	4658577b1d	Factor in total score calculation time in results screen load	2021-09-07 15:19:09 +09:00
Dean Herbert	f9f3339885	Fix vertical offset not being handled correctly during score panel detach process	2021-08-13 16:14:23 +09:00
Dean Herbert	4a4a561ca4	Merge pull request #13330 from nekodex/results-screen-sfx ... Add sound effects to the results screen	2021-06-10 18:27:17 +09:00
Dean Herbert	5e80f454ce	Merge branch 'master' into results-screen-sfx	2021-06-10 17:25:35 +09:00
Dan Balasescu	a44fd887ee	Merge branch 'master' into no-unranked-display	2021-06-10 17:09:46 +09:00
Joseph Madamba	cc38556f61	Fix background being dimmed forever after toggling statistics in results screen	2021-06-09 23:26:57 -07:00
Dean Herbert	209d217024	Remove unused using statement	2021-06-10 12:37:56 +09:00
Dean Herbert	3d508f9266	Merge branch 'master' into results-screen-sfx	2021-06-10 11:28:35 +09:00
Dean Herbert	a65b76bdbf	Add a simple fade to the results screen ... Stops it from immediately disappearing.	2021-06-09 17:19:37 +09:00
Dean Herbert	7b0c5e9d32	Fix results screen changing applied colour to background on exit ... The general rule is that screens should only apply colours and the likes on enter / resume, and leave the outwards transition to whatever screen is coming next.	2021-06-09 17:18:55 +09:00
Bartłomiej Dach	020c63017e	Fix inspectcode issues	2021-06-09 09:21:02 +02:00