Dean Herbert
|
f01c397220
|
Apply nullability
|
2022-07-28 12:12:46 +09:00 |
|
Andrew Hong
|
f097064eea
|
Adjust to reviews
|
2022-07-27 21:52:38 -04:00 |
|
Andrew Hong
|
ac39d3a142
|
"Copied URL" -> "URL copied"
|
2022-07-27 21:52:28 -04:00 |
|
Andrew Hong
|
2d4655f61e
|
Add Toast Notification to Copy URL
|
2022-07-27 02:25:40 -04:00 |
|
Dean Herbert
|
c30e8047ab
|
Merge pull request #19375 from novialriptide/contextmenu-external-beatmap
Add ContextMenu to beatmap external link
|
2022-07-26 19:06:10 +09:00 |
|
Dan Balasescu
|
b47f674ddb
|
Merge pull request #19400 from peppy/button-select-allow-more
Always allow selecting the top-most button using the select binding
|
2022-07-26 18:49:42 +09:00 |
|
Dan Balasescu
|
bc60552694
|
Merge pull request #19402 from peppy/debugger-attached-audio-warning-disable
Don't show audio playback issue notification if debugger is attached
|
2022-07-26 18:49:33 +09:00 |
|
Dan Balasescu
|
8f7dff5c2c
|
Merge pull request #19378 from peppy/beatmap-update-test
Add separate beatmap update flow to handle edge cases better
|
2022-07-26 18:49:20 +09:00 |
|
Dean Herbert
|
e782590b3c
|
Don't show audio playback issue notification if debugger is attached
I've hit this countless times recently when debugging during the startup
procedure.
|
2022-07-26 18:20:46 +09:00 |
|
Dean Herbert
|
9173271900
|
Fix new update pathway not actually being used
|
2022-07-26 17:58:09 +09:00 |
|
Dean Herbert
|
1539fa704b
|
Always allow selecting the top-most button using the select binding
|
2022-07-26 17:46:23 +09:00 |
|
Dean Herbert
|
6ff44ed2c6
|
Merge pull request #19399 from frenzibyte/carousel-order-stability
Maintain sort stability by using carousel item ID as a fallback
|
2022-07-26 17:33:30 +09:00 |
|
Dean Herbert
|
7f75184a01
|
Merge branch 'master' into beatmap-update-test
|
2022-07-26 17:27:36 +09:00 |
|
Dean Herbert
|
ee694c1257
|
Add test coverage of no online ID scenario
|
2022-07-26 17:27:23 +09:00 |
|
Andrew Hong
|
003aec86ae
|
Rearrange sizeaxes
|
2022-07-26 04:27:22 -04:00 |
|
Dean Herbert
|
1221cb1a42
|
Add comprehensive test coverage of update scenarios
|
2022-07-26 17:22:52 +09:00 |
|
Andrew Hong
|
aaf6ec05bb
|
Remove notification upon copy
|
2022-07-26 04:19:54 -04:00 |
|
Salman Ahmed
|
f90604d873
|
Merge pull request #19249 from andy840119/remove-nullable-disable-in-the-mods-for-catch-ruleset
Remove nullable disable annotation in mods for catch ruleset.
|
2022-07-26 11:10:41 +03:00 |
|
Dean Herbert
|
4c22b55ce3
|
Fix incorrect handling if an update is processed with no changes
|
2022-07-26 17:00:28 +09:00 |
|
andy
|
88db835e76
|
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-catch-ruleset
|
2022-07-26 15:37:30 +08:00 |
|
Dan Balasescu
|
28e81b7c32
|
Merge pull request #19392 from peppy/fix-test-leftovers
Avoid leaving left-over files after test run completes
|
2022-07-26 16:33:14 +09:00 |
|
Dean Herbert
|
846291d203
|
Refactor new tests to not suck as much as the old importer tests
|
2022-07-26 16:33:00 +09:00 |
|
Dan Balasescu
|
412d42b907
|
Merge pull request #19393 from peppy/fix-statistics-panel
Avoid potential realm fetch after disposal in `StatisticsPanel`
|
2022-07-26 16:32:59 +09:00 |
|
Salman Ahmed
|
91ffa7007f
|
Improve existing test coverage to cover order changes from other sort modes
|
2022-07-26 10:24:51 +03:00 |
|
Salman Ahmed
|
a4f6f2b9eb
|
Make item ID comparer static
|
2022-07-26 09:55:37 +03:00 |
|
Dean Herbert
|
9939866f7d
|
Revert one more missed change
|
2022-07-26 15:54:10 +09:00 |
|
Dean Herbert
|
8370ca9765
|
Add ImportAsUpdate method to IModelImporter to avoid otehr changes
|
2022-07-26 15:49:04 +09:00 |
|
Salman Ahmed
|
693ac8750c
|
Remove remaining uses of "child" terminology in non-drawable components
|
2022-07-26 09:43:47 +03:00 |
|
Salman Ahmed
|
d7ef4170be
|
Maintain sort stability by using carousel item ID as fallback
|
2022-07-26 09:40:41 +03:00 |
|
Dean Herbert
|
4efe09e7c2
|
Merge pull request #19377 from frenzibyte/fix-timeline-tests
Fix intermittent timeline zoom test failures
|
2022-07-26 15:18:35 +09:00 |
|
Dan Balasescu
|
5345e431cc
|
Merge pull request #19389 from peppy/cursor-with-touch
Add ability to make cursor show even during touch input
|
2022-07-26 15:13:55 +09:00 |
|
Dean Herbert
|
99bdf41717
|
Avoid potential realm fetch after disposal in StatisticsPanel
As seen at https://github.com/ppy/osu/runs/7513799859?check_suite_focus=true.
|
2022-07-26 15:12:23 +09:00 |
|
Dean Herbert
|
ac553d22ea
|
Fix left over resource file which isn't actually imported
|
2022-07-26 15:08:18 +09:00 |
|
Dean Herbert
|
59d3cc52c4
|
Avoid leaving left-over files after test run completes
|
2022-07-26 15:08:18 +09:00 |
|
Dean Herbert
|
7d8a78ef01
|
Move tests to own class
|
2022-07-26 14:53:20 +09:00 |
|
Dan Balasescu
|
1b2158ff04
|
Remove unused method
|
2022-07-26 14:15:59 +09:00 |
|
Dean Herbert
|
ef10145d6f
|
Rename MenuCursorContainer and clean up code
|
2022-07-26 14:11:52 +09:00 |
|
Dean Herbert
|
ee0c67e114
|
Add ability to make cursor show even during touch input
I completely disagree with this from a UX perspective, but it's come up
so often that I figure we should just let users bone themselves.
|
2022-07-26 14:08:00 +09:00 |
|
Dan Balasescu
|
a7598c62ac
|
Merge pull request #19379 from frenzibyte/remove-submittable-score
Remove no longer necessary API score models
|
2022-07-26 14:07:40 +09:00 |
|
Andrew Hong
|
a8e315abf0
|
Refactor
|
2022-07-25 17:16:33 -04:00 |
|
Andrew Hong
|
46c4e78477
|
Add notification and another menuitem
|
2022-07-25 16:59:00 -04:00 |
|
Dean Herbert
|
d41ac36a69
|
Fix scenario where import is expected to be empty
|
2022-07-25 23:59:27 +09:00 |
|
Salman Ahmed
|
e5355f314d
|
Use longer hash string
|
2022-07-25 15:19:32 +03:00 |
|
Dean Herbert
|
9c411c2250
|
Fix test nullability assertions
|
2022-07-25 20:06:37 +09:00 |
|
Dean Herbert
|
8a0c8f5fd8
|
Fix some realm pieces not being cleaned up
|
2022-07-25 19:51:19 +09:00 |
|
Dean Herbert
|
92dd1bcddb
|
Add test coverage of actual update flow
|
2022-07-25 19:51:19 +09:00 |
|
Dean Herbert
|
2e14d8730c
|
Move implementation of updating a beatmap to BeatmapImporter
|
2022-07-25 19:51:19 +09:00 |
|
Dean Herbert
|
2363a3fb7b
|
Persist DateAdded over beatmap updates
|
2022-07-25 19:51:19 +09:00 |
|
Dean Herbert
|
e5ad07454c
|
Ensure previous version prior to update loses online info after marked pending delete
|
2022-07-25 19:51:19 +09:00 |
|
Dean Herbert
|
912218e123
|
Ensure scores are transferred after beatmap update if difficulty hash didn't change
|
2022-07-25 19:51:19 +09:00 |
|