986 Commits

Author	SHA1	Message	Date
Salman Ahmed	ee4fe1c068	Fix relax mod not handling objects close to a previous slider's follow area	2024-01-28 23:11:42 +03:00
Bartłomiej Dach	d0e9402761	Fix flashlight not dimming if slider head is hit early ... Closes https://github.com/ppy/osu/issues/26551 Fix is a bit nuclear (`OnUpdate` should be considered last resort), but I don't see many better alternatives here as `ApplyCustomUpdateState` does not work...	2024-01-16 18:56:50 +01:00
Bartłomiej Dach	0b2b1fc588	Fix flashlight dim being applied before slider start time ... Closes https://github.com/ppy/osu/issues/26515. Compare https://github.com/ppy/osu/pull/26053.	2024-01-14 13:05:02 +01:00
Andrei Zavatski	19d0236418	Change mod acronym	2023-12-23 22:11:00 +03:00
Andrei Zavatski	e470a42da0	Merge branch 'master' into depth-mod	2023-12-23 22:09:12 +03:00
Dean Herbert	32e1b273c2	Merge pull request #26053 from bdach/fix-strict-tracking-sliders ... Fix strict tracking mod forcefully missing tail before slider start time	2023-12-23 00:03:47 +09:00
Bartłomiej Dach	30553dc7b8	Fix strict tracking mod forcefully missing tail before slider start time ... Closes https://github.com/ppy/osu/issues/25816. Regressed in https://github.com/ppy/osu/pull/25748. The reason this broke is that allowing the state of `Tracking` to change before the slider's start time to support the early hit scenario causes strict tracking to consider loss of tracking before the slider's start time as an actual miss, and thus forcefully miss the tail (see test case in 6cb8231054).	2023-12-22 13:43:14 +01:00
Bartłomiej Dach	7e557152fb	Fix relax mod not considering full follow area radius when automatically holding sliders ... Closes https://github.com/ppy/osu/issues/25947. Regressed in https://github.com/ppy/osu/pull/25776 with the changes to `DrawableSliderBall`. I would have liked to include tests, but relax mod is a bit untestable, because it disengages completely in the presence of a replay: 7e09164d70/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs (L49-L58) Additionally, `RulesetInputManager` disengages completely from parent inputs when there is a replay active: 7e09164d70/osu.Game/Rulesets/UI/RulesetInputManager.cs (L116) which means there is really no easy way to control positional input while still having relax logic work. So I'm hoping the fix could be considered obvious enough to not require test coverage.	2023-12-22 12:50:42 +01:00
Bartłomiej Dach	88e36eb08c	Fix autopilot mod still declaring incompatibility with fail-preventing mods ... Closes https://github.com/ppy/osu/issues/25974.	2023-12-20 21:46:18 +01:00
Dean Herbert	b6f0c98a09	Also apply to autopilot	2023-12-20 14:56:52 +09:00
Dan Balasescu	4b9aefa6f2	Change osu ruleset to use new HP algorithm by default	2023-12-17 19:33:04 +09:00
Andrei Zavatski	b0878e36cf	Fix stacks having incorrect position	2023-12-06 10:30:21 +03:00
Andrei Zavatski	160edcd270	Move objects at a constant speed whenever possible	2023-12-06 08:42:34 +03:00
Andrei Zavatski	594ea4da5f	Apply suggested behaviour	2023-12-05 16:00:20 +03:00
Andrei Zavatski	68907fe1ba	Cleanup pass	2023-12-05 02:48:11 +03:00
Andrei Zavatski	ec5c7d7830	Add deceleration and rework depth handling	2023-12-04 10:26:43 +03:00
Andrei Zavatski	b90000f7b7	Simplify objects depth calculation	2023-12-03 17:15:52 +03:00
Andrei Zavatski	ebcde63caa	Don't override hitobjects anchor	2023-12-03 17:13:47 +03:00
Andrei Zavatski	937689ee6b	Add OsuModDepth as incompatable to other mods	2023-12-03 05:39:44 +03:00
Andrei Zavatski	cf6e50f73c	Add header and fix typo	2023-12-03 05:07:40 +03:00
Andrei Zavatski	dc588e6d56	Implement OsuModDepth	2023-12-03 04:58:17 +03:00
Bartłomiej Dach	febd004bda	Merge branch 'master' into less-basic-touchscreen-detection	2023-11-06 07:41:35 +01:00
Bartłomiej Dach	8e9006b5d5	Declare Touch Device incompatible with Autopilot ... With Autopilot active, Touch Device no longer matters.	2023-11-02 22:57:05 +01:00
Bartłomiej Dach	9f11a04cc7	Generalise notion of 'touch device' mod	2023-11-02 19:14:05 +01:00
Dean Herbert	bf9f20705f	Simplify classic behaviour flag to only need to be specified on the slider itself	2023-11-02 18:31:29 +09:00
Dean Herbert	9c1f4b552e	Rename and invert flags for slider classic behaviours	2023-11-02 17:43:21 +09:00
Dean Herbert	48bdeaeff1	Fix another potential crash in bubbles mod ... Storing `DrawableHitObject` for later use is not safe – especially when accessing `HitObject` – as it's a pooled class. In the case here, it's important to note that `PrepareForUse` can be called a frame or more later in execution, which made this unsafe. Closes https://github.com/ppy/osu/issues/24444.	2023-11-02 02:43:51 +09:00
Dean Herbert	24b1d1e955	Fix code quality fail	2023-10-27 18:18:07 +09:00
Termincc	8b9b085ef5	Address mod incompatibilities ... Makes FreezeFrame and Transform mods incompatible.	2023-10-26 22:15:10 +10:00
Dean Herbert	686c45e21b	Merge branch 'master' into legacy-tick-test-coverage	2023-10-20 16:41:32 +09:00
Dean Herbert	54da6f1048	Merge pull request #25160 from bdach/repeat-arrow-hidden-fade ... Adjust slider repeat transforms to closer match stable	2023-10-18 18:03:48 +09:00
Dan Balasescu	939b55020c	Merge branch 'master' into legacy-tick-test-coverage	2023-10-18 15:21:31 +09:00
Bartłomiej Dach	30e5f47007	Instantly fade out slider repeats when hidden is active	2023-10-17 14:15:21 +02:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	3849b11644	Fix "Hard Rock" mod affecting CS/AR in osu!mania ... Closes https://github.com/ppy/osu/issues/25090. Not sure if there are other exceptions we should account for here.	2023-10-12 19:48:47 +09:00
Dean Herbert	dd6d09189e	Remove usage of LastTick in osu! ruleset	2023-09-29 16:58:17 +09:00
Dean Herbert	d7119674e8	Update comments to better explain what LastTick is doing	2023-09-29 14:40:44 +09:00
Dean Herbert	81485c548c	Move LegacyLastTickOffset specification to generation code and stop passing everywhere	2023-09-29 14:32:29 +09:00
Salman Ahmed	734ee0e68b	Simplify code	2023-09-24 02:22:50 +03:00
Fabian van Oeffelt	7c40072c47	Get first Spinner,Slider or HitCircle instead of only HitCircle ... Fixes bug	2023-09-23 13:18:49 +02:00
Dean Herbert	e3e7a81ad9	Remove slider head circle movement (and remove setting from "classic" mod)	2023-09-14 17:49:41 +09:00
Bartłomiej Dach	e9b08219e9	Block input to objects lying under already-hit slider heads before slider is fully judged when classic note lock is active	2023-09-08 13:42:18 +02:00
Bartłomiej Dach	168a828f23	Revert "Block input to objects lying under already-hit hitcircles when classic note lock is active" ... This reverts commit 03c61a573e. The goal here was to handle an edge case discovered during work on note lock, wherein it was determined that on stable hit circles would block input from reaching objects underneath them. However, the change mentioned above did that _too_ hard and caused overlaps to also be blocked even long past a hit circle has been faded out. Revert the change pending further (and more careful) investigation.	2023-09-08 10:11:21 +02:00
Bartłomiej Dach	323a4f4522	Only show preempt time when limits are extended	2023-09-07 08:30:02 +02:00
Bartłomiej Dach	bd633889e7	Remove local preempt time calculation ... And just use a hitcircle, and read the actual value. Comes with 100% less chance of forgetting to update either place in the future.	2023-09-07 08:23:50 +02:00
Bartłomiej Dach	9c6f77b26e	Fix too many things being exposed	2023-09-07 08:11:04 +02:00
Dean Herbert	e05d7d5f8d	Inline local control	2023-09-07 14:22:06 +09:00
isakvik	2ab11ab568	adds new diffsetting control that shows millisecond values for approach rate override	2023-09-07 01:41:22 +02:00
isakvik	3db0d0d341	extendable minimum AR value for osu!std diff adjust mod, set to -10	2023-09-06 23:26:34 +02:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00