1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-14 04:02:59 +08:00
osu-lazer/osu.Game.Rulesets.Osu/Mods
Bartłomiej Dach 7e557152fb
Fix relax mod not considering full follow area radius when automatically holding sliders
Closes https://github.com/ppy/osu/issues/25947.

Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.

I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:

	7e09164d70/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs (L49-L58)

Additionally, `RulesetInputManager` disengages completely from parent
inputs when there is a replay active:

	7e09164d70/osu.Game/Rulesets/UI/RulesetInputManager.cs (L116)

which means there is really no easy way to control positional input
while still having relax logic work. So I'm hoping the fix could be
considered obvious enough to not require test coverage.
2023-12-22 12:50:42 +01:00
..
IHidesApproachCircles.cs Remove nullable disable annotation in the Osu ruleset. 2022-07-26 23:25:28 +08:00
InputBlockingMod.cs Expose the actual KeyBindingInputManager 2023-02-14 18:10:26 +09:00
IRequiresApproachCircles.cs Remove nullable disable annotation in the Osu ruleset. 2022-07-26 23:25:28 +08:00
OsuModAccuracyChallenge.cs Fix autopilot mod still declaring incompatibility with fail-preventing mods 2023-12-20 21:46:18 +01:00
OsuModAlternate.cs Change ruleset mod description types 2022-08-10 16:09:11 -04:00
OsuModApproachDifferent.cs Fixed approachCircle preempt 2022-10-18 13:40:13 +02:00
OsuModAutopilot.cs Fix autopilot mod still declaring incompatibility with fail-preventing mods 2023-12-20 21:46:18 +01:00
OsuModAutoplay.cs Remove nullable disable annotation in the Osu ruleset. 2022-07-26 23:25:28 +08:00
OsuModBarrelRoll.cs Address mod incompatibilities 2022-12-25 23:11:15 +01:00
OsuModBlinds.cs Bypass Parent nullability checks for now 2023-10-17 17:48:45 +09:00
OsuModBubbles.cs Fix another potential crash in bubbles mod 2023-11-02 02:43:51 +09:00
OsuModCinema.cs Remove nullable disable annotation in the Osu ruleset. 2022-07-26 23:25:28 +08:00
OsuModClassic.cs Change osu ruleset to use new HP algorithm by default 2023-12-17 19:33:04 +09:00
OsuModDaycore.cs Remove overrides on DC/NC mods 2023-04-10 17:49:29 +09:00
OsuModDeflate.cs Removes unnecessary setting sources specifications 2022-09-27 09:25:58 -04:00
OsuModDifficultyAdjust.cs Only show preempt time when limits are extended 2023-09-07 08:30:02 +02:00
OsuModDoubleTime.cs Add progressive score multiplier for DT 2023-04-10 13:31:48 +09:00
OsuModEasy.cs Change ruleset mod description types 2022-08-10 16:09:11 -04:00
OsuModFlashlight.cs Update comment 2023-09-01 23:29:51 +03:00
OsuModFreezeFrame.cs Fix code quality fail 2023-10-27 18:18:07 +09:00
OsuModGrow.cs Removes unnecessary setting sources specifications 2022-09-27 09:25:58 -04:00
OsuModHalfTime.cs Add progressive score multiplier for HT 2023-04-10 13:35:48 +09:00
OsuModHardRock.cs Fix "Hard Rock" mod affecting CS/AR in osu!mania 2023-10-12 19:48:47 +09:00
OsuModHidden.cs Instantly fade out slider repeats when hidden is active 2023-10-17 14:15:21 +02:00
OsuModMagnetised.cs Address mod incompatibilities 2022-12-25 23:11:15 +01:00
OsuModMirror.cs Disambiguate object flipping and reflection methods 2022-12-07 21:09:53 +00:00
OsuModMuted.cs Remove nullable disable annotation in the Osu ruleset. 2022-07-26 23:25:28 +08:00
OsuModNightcore.cs Remove overrides on DC/NC mods 2023-04-10 17:49:29 +09:00
OsuModNoFail.cs Fix autopilot mod still declaring incompatibility with fail-preventing mods 2023-12-20 21:46:18 +01:00
OsuModNoScope.cs Merge branch 'master' into no-scope-no-smoke 2022-10-15 16:42:34 +03:00
OsuModObjectScaleTween.cs Removes unnecessary setting sources specifications 2022-09-27 09:25:58 -04:00
OsuModPerfect.cs Fix autopilot mod still declaring incompatibility with fail-preventing mods 2023-12-20 21:46:18 +01:00
OsuModRandom.cs updates and add changes 2023-05-14 13:37:44 -04:00
OsuModRelax.cs Fix relax mod not considering full follow area radius when automatically holding sliders 2023-12-22 12:50:42 +01:00
OsuModRepel.cs Address mod incompatibilities 2022-12-25 23:11:15 +01:00
OsuModSingleTap.cs Change ruleset mod description types 2022-08-10 16:09:11 -04:00
OsuModSpinIn.cs Change ruleset mod description types 2022-08-10 16:09:11 -04:00
OsuModSpunOut.cs Rename "Target" to "Target Practice" 2022-11-01 19:47:20 +09:00
OsuModStrictTracking.cs Remove usage of LastTick in osu! ruleset 2023-09-29 16:58:17 +09:00
OsuModSuddenDeath.cs Fix autopilot mod still declaring incompatibility with fail-preventing mods 2023-12-20 21:46:18 +01:00
OsuModSynesthesia.cs Update comments to better explain what LastTick is doing 2023-09-29 14:40:44 +09:00
OsuModTargetPractice.cs Fix multiple instances of last hitobject time being calculated incorrectly 2022-12-01 18:04:06 +09:00
OsuModTouchDevice.cs Declare Touch Device incompatible with Autopilot 2023-11-02 22:57:05 +01:00
OsuModTraceable.cs Change ruleset mod description types 2022-08-10 16:09:11 -04:00
OsuModTransform.cs Address mod incompatibilities 2023-10-26 22:15:10 +10:00
OsuModWiggle.cs Change ruleset mod description types 2022-08-10 16:09:11 -04:00