1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-11 10:07:52 +08:00
osu-lazer/osu.Game.Rulesets.Osu
Bartłomiej Dach 7e557152fb
Fix relax mod not considering full follow area radius when automatically holding sliders
Closes https://github.com/ppy/osu/issues/25947.

Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
`DrawableSliderBall`.

I would have liked to include tests, but relax mod is a bit untestable,
because it disengages completely in the presence of a replay:

	7e09164d70/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs (L49-L58)

Additionally, `RulesetInputManager` disengages completely from parent
inputs when there is a replay active:

	7e09164d70/osu.Game/Rulesets/UI/RulesetInputManager.cs (L116)

which means there is really no easy way to control positional input
while still having relax logic work. So I'm hoping the fix could be
considered obvious enough to not require test coverage.
2023-12-22 12:50:42 +01:00
..
Beatmaps Fix combo/combo colouring issues around spinners 2023-11-23 13:54:05 +09:00
Configuration Add basic structural requirements for cursor ripples 2023-04-30 14:48:03 +09:00
Difficulty Expose only as one method 2023-12-21 14:58:23 +09:00
Edit Fix slider tests and incorrect nullability handling around freehandToolboxGroup 2023-12-13 15:15:49 +09:00
Judgements Add SpinnerSpinHistory and tests 2023-10-17 20:10:22 +09:00
Mods Fix relax mod not considering full follow area radius when automatically holding sliders 2023-12-22 12:50:42 +01:00
Objects Fix relax mod not considering full follow area radius when automatically holding sliders 2023-12-22 12:50:42 +01:00
Properties Automated pass 2023-06-24 01:00:03 +09:00
Replays Expand comment for clarification 2023-11-20 11:50:28 +09:00
Scoring Revert change to OsuHitWindows and move logic local to pooling initialisation 2023-12-21 00:48:46 +09:00
Skinning Fix argon pro not showing slider tick judgements 2023-12-20 20:52:26 +01:00
Statistics Move helper method to LegacyRulesetExtensions and stop applying rounding allowance to catch 2023-10-20 18:57:14 +09:00
UI Revert change to OsuHitWindows and move logic local to pooling initialisation 2023-12-21 00:48:46 +09:00
Utils Automated pass 2023-06-24 01:00:03 +09:00
osu.Game.Rulesets.Osu.csproj Update language version 2023-02-25 02:15:56 +09:00
OsuInputManager.cs Add note about CheckScreenSpaceActionPresJudgeable being naive 2023-01-25 15:03:47 +09:00
OsuRuleset.cs Change osu ruleset to use new HP algorithm by default 2023-12-17 19:33:04 +09:00
OsuSkinComponentLookup.cs Add "Component" prefix to lookup naming 2022-11-09 17:46:43 +09:00
OsuSkinComponents.cs Implement ripples (legacy and default) 2023-04-30 14:48:03 +09:00