599 Commits

• Update namespaces
  Dean Herbert · 2021-01-18 21:24:10 +09:00
  ced7a36788
• Merge branch 'master' into fix-spinner-spinning-weirdness
  Dean Herbert · 2021-01-18 18:26:44 +09:00
  707d5346c9
• Avoid doing a config lookup if initial conditional fails
  Dean Herbert · 2021-01-18 16:13:58 +09:00
  94fee8c31d
• Merge branch 'master' into beatmap-colour-setting
  Dean Herbert · 2021-01-18 16:07:46 +09:00
  1364de1166
• Trim braces for consistency
  Bartłomiej Dach · 2021-01-15 22:04:45 +01:00
  3c1a86d11d
• Add support for playing a SkinnableSample without restarting it
  Dean Herbert · 2021-01-15 17:16:12 +09:00
  8a6857f151
• Change conditional used to decide legacy judgement animation to match stable

  In stable, the type of legacy judgement to show is based on the presence
  of particle textures in the skin. We were using the skin version
  instead, which turns out to be incorrect and not what some user skins
  expect.
  
  Closes #11078.

  Dean Herbert · 2021-01-15 14:51:27 +09:00
  ebbc32adfa
• Found a better solution than TValue type checking for additional beatmap colour settings. Added unit tests for Catch Beatmap Skin settings.
  Mysfit · 2021-01-14 23:30:24 -05:00
  0c01a3a685
• Simplified colour config checks in SkinProvidingContainer.cs
  Mysfit · 2021-01-14 16:53:55 -05:00
  99e43c77c2
• Improve naming around the config lookup with fallback private method.

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Jesse Myers · 2021-01-13 16:49:14 -05:00
  562634dfd2
• Moved SkinProvidingContainer bindable fetching to common method. Replaced redundant test boolean declarations with inline values.
  Mysfit · 2021-01-13 16:05:46 -05:00
  8b95817f7a
• Reverted change to AllowConfigurationLookup and added a separate AllowColourLookup bool with config case based on lookup type in SkinProvidingContainer GetConfig call.
  Mysfit · 2021-01-13 13:07:07 -05:00
  1248d39d7e
• Fix whitespace formatting.
  Mysfit · 2021-01-13 00:25:54 -05:00
  7bfb5954a8
• Added beatmap colour settings checkbox and associated tests.
  Mysfit · 2021-01-13 00:09:22 -05:00
  5f10bcce02
• Annotate potentially null parameters in protected ctor of LegacySkin
  Dean Herbert · 2020-12-22 12:08:40 +09:00
  13ef097a53
• Add region specifications around implicit interface implementations
  Dean Herbert · 2020-12-22 12:01:09 +09:00
  10c2745682
• Expose resources to skin via interface (and share common pieces with beatmap)
  Dean Herbert · 2020-12-21 15:18:52 +09:00
  a5bcf1dc20
• Clamp osu!mania's HitPosition offset to match osu-stable implementation

  Closes #11184.

  Dean Herbert · 2020-12-16 18:08:19 +09:00
  c002184768
• Merge branch 'master' into mania-legacyskin-scoreposition
  smoogipoo · 2020-12-14 11:25:34 +09:00
  ca11eeefdf
• simplify implementation and adjust the default values
  Firmatorenio · 2020-12-13 22:43:36 +06:00
  3741c2339a
• apply ScorePosition to the judgement container
  Firmatorenio · 2020-12-13 22:01:08 +06:00
  2108844319
• add support for ScorePosition into LegacyManiaSkin
  Firmatorenio · 2020-12-10 20:11:08 +06:00
  b3d8347315
• Invert back-to-front logic
  Bartłomiej Dach · 2020-12-06 18:59:38 +01:00
  f6d15b9757
• Merge branch 'master' into fix-multiple-playback-on-skin-change
  Bartłomiej Dach · 2020-12-06 18:21:24 +01:00
  fcd9483ffa
• Merge branch 'master' into fix-sample-expire
  Dean Herbert · 2020-12-04 13:49:08 +09:00
  a0f92628ac
• Fix DHO expires while hit sound is playing
  ekrctb · 2020-12-03 12:32:49 +09:00
  6c46046c24
• Trim double full-stop in xmldoc
  Bartłomiej Dach · 2020-11-30 19:43:20 +01:00
  2c57deea2b
• Better API for dealing with the contained drawable samples
  smoogipoo · 2020-11-30 19:26:25 +09:00
  c29ad8edf8
• Lose old reference immediately on updateSample()
  smoogipoo · 2020-11-30 19:19:24 +09:00
  f5e8d1d14d
• Apply simple PR reviews
  smoogipoo · 2020-11-30 18:40:22 +09:00
  afb8eb636d
• Merge branch 'master' into hit-sample-pooling
  smoogipoo · 2020-11-30 18:31:58 +09:00
  4bbeb9ebd4
• Expose animation start time as mutable in interface
  Bartłomiej Dach · 2020-11-22 13:11:22 +01:00
  1c31a4a6b6
• Apply similar fix to PoolableSkinnableSound
  Dean Herbert · 2020-11-22 14:44:39 +09:00
  a3b1d14f17
• Add support for changing animation start time after load
  Bartłomiej Dach · 2020-11-21 20:06:30 +01:00
  240c1b0aef
• Fix samples being played more than once on skin change
  Dean Herbert · 2020-11-20 20:38:26 +09:00
  8080fe942c
• Move CanBeNull specification to the interface
  Dean Herbert · 2020-11-20 16:30:48 +09:00
  a00e0d7279
• Show main judgement content above hitobjects
  Dean Herbert · 2020-11-20 16:25:48 +09:00
  7fe0923fcf
• Add more xmldocs
  smoogipoo · 2020-11-19 22:48:21 +09:00
  7c83a27002
• Fix missing SkinChanged event + safety
  smoogipoo · 2020-11-19 22:42:44 +09:00
  8a656f7cee
• Cleanup, refactoring, and restart sample on skin change
  smoogipoo · 2020-11-19 22:30:21 +09:00
  d388c44428
• Fix volume discrepancies
  smoogipoo · 2020-11-19 21:21:30 +09:00
  0287269b2f
• Cleanups
  smoogipoo · 2020-11-19 20:38:36 +09:00
  70cb197957
• Fix looping not being propagated
  smoogipoo · 2020-11-19 20:29:09 +09:00
  812d5d59b1
• Separate files
  smoogipoo · 2020-11-19 19:52:34 +09:00
  003fed857c
• Add initial hit sample pooling
  smoogipoo · 2020-11-19 19:51:09 +09:00
  730b14b5bb
• Make particles additive and consume in judgement explosions
  Dean Herbert · 2020-11-19 15:47:02 +09:00
  9d04ce75cc
• Provide particle drawable as a function (for future use)
  Dean Herbert · 2020-11-19 13:20:21 +09:00
  85c5c68dfa
• Merge branch 'master' into legacy-jugement-match-stable-transforms
  Bartłomiej Dach · 2020-11-18 20:33:58 +01:00
  24d7fa03d8
• Merge branch 'master' into fix-judgement-transform-logic
  Bartłomiej Dach · 2020-11-18 19:20:11 +01:00
  5156de3a10
• Update animations for new/old miss style and add fades
  Dean Herbert · 2020-11-18 19:03:34 +09:00
  c47e70da9b