h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-26 12:25:04 +08:00
Code Issues Releases Wiki Activity

Simplified colour config checks in SkinProvidingContainer.cs

Browse Source
This commit is contained in:
Mysfit 2021-01-14 16:53:55 -05:00
parent 562634dfd2
commit 99e43c77c2
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
osu.Game/Skinning/SkinProvidingContainer.cs
View File

@ -10,6 +10,7 @@ using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.OpenGL.Textures;
using osu.Framework.Graphics.Textures;
using osu.Game.Audio;
using osuTK.Graphics;
namespace osu.Game.Skinning
{
@ -72,22 +73,12 @@ namespace osu.Game.Skinning
{
if (skin != null)
{
switch (lookup)
{
// todo: the GlobalSkinColours switch is pulled from LegacySkin and should not exist.
// will likely change based on how databased storage of skin configuration goes.
case GlobalSkinColours global:
switch (global)
{
case GlobalSkinColours.ComboColours:
return getBindable<TLookup, TValue>(lookup, AllowColourLookup);
}
TValue tValueTypeCheck = default;
break;
default:
return getBindable<TLookup, TValue>(lookup, AllowConfigurationLookup);
}
if (lookup is GlobalSkinColours || tValueTypeCheck is Color4)
return lookupWithFallback<TLookup, TValue>(lookup, AllowColourLookup);
else
return lookupWithFallback<TLookup, TValue>(lookup, AllowConfigurationLookup);
}
return fallbackSource?.GetConfig<TLookup, TValue>(lookup);