67640 Commits

This Branch

This Branch

All Branches

• Reduce length of fade-out when hiding beatmap panels
  Dean Herbert · 2024-06-26 12:01:38 +09:00
  e84daedbea
• Adjust beatmap carousel's spacing to remove dead-space

  As discussed in https://github.com/ppy/osu/discussions/28599.
  
  I think this feels better overall, and would like to apply the change
  before other design changes to the carousel.

  Dean Herbert · 2024-06-26 11:56:58 +09:00
  5d4509150b
• Merge pull request #28596 from stanriders/remove-peaks-skill

  Refactor out taiko Peaks skill

  Dan Balasescu · 2024-06-26 11:18:01 +09:00
  9039ec34ba
• Refactor out taiko Peaks skill
  StanR · 2024-06-25 23:06:42 +05:00
  df64d7f374
• Merge pull request #28592 from peppy/fix-editor-performance

  Fix editor performance dropping over time when hit markers are enabled

  Dean Herbert · 2024-06-26 01:12:08 +09:00
  2024.625.2 82bc95e04d
• Fix editor performance dropping over time when hit markers are enabled

  There's probably a better solution but let's hotfix this for now.

  Dean Herbert · 2024-06-26 01:06:37 +09:00
  dc817b62cc
• Merge pull request #28589 from bdach/scale-handling-crash

  Fix crashes when opening scale/rotation popovers during selection box operations

  Dean Herbert · 2024-06-26 00:11:03 +09:00
  2024.625.1 aadb104851
• Add missing base calls for safety
  Dean Herbert · 2024-06-25 23:41:43 +09:00
  d722be16e3
• Merge pull request #28561 from bdach/daily-challenge/score-breakdown

  Implement score breakdown display for daily challenge screen

  Dean Herbert · 2024-06-25 23:34:47 +09:00
  3d22f700a7
• Merge pull request #28590 from peppy/update-framework

  Update framework

  Dean Herbert · 2024-06-25 23:34:30 +09:00
  bca4d51e5a
• Update framework
  Dean Herbert · 2024-06-25 23:03:37 +09:00
  0a44022697
• Fix crashes when opening scale/rotation popovers during selection box operations
  Bartłomiej Dach · 2024-06-25 15:20:59 +02:00
  2fda45cad4
• Merge pull request #28580 from bdach/fix-breaks

  Fix crash when attempting to adjust duration of break that has no preceding/succeeding objects

  Dean Herbert · 2024-06-25 20:24:27 +09:00
  6cd1367329
• Merge pull request #28572 from bdach/fix-playlist-duration-death

  Fix crash on calculating playlist duration when rate-changing mods are present

  Dean Herbert · 2024-06-25 20:15:26 +09:00
  a12f32519d
• Merge pull request #28576 from PercyDan54/rank-update

  Fix silver S rank display animating on every hit

  Dean Herbert · 2024-06-25 20:02:51 +09:00
  2c4809cc01
• Remove manual breaks at the start/end of beatmap

  This is the secondary cause of https://github.com/ppy/osu/issues/28577,
  because you could do the following:
  
  - Have a break autogenerate itself
  - Adjust either end of it to make it mark itself as manually-adjusted
  - Remove all objects before or after said break
  
  to end up in a state wherein there are no objects before or after a
  break.
  
  The direct fix is still correct because it is still technically possible
  to end up in a state wherein a break is before or after all objects
  (obvious one is manual `.osu` editing), but this behaviour is also
  undesirable for the autogeneration logic.

  Bartłomiej Dach · 2024-06-25 12:49:17 +02:00
  fae6dcfffa
• Add failing test coverage for manual breaks at start/end of map not being culled
  Bartłomiej Dach · 2024-06-25 12:34:37 +02:00
  18e2a925a8
• Fix timeline break piece crashing on drag if there are no objects before start or after end

  This fixes the direct cause of https://github.com/ppy/osu/issues/28577.

  Bartłomiej Dach · 2024-06-25 12:25:37 +02:00
  03cdfd0660
• Merge pull request #28570 from bdach/fix-upscroll

  Fix legacy skin hold note bodies not appearing when scrolling upwards

  Dean Herbert · 2024-06-25 19:08:23 +09:00
  c5c30949d2
• Fix transient rank value applied to bindable
  PercyDan54 · 2024-06-25 18:06:50 +08:00
  2de0852551
• Merge pull request #28568 from bdach/fix-classic-slider-drawable-judgement-position

  Fix incorrect slider judgement positions when classic mod is active

  Dean Herbert · 2024-06-25 19:04:05 +09:00
  a042b6e141
• Fix crash on calculating playlist duration when rate-changing mods are present

  Regressed in https://github.com/ppy/osu/pull/28399.
  
  To reproduce, enter a playlist that has an item with a rate-changing mod
  (rather than create it yourself).
  
  This is happening because `APIRuleset` has `CreateInstance()`
  unimplemented:
  
      https://github.com/ppy/osu/blob/b4cefe0cc2fda0ab4b5af6138ee158bd32262f9a/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs#L159
  
  and only triggers when the playlist items in question originate from
  web.
  
  This is why it is bad to have interface implementations throw outside of
  maybe mock implementations for tests. `CreateInstance()` is a scourge
  elsewhere in general, we need way less of it in the codebase (because
  while convenient, it's also problematic to implement in online contexts,
  and also expensive because reflection).

  Bartłomiej Dach · 2024-06-25 11:28:10 +02:00
  0d2a47167c
• Fix legacy skin hold note bodies not appearing when scrolling upwards

  - Closes https://github.com/ppy/osu/issues/28567.
  - Regressed in https://github.com/ppy/osu/pull/28466.
  
  Bit of a facepalm moment innit...

  Bartłomiej Dach · 2024-06-25 10:35:36 +02:00
  1eac0c622a
• Fix incorrect slider judgement positions when classic mod is active

  Regressed in https://github.com/ppy/osu/pull/27977.
  
  Bit ad-hoc but don't see how to fix without just reverting the change.

  Bartłomiej Dach · 2024-06-25 10:07:58 +02:00
  2cb18820ea
• Update rider vcsConfiguration

  Updated in recent rider versions

  Dean Herbert · 2024-06-25 15:50:11 +09:00
  b4cefe0cc2
• Fix corner radius looking bad when graph bars are too short
  Dean Herbert · 2024-06-25 15:43:52 +09:00
  2de42854c3
• Implement score breakdown display for daily challenge screen
  Bartłomiej Dach · 2024-06-24 10:09:10 +02:00
  66b093b17e
• Merge pull request #28559 from peppy/fix-key-binding-corruption

  Fix scale control key binding breaking previous defaults

  Dan Balasescu · 2024-06-24 11:46:43 +09:00
  2024.625.0 442705bc0c
• Merge branch 'master' into fix-key-binding-corruption
  Salman Ahmed · 2024-06-24 05:30:21 +03:00
  7cbd04db9c
• Fix scale control key binding breaking previous defaults

  Oops from ppy/osu#28309.

  Dean Herbert · 2024-06-24 09:46:23 +08:00
  1dc9f10235
• Merge pull request #28537 from bdach/hit-animations

  Adjust behaviour of hit animations toggle to match user expectations

  Dean Herbert · 2024-06-23 11:58:04 +09:00
  3bf742bda2
• Merge branch 'master' into hit-animations
  Dean Herbert · 2024-06-23 04:32:47 +09:00
  c58bb62408
• Add note about every-frame-transforms
  Dean Herbert · 2024-06-23 03:31:40 +08:00
  df43a1c6cc
• Update resources
  Dean Herbert · 2024-06-22 22:01:05 +08:00
  80907acaa6
• Merge pull request #28540 from ssz7-ch2/fix-typo

  Fix typo in ScoreProcessor

  Bartłomiej Dach · 2024-06-21 08:32:01 +02:00
  8bbbedaec3
• fix accuracyProcess typo
  sometimes · 2024-06-20 22:06:00 -04:00
  89d3f67eb3
• Adjust behaviour of hit animations toggle to match user expectations
  Bartłomiej Dach · 2024-06-20 13:42:32 +02:00
  ad2cd0ba8f
• Merge pull request #28478 from bdach/timeline-drag-selection-crash

  Fix crash on drag selection via timeline while placement is active

  Dean Herbert · 2024-06-20 19:00:45 +09:00
  cd4dce2c7e
• Merge branch 'master' into timeline-drag-selection-crash
  Dean Herbert · 2024-06-20 15:16:10 +09:00
  14104e57d4
• Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads

  Reload scrolling hitobject composer on control point changes

  Dean Herbert · 2024-06-20 15:15:26 +09:00
  0eb533f2fd
• Merge pull request #28528 from bdach/break-autogeneration
  Dean Herbert · 2024-06-19 23:46:05 +09:00
  9eb6752033
• Adjust break colours to match closer to stable
  Dean Herbert · 2024-06-19 22:02:10 +08:00
  a718af8af5
• Make (Manual)BreakPeriod a class again

  CodeFileSanity doesn't like records and it being a record wasn't doing
  much anymore anyway.

  Bartłomiej Dach · 2024-06-19 14:53:09 +02:00
  617c1341d7
• Merge branch 'master' into break-autogeneration
  Dean Herbert · 2024-06-19 21:49:17 +09:00
  00443403b6
• Merge pull request #28523 from bdach/break-display-and-adjustment

  Display breaks on editor timeline & allow manually adjusting their duration

  Dean Herbert · 2024-06-19 21:48:54 +09:00
  32a7885f10
• Change colour to match bottom timeline (and adjust tween sligthly)
  Dean Herbert · 2024-06-19 20:30:43 +08:00
  00a866b699
• Fix test failures due to automatic break generation kicking in
  Bartłomiej Dach · 2024-06-19 11:32:08 +02:00
  8757e08c2c
• Remove no-longer-necessary null propagation
  Bartłomiej Dach · 2024-06-19 11:21:57 +02:00
  2d9c3fbed2
• Add test coverage for automatic break generation
  Bartłomiej Dach · 2024-06-19 11:14:38 +02:00
  4390798761
• Purge manual breaks if they intersect with an actual hitobject
  Bartłomiej Dach · 2024-06-19 10:51:37 +02:00
  7311a7ffd7