Bartłomiej Dach
c3dae81935
Only add legacy key overlay to osu! and catch HUD layers
2024-07-24 15:41:20 +02:00
Bartłomiej Dach
26395bd443
Adjust animations further to match stable
2024-07-24 15:26:27 +02:00
Bartłomiej Dach
3c28c116ca
Simplify input overlay text colour decode (and fix incorrect default)
2024-07-24 14:53:01 +02:00
Bartłomiej Dach
087dd759be
Adjust layout to ballpark-match stable
...
I dunno what the wiki is claiming with the "24px" figure or why
but I'm not playing conversion games either. Dimensions ballparked
via screenshots captured at x768 resolution.
Also removes a weird homebrew method to keep the text upright.
There is one canonical way to do this, namely
`UprightAspectMaintainingContainer`. And the other key counters
were already using it.
2024-07-24 14:52:56 +02:00
Bartłomiej Dach
ace5071d88
Add better test scene
2024-07-24 14:25:51 +02:00
Bartłomiej Dach
1ed7e4b075
Make sample popover change properties of all samples in multiple selection
...
Closes https://github.com/ppy/osu/issues/28916 .
The previous behaviour *may* have been intended, but it was honestly
quite baffling. This seems like a saner variant.
2024-07-24 12:15:12 +02:00
Bartłomiej Dach
55382a4ba6
Add test coverage for expected sample popover behaviour
2024-07-24 12:08:13 +02:00
Dean Herbert
6e4625609d
Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard
...
Fill daily challenge top 50 position numbers client-side
2024-07-24 17:49:51 +09:00
Dean Herbert
65fcef1929
Merge pull request #29037 from bdach/daily-challenge-exit-when-offline
...
Exit daily challenge screen when going offline
2024-07-24 17:48:07 +09:00
Bartłomiej Dach
788b70469d
Exit daily challenge screen when going offline
...
This sort of thing is bound to happen when rewriting screens from
scratch without invoking abstract eldritch entities sometimes. Damned if
you do, damned if you don't...
2024-07-24 09:15:32 +02:00
Bartłomiej Dach
bf4bf4d39e
Fill daily challenge top 50 position numbers client-side
...
Only doing this client-side, because doing this server-side is
expensive:
https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285
2024-07-24 08:57:11 +02:00
Dean Herbert
aded31bd07
Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt
...
Respect pre-empt time when auto-generating breaks
2024-07-24 15:21:12 +09:00
normalid
0306ef4096
Update test assets
2024-07-24 14:13:45 +08:00
normalid
fede6b3657
Fix indent problems
2024-07-24 13:09:21 +08:00
normalid
b24be96d04
Fix code quality
2024-07-24 12:57:30 +08:00
normalid
56143de2c6
Update offset factor
2024-07-24 12:39:36 +08:00
normalid
e2beacb3dd
Remove logging
2024-07-24 12:31:01 +08:00
normalid
395f8424b5
Match the stable animation
2024-07-24 12:30:08 +08:00
normalid
95f287104e
Add visual test seane
2024-07-24 12:24:58 +08:00
normalid
661f58a397
Add test coverage
2024-07-24 12:18:05 +08:00
normalid
c52a993607
Support custom input overlay color
2024-07-23 23:35:25 +08:00
normalid
c7b110a471
* Fix the default position
...
* Make the font match stable style
2024-07-23 22:11:28 +08:00
Dean Herbert
a9ccb50b98
Merge pull request #29020 from bdach/drag-selection-tolerance
...
Add tolerance when drag-scrolling editor timeline
2024-07-23 22:28:29 +09:00
normalid
989ac56cbb
Fix the return button being squshed
2024-07-23 21:12:55 +08:00
normalid
9fe369b7f4
Replace SkinnableSprite with Sprite
2024-07-23 21:08:08 +08:00
normalid
a015fde014
Change the default height to match the stable
2024-07-23 20:53:06 +08:00
normalid
dce894108a
Remove unused blending mode
2024-07-23 20:50:08 +08:00
normalid
f7dc0b65da
Clean up the code
2024-07-23 20:47:49 +08:00
normalid
5dcc8b7a8f
Make the text are always horizontal
2024-07-23 19:56:43 +08:00
Dean Herbert
aed7ba9508
Change order of application to avoid bias to side with more room to drag
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-07-23 20:56:21 +09:00
normalid
777a0deb0f
Update the offset formula
2024-07-23 19:45:53 +08:00
Bartłomiej Dach
c3062f96ee
Fix autogenerated breaks not invalidating on change to pre-empt time
2024-07-23 13:38:50 +02:00
Bartłomiej Dach
c2fa30bf81
Add test coverage for break generation respecting pre-empt time
2024-07-23 13:38:25 +02:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
...
Closes https://github.com/ppy/osu/issues/28703 .
2024-07-23 13:30:13 +02:00
Bartłomiej Dach
25d63ac6a5
Move editor beatmap processor test cases off of OsuHitObjects
...
Most of them are about to become obsolete once consideration for
`TimePreempt` is re-added.
2024-07-23 13:28:49 +02:00
normalid
ad1a86ebdc
Implement the overlay
2024-07-23 19:05:14 +08:00
Dean Herbert
40b171f544
Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued
...
Fix duration fluctuations and one-frame jitters when editing juice streams
2024-07-23 19:02:30 +09:00
Dean Herbert
cc4ed0ff3f
Use non-screen-space coordinates and add time-based drag ramping for better control
2024-07-23 18:59:22 +09:00
Bartłomiej Dach
38fc6f70f6
Add tolerance when drag-scrolling editor timeline
...
Closes https://github.com/ppy/osu/issues/28983 .
While the direct cause of this is most likely mouse confine in
full-screen, it shouldn't/can't really be disabled just for this,
and I also get this on linux in *windowed* mode.
In checking other apps, adding some tolerance to this sort of
drag-scroll behaviour seems like a sane UX improvement anyways.
2024-07-23 11:10:18 +02:00
Dean Herbert
aba05a21aa
Merge branch 'master' into catch-juice-stream-editing-weirdness-continued
2024-07-23 17:05:40 +09:00
Dean Herbert
5911c42116
Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness
...
Fix various shortcomings in juice stream selection blueprint
2024-07-23 16:43:39 +09:00
Bartłomiej Dach
6100f5269d
Fix tests
2024-07-23 09:13:43 +02:00
Bartłomiej Dach
f3617eadad
Fix editing juice stream path sometimes changing its duration
...
I'm not *super* sure why this works, but it appears to, and my educated
guess as to why is that it counteracts the effects of a change in the SV
of the juice stream by artificially increasing or decreasing the
velocity when running the appropriate path conversions and expected
distance calculations. The actual SV change takes effect on the next
default application, which is triggered by the `Update()` call at the
end of the method.
2024-07-22 15:14:45 +02:00
Bartłomiej Dach
56af009e77
Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object
...
This is important because the editable path conversions heavily depend
on the value of `JuiceStream.Velocity` being correct. The value is only
guaranteed to be correct after an `ApplyDefaults()` call, which is
triggered by updating the object via `EditorBeatmap`.
2024-07-22 14:50:25 +02:00
Bartłomiej Dach
f86ab1a64e
Fix filename
2024-07-22 13:49:52 +02:00
Bartłomiej Dach
1d91201c43
Fix tests
2024-07-22 13:37:24 +02:00
Bartłomiej Dach
6b3c1f4e47
Unify juice stream piece UX with osu! control point pieces
...
- Use same hover state
- Use shift-right click for quick delete rather than shift-left click
2024-07-22 13:30:15 +02:00
Bartłomiej Dach
47964f33d7
Fix catch juice stream vertex remove operation not undoing
2024-07-22 13:21:49 +02:00
Bartłomiej Dach
64381d4087
Fix catch juice stream vertex add operation not undoing
2024-07-22 12:18:53 +02:00
Dean Herbert
7e5fda4539
Merge pull request #28996 from bdach/fix-dim-again
...
Fix editor UI dimming when hovering over expanded part of toolboxes
2024-07-22 19:11:31 +09:00
