49943 Commits

This Branch

This Branch

All Branches

• Merge pull request #17431 from peppy/fix-participants-panel-null-ref

  Guard against potential null `CurrentItem` in `ParticipantPanel`

  Dan Balasescu · 2022-03-25 11:47:43 +09:00
  def2ce243f
• Merge pull request #17429 from peppy/fix-old-legacy-replays

  Fix replays set on old beatmaps having incorrect timing

  Bartłomiej Dach · 2022-03-24 23:45:42 +01:00
  e58b742728
• Merge branch 'master' into fix-old-legacy-replays
  Bartłomiej Dach · 2022-03-24 23:21:50 +01:00
  5f730c0cd4
• Merge pull request #17425 from peppy/fix-realm-import-test-assert-failure

  Fix realm potentially not being refreshed in time for test asserts in `BeatmapImporterTests`

  Bartłomiej Dach · 2022-03-24 22:16:25 +01:00
  959f200638
• Remove assertion to fix "expression always true" inspection
  Bartłomiej Dach · 2022-03-24 21:51:10 +01:00
  878e8d21a3
• Merge branch 'master' into fix-realm-import-test-assert-failure
  Bartłomiej Dach · 2022-03-24 21:48:10 +01:00
  b76cd2beae
• Guard against potential null CurrentItem in ParticipantPanel
  Dean Herbert · 2022-03-24 17:54:21 +09:00
  2d58feebb1
• Add asserts of playlist being non-empty after client operations
  Dean Herbert · 2022-03-24 17:52:20 +09:00
  e889d93441
• Merge pull request #17326 from smoogipoo/multiplayer-countdown-timers-2

  Implement multiplayer countdown timers

  Dean Herbert · 2022-03-24 17:50:53 +09:00
  d7faff15c0
• Merge branch 'master' into multiplayer-countdown-timers-2
  Dean Herbert · 2022-03-24 17:24:00 +09:00
  0275e974e5
• Revert Availability to private
  Dean Herbert · 2022-03-24 17:15:17 +09:00
  e3f8bc0588
• Fix incorrect event binding
  Dan Balasescu · 2022-03-24 17:11:08 +09:00
  528ffea38d
• Split out shared code for encode-decode cycle (and remove unrelated culture set)
  Dean Herbert · 2022-03-24 17:00:49 +09:00
  d6fc53579e
• Use a constant for the early version timing offset
  Dean Herbert · 2022-03-24 16:43:41 +09:00
  a7554dcdf7
• Add test coverage of decode specifically
  Dean Herbert · 2022-03-24 16:39:56 +09:00
  2efae031c9
• Add test coverage ensuring offsets are correct before and after legacy replay encode
  Dean Herbert · 2022-03-24 16:34:21 +09:00
  59a7eb5322
• Refactor cancellation logic
  Dan Balasescu · 2022-03-24 16:29:59 +09:00
  dfa076c169
• Apply beatmap offsets to legacy replay frame handling
  Dean Herbert · 2022-03-24 16:16:40 +09:00
  a7d5f2281c
• Asserate code is running on update thread
  Dan Balasescu · 2022-03-24 15:51:30 +09:00
  4c0d76573c
• Rename FinishCountdown() -> SkipToEndOfCountdown()
  Dan Balasescu · 2022-03-24 15:21:46 +09:00
  f0d132b16e
• Revert unnecessary async change
  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  d2ecc100e5
• Add explanation for try-catch
  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  8f3a4df70a
• Dispose token manually

  Cover more branches with cancellation source disposal

  Dan Balasescu · 2022-03-24 15:07:24 +09:00
  d36944ac95
• Rename Multiplayer prefix to button classes
  Dan Balasescu · 2022-03-24 14:28:38 +09:00
  96a447f68b
• Re-remove PopoverButton class with better test fix
  Dan Balasescu · 2022-03-24 14:26:31 +09:00
  90c7945bca
• Fix realm potentially not being refreshed in time for test asserts in BeatmapImporterTests

  As seen at https://github.com/ppy/osu/runs/5659368512?check_suite_focus=true
  
  Went through every usage of `.Import` and added either an
  `EnsureLoaded`, or where that provides too many checks, an explicit
  `realm.Refresh()`.

  Dean Herbert · 2022-03-24 12:59:17 +09:00
  4d0b4c2541
• Merge pull request #17419 from peppy/fix-hitsound-regresssssssion

  Fix hitsounds not always playing when they should

  Dan Balasescu · 2022-03-24 11:53:18 +09:00
  3b97de04b7
• Revert "Remove PopoverButton class"

  This reverts commit 6b712be97d.

  Dan Balasescu · 2022-03-24 11:15:51 +09:00
  547418e47e
• Add comment regarding equality check importance in LegacyHitSampleInfo
  Dean Herbert · 2022-03-23 20:18:44 +09:00
  c079a9cd32
• Revert "Remove IsLayered from LegacyHitSampleInfo comparison"

  This reverts commit 4523393208.

  Dean Herbert · 2022-03-23 20:15:17 +09:00
  997c091a8d
• Revert "Remove IsLayered from GetHasCode implementation"

  This reverts commit 16ee6b5fc7.

  Dean Herbert · 2022-03-23 20:15:13 +09:00
  2ea9e5245c
• Merge branch 'master' into multiplayer-countdown-timers-2
  Dan Balasescu · 2022-03-23 15:40:50 +09:00
  34a367b369
• Rename countdown Delay -> Duration
  Dan Balasescu · 2022-03-23 15:21:16 +09:00
  a83a90e675
• Send time remaining in countdowns instead
  Dan Balasescu · 2022-03-23 15:19:43 +09:00
  f7c0047206
• Merge pull request #17414 from peppy/update-localisation-analyser

  Update LocalisationAnalyser to support .net6

  Dan Balasescu · 2022-03-23 11:41:11 +09:00
  999ddff3d4
• Update LocalisationAnalyser to support .net6
  Dean Herbert · 2022-03-23 11:03:24 +09:00
  657daf07d7
• Limit countdown updates to once per second
  Dan Balasescu · 2022-03-23 10:50:05 +09:00
  d4ad4ac9db
• Remove PopoverButton class
  Dan Balasescu · 2022-03-23 10:40:38 +09:00
  6b712be97d
• Split MultiplayerReadyButton
  Dan Balasescu · 2022-03-23 10:38:56 +09:00
  9138aaf780
• Merge pull request #17400 from nagilson/screen-mod-retention

  Fix mods from single player carrying over to multiplayer

  Dan Balasescu · 2022-03-23 08:36:15 +09:00
  1ffa1e1219
• Merge pull request #17403 from peppy/editor-exit-harsh-blocking

  Disallow exiting the editor without saving (unless explicitly confirming)

  Dan Balasescu · 2022-03-23 07:45:31 +09:00
  cda46ec8a3
• Merge branch 'master' into editor-exit-harsh-blocking
  Dan Balasescu · 2022-03-23 07:06:25 +09:00
  8591630e5c
• Merge pull request #17384 from peppy/hold-to-discard-changes

  Add hold-to-confirm flow for discarding editor changes

  Dan Balasescu · 2022-03-23 07:05:56 +09:00
  d84865ff76
• Fix unprotected access to potentially-null DI'd dialog overlay
  Bartłomiej Dach · 2022-03-22 22:10:05 +01:00
  51a1721bc9
• Remove unused local variable
  Bartłomiej Dach · 2022-03-22 22:00:24 +01:00
  f3aad77239
• Remove unused using directive
  Bartłomiej Dach · 2022-03-22 22:00:05 +01:00
  a38bafab91
• Merge branch 'master' into hold-to-discard-changes
  Bartłomiej Dach · 2022-03-22 20:37:43 +01:00
  8647bebdca
• Merge pull request #17386 from peppy/skin-editor-eat-input

  Fix keyboard controls not working to adjust skin settings

  Bartłomiej Dach · 2022-03-22 19:52:01 +01:00
  2f01129322
• Merge branch 'master' into skin-editor-eat-input
  Bartłomiej Dach · 2022-03-22 19:22:48 +01:00
  8192fb47fe
• Remove unnecessary local
  Bartłomiej Dach · 2022-03-22 19:13:22 +01:00
  c8d48f89e8