573 Commits

• Migrate the majority of existing file lookups to use new extension methods
  Dean Herbert · 2022-08-10 16:01:16 +09:00
  ac99c1ad69
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Fix new hitobject placements not taking on the existing sample settings

  Similar to velocity / difficulty points, a user expectation is that
  volume and sample settings will be transferred to newly placed objects
  from the most recent one.
  
  Closes https://github.com/ppy/osu/issues/18742.

  Dean Herbert · 2022-06-18 13:49:59 +09:00
  bd5037fcad
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge branch 'master' into use-normalised-precise-scrolling
  Bartłomiej Dach · 2022-05-27 16:55:13 +02:00
  e511c1dfff
• Update screen padding and colouring to better match new designs
  Dean Herbert · 2022-05-24 18:43:22 +09:00
  17206bbebf
• Adjust ScrollDelta usages to account for normalised IsPrecise values
  Susko3 · 2022-05-23 20:22:27 +02:00
  88217e0c98
• Merge pull request #18236 from peppy/snap-unification

  Add `enum` to snap method as alternative to multiple nested invocations

  Dan Balasescu · 2022-05-20 11:35:05 +09:00
  64a371638e
• Add "None" snap type to fix flags not working correctly
  Dean Herbert · 2022-05-19 15:57:17 +09:00
  b3d6f76cfa
• Don't hide SelectionBlueprints themselves, only their children
  Dean Herbert · 2022-05-12 19:26:13 +09:00
  c63e65c677
• Add enum to snap method as alternative to mutliple nested invocations
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  c0abce918f
• Merge branch 'master' into distance-snapping-test
  Salman Ahmed · 2022-05-06 17:29:27 +03:00
  144d33f0d2
• Fix toolbox expand being interrupted by gaps between groups
  Dean Herbert · 2022-05-06 19:06:40 +09:00
  c6bc6be128
• Merge branch 'master' into distance-snapping-test
  Dean Herbert · 2022-05-05 22:00:40 +09:00
  5029710de7
• Merge branch 'master' into snapping-tidy-distance
  Dan Balasescu · 2022-05-05 19:55:55 +09:00
  39d10487b9
• Merge branch 'master' into cache-at-interface
  Dean Herbert · 2022-05-05 18:54:24 +09:00
  e83604a1fc
• Expose DistanceSpacingMultiplier for test usage
  Dean Herbert · 2022-05-05 18:49:12 +09:00
  7b71fb860b
• Add note about IDistanceSnapProvider not multiplying DistanceSpacing itself
  Dean Herbert · 2022-05-05 17:50:17 +09:00
  947a68006a
• Reword weird xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-05-05 17:07:05 +09:00
  c3d2648f85
• Merge branch 'cache-at-interface'
  Dean Herbert · 2022-05-05 16:52:03 +09:00
  4226583afd
• Merge branch 'snapping-tidy-distance'
  Dean Herbert · 2022-05-05 16:51:32 +09:00
  19cf9dc20b
• Remove unnecessary type specification in HitObjectComposer's caching
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  5a1ac71d90
• Move snap provider caching to interfaces
  Dean Herbert · 2022-05-05 16:44:37 +09:00
  1c6a233cc0
• Move IPlacementHandler caching to interface
  Dean Herbert · 2022-05-05 16:43:02 +09:00
  b411b59006
• Add xmldoc for IDistanceSnapProvider and related properties
  Dean Herbert · 2022-05-05 16:25:45 +09:00
  977e6d8a80
• Reword slightly, to allow better conformity with IDistanceSnapProvider
  Dean Herbert · 2022-05-05 16:04:34 +09:00
  1fce0da331
• Add xmldoc and rename methods in IPositionSnapProvider for legibility
  Dean Herbert · 2022-05-05 15:58:21 +09:00
  f6fc926f1a
• Merge branch 'master' into fix-editor-toolbox-click-through
  Bartłomiej Dach · 2022-05-04 11:57:32 +02:00
  bf80dd864c
• Rename value changed variable
  Dean Herbert · 2022-05-04 18:13:30 +09:00
  4e0f899159
• Use ToUpper for key binding text
  Salman Ahmed · 2022-05-04 11:59:29 +03:00
  f5d4f02200
• Improve distance spacing toast inline with key binding changes
  Salman Ahmed · 2022-05-04 11:43:19 +03:00
  0b8fd2e39f
• Combine editor toolbox container implementation and fix input blocking

  Until now, toolbox scroll areas would block input from arriving behind
  them, even when no visible element was clicked.
  
  In addition, clicking on a button inside a toolbox would still send a
  `MouseDown` event to things behind it. Specifically, the editor's
  `HitObjectComposer` would receive these events and also place objects
  when the user does not expect them to be placed.
  
  This fixes another regression that occurred due to `ScrollContainer`s no
  longer blocking input theirselves.

  Dean Herbert · 2022-05-04 17:41:30 +09:00
  b325f0ee0b
• Merge branch 'master' into distance-spacing-osd
  Salman Ahmed · 2022-05-04 11:41:12 +03:00
  3d2072498e
• Remove unused ScrollingToolboxGroup class
  Dean Herbert · 2022-05-04 17:20:58 +09:00
  a66743266f
• Fix scrolling no longer adjusting distance spacing by amount
  Salman Ahmed · 2022-05-04 09:52:33 +03:00
  504ca5be31
• Split activation keybind to separate increase/decrease keybinds
  Salman Ahmed · 2022-05-04 09:00:54 +03:00
  813d6fed48
• Mark OnScreenDisplay dependency as nullable
  Salman Ahmed · 2022-05-03 11:15:28 +03:00
  0dd2e1652c
• Display toast notification on editor distance spacing change
  Salman Ahmed · 2022-05-03 10:30:32 +03:00
  b8287f3687
• Add keybind for distance grid spacing activation
  Salman Ahmed · 2022-05-03 10:15:24 +03:00
  521ec1a225
• Revert "Convert data type of DistanceSpacing to float"

  This reverts commit 7aaa88cac2.

  Salman Ahmed · 2022-04-29 08:02:07 +03:00
  fef94d49f4
• Move distance spacing application to DistanceSnapGrid
  Salman Ahmed · 2022-04-28 10:54:38 +03:00
  abb88b0907
• Convert data type of DistanceSpacing to float
  Salman Ahmed · 2022-04-28 10:24:36 +03:00
  7aaa88cac2
• Minor cleanup

  Just from reading diff.

  Salman Ahmed · 2022-04-28 07:14:43 +03:00
  2e8372fe90
• Let CatchHitObjectComposer inherit from DistancedHitObjectComposer and hide control
  Salman Ahmed · 2022-04-28 06:44:50 +03:00
  bfc6bfc91b
• Introduce DistancedHitObjectComposer and supersede OsuToolboxComposite
  Salman Ahmed · 2022-04-28 06:44:50 +03:00
  835898dd30
• Move distancing methods from IPositionSnapProvider to IDistanceSnapProvider
  Salman Ahmed · 2022-04-28 05:48:45 +03:00
  59cf3ff50f
• Encapsulate distance spacing control handling to a "distance toolbox composite"

  Encapsulated in a way which can allow further extensibility for the
  right-side area of toolboxes.

  Salman Ahmed · 2022-04-24 08:33:03 +03:00
  8ed39009fd
• Move DistanceSpacingMultiplier bindable to its own IDistanceSnapProvider interface
  Salman Ahmed · 2022-04-24 08:33:00 +03:00
  70a93c0e7e
• Merge branch 'master' into osu-distance-spacing
  Salman Ahmed · 2022-04-24 05:23:30 +03:00
  4f8f27a58b