Dean Herbert
|
dd6a06a302
|
Reword xmldoc to read better
|
2021-05-13 16:43:42 +09:00 |
|
Dean Herbert
|
9dfa48b22e
|
Fix incorrect exception text
|
2021-05-13 16:42:43 +09:00 |
|
Dean Herbert
|
19223ba013
|
Remove left-over debug logging
|
2021-05-13 16:42:13 +09:00 |
|
Dean Herbert
|
5818ed4c8c
|
Remove unused DI resolution
|
2021-05-13 16:41:36 +09:00 |
|
Naxess
|
b37cb3bdbe
|
Change interpreted difficulty from bindable to regular value
There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.
|
2021-05-13 09:00:30 +02:00 |
|
Naxess
|
4eeeaf6a1a
|
Keep track of local bound copy
|
2021-05-13 07:57:32 +02:00 |
|
Dean Herbert
|
e0e9106921
|
Enable autoplay in skin editor tests
|
2021-05-13 14:55:11 +09:00 |
|
Naxess
|
e7c7786db3
|
Merge branch 'master' into beatmap-verifier-context
|
2021-05-13 07:40:33 +02:00 |
|
Dean Herbert
|
5b71d8ca37
|
Merge pull request #12758 from Naxesss/verify-settings-ui
Add setting UI components to the verify screen
|
2021-05-13 14:35:35 +09:00 |
|
Dean Herbert
|
b81f86bd4d
|
Move DI resolution to inside BDL parameters
|
2021-05-13 13:54:06 +09:00 |
|
Dean Herbert
|
c6648112e5
|
Simplify binding flow in InterpretationSection
|
2021-05-13 13:51:41 +09:00 |
|
Dean Herbert
|
cdcbaf4291
|
Tidy up specification of SettingsSection
|
2021-05-13 13:45:10 +09:00 |
|
Dean Herbert
|
23e284b8b3
|
Change default skin editor shortcut to Ctrl+Shift+S
Avoids a conflict with song select's random rewind functionality. As
mentioned in #12776.
|
2021-05-13 13:34:04 +09:00 |
|
Dean Herbert
|
db19617b8b
|
Add JsonConstructor attribute to SkinnableTargetWrapper
|
2021-05-13 13:16:20 +09:00 |
|
Dean Herbert
|
3b862798e9
|
Standardise naming of methods related to SkinnableInfo
|
2021-05-13 13:14:49 +09:00 |
|
Dean Herbert
|
581e7940c7
|
Add xmldoc to SkinnableElementTargetContainer
|
2021-05-13 13:13:22 +09:00 |
|
Dean Herbert
|
c93ed541f3
|
Add xmldoc and tidy up logic in Skin
|
2021-05-13 13:09:33 +09:00 |
|
Naxess
|
47948d7b34
|
Set default for bindable in object initializer
Fixes the CI failure.
|
2021-05-13 06:08:48 +02:00 |
|
Dean Herbert
|
992a052426
|
Remove stray comment
|
2021-05-13 13:07:06 +09:00 |
|
Dean Herbert
|
469a7f5d2a
|
Reorder fields in SkinEditor
|
2021-05-13 13:04:17 +09:00 |
|
Dean Herbert
|
2bf8635ffd
|
Move field upwards in class
|
2021-05-13 13:03:23 +09:00 |
|
Dean Herbert
|
a38cb61b08
|
Remove duplicated call to base.GetDrawableComponent
|
2021-05-13 13:02:55 +09:00 |
|
Naxess
|
fb305130de
|
Also refresh when interpreted difficulty changes
|
2021-05-13 06:00:21 +02:00 |
|
Naxess
|
ee0a6ba93e
|
Use local bound copy in InterpretationSection as well
Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.
|
2021-05-13 05:59:49 +02:00 |
|
Dean Herbert
|
6caf4e3879
|
Add xmldoc to SkinnableInfo
|
2021-05-13 12:57:28 +09:00 |
|
Naxess
|
e80d8f6922
|
Keep track of local bound copy
|
2021-05-13 05:46:47 +02:00 |
|
Naxess
|
04c1585eb2
|
Use more consistent lambda discards
|
2021-05-13 05:38:45 +02:00 |
|
Dean Herbert
|
8b9ac86d4b
|
Merge branch 'master' into skin-serialisation
|
2021-05-13 12:35:06 +09:00 |
|
Dean Herbert
|
8bf05e142b
|
Merge pull request #12754 from peppy/skin-instantiation-info
Add `SkinInfo.InstantiationInfo` to allow creating different skin types
|
2021-05-13 12:34:14 +09:00 |
|
Dean Herbert
|
fb13ed52f7
|
Merge pull request #12777 from smoogipoo/fix-test-failure
Fix possible multiplayer test failure
|
2021-05-13 12:33:59 +09:00 |
|
Naxess
|
e86834b740
|
Use local bound copy for HiddenIssueTypes
|
2021-05-13 05:25:20 +02:00 |
|
Naxess
|
c8d21f2c3f
|
Isolate refreshing to IssueList
|
2021-05-13 05:25:02 +02:00 |
|
smoogipoo
|
5b03092968
|
Fix possible test failure
|
2021-05-13 11:53:50 +09:00 |
|
Naxess
|
fbb76ba598
|
Split ShowIssueTypes dict into hidden and configurable lists
This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
Bindings are a bit less neat, though.
|
2021-05-13 04:50:32 +02:00 |
|
Naxess
|
dd8423c4c4
|
Set interpreted difficulty to correct default
|
2021-05-13 04:36:20 +02:00 |
|
Naxess
|
6806e40ad9
|
Remove unnecessary local variable
This now exists in `VerifyScreen`, which we can access from here.
|
2021-05-13 04:30:40 +02:00 |
|
Naxess
|
56bd897666
|
Move ShowIssueTypes to VerifyScreen
|
2021-05-13 04:29:27 +02:00 |
|
Bartłomiej Dach
|
27ca7d0f4f
|
Actually annotate the correct ctor
|
2021-05-12 23:53:39 +02:00 |
|
Bartłomiej Dach
|
a6aec6e007
|
Fix missed InstantiationInfo setter usages
|
2021-05-12 23:34:25 +02:00 |
|
Bartłomiej Dach
|
d31fa20e92
|
Merge branch 'master' into skin-instantiation-info
|
2021-05-12 23:23:57 +02:00 |
|
Bartłomiej Dach
|
1b579dd838
|
Extract invariant instantiation info extension method
|
2021-05-12 23:23:51 +02:00 |
|
Bartłomiej Dach
|
4464204e33
|
Mark all skin ctors used via reflection in SkinInfo.CreateInstance()
|
2021-05-12 23:23:42 +02:00 |
|
Andrei Zavatski
|
315a2b8314
|
Refactor MonthDropdown to decouple autosized logic
|
2021-05-12 20:50:20 +03:00 |
|
Andrei Zavatski
|
13a956f6fc
|
Merge remote-tracking branch 'refs/remotes/ppy/master' into news-sidebar-new
|
2021-05-12 20:08:17 +03:00 |
|
Dean Herbert
|
7bac81f394
|
Fix incorrect inline comments
Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>
|
2021-05-12 19:37:00 +09:00 |
|
Dan Balasescu
|
4e7c079560
|
Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency
Remove downwards dependency from `HUDOverlay` to `HealthDisplay`
|
2021-05-12 19:27:02 +09:00 |
|
Dean Herbert
|
55e1f97f59
|
Remove unused using statement
|
2021-05-12 19:06:40 +09:00 |
|
Dean Herbert
|
75227e5a70
|
Change default skin to use component lookup for conformity
|
2021-05-12 18:55:48 +09:00 |
|
Dean Herbert
|
0a895fff15
|
Remove remaining test usage of SkinnableXXX HUD components
|
2021-05-12 18:53:25 +09:00 |
|
Dean Herbert
|
088335a035
|
Revert "Also save on skin switch"
This reverts commit 2f55d1e5ab.
|
2021-05-12 17:45:51 +09:00 |
|