5655 Commits

• Adjust testing methodology to improve reliability of mosue wheel volume adjust tests

  There was previously a potential in headless runs for timing
  discrepancies to cause the volume to never get adjusted.
  
  As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.

  Dean Herbert · 2021-12-23 13:25:24 +09:00
  d31c9db08b
• Merge pull request #16213 from peppy/working-beatmap-live

  Tidy up `WorkingBeatmap`

  Dan Balasescu · 2021-12-23 13:02:37 +09:00
  e1b539fa9e
• Adjust existing placeholder test to demonstrate failure case
  Bartłomiej Dach · 2021-12-22 15:03:20 +01:00
  02fa1c21b7
• Remove unused load checks
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  f3f491374b
• Remove BeatmapSetInfo and Metadata from interface

  There were very few accesses to this, and after realm they should all be
  done via the `BeatmapInfo`, so let's remove this.

  Dean Herbert · 2021-12-22 18:17:00 +09:00
  967419c9ac
• Merge pull request #16205 from smoogipoo/fix-multiplayer-tests

  Fix multiplayer test failures when checking for parted room

  Dean Herbert · 2021-12-22 13:42:05 +09:00
  cfdfe81afb
• Merge pull request #16198 from smoogipoo/fix-current-item-before-population

  Fix delete button showing on current item before beatmap retrieval

  Dean Herbert · 2021-12-22 13:15:07 +09:00
  a88800c99a
• Fix multiplayer test failures when checking for parted room
  Dan Balasescu · 2021-12-22 12:55:37 +09:00
  24c6f8fafa
• Fix delete button test failures

  Can be tested by adding a Thread.Sleep() in
  DrawableRoomPlaylistItem.load().

  Dan Balasescu · 2021-12-22 09:55:19 +09:00
  ee64ab6383
• Merge pull request #16197 from bdach/beatmap-card/renames

  Rename beatmap card-related classes

  Dean Herbert · 2021-12-21 18:51:34 +09:00
  0bda7892f7
• Fix test
  Dan Balasescu · 2021-12-21 18:38:31 +09:00
  e2f8c71081
• Merge pull request #16194 from peppy/fix-results-screen-wait-test

  Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step

  Dan Balasescu · 2021-12-21 16:56:49 +09:00
  a53c67b2ea
• Rename BeatmapCard{ => Normal}
  Bartłomiej Dach · 2021-12-21 08:26:21 +01:00
  88d4e95ad8
• Merge pull request #16012 from bdach/beatmap-card/extra

  Implement "extra" beatmap card size

  Dean Herbert · 2021-12-21 15:40:33 +09:00
  2707b2fbda
• Fix intermittent test failures on TestSceneResultsScreen due to long delay step

  Using real time delays of 3 seconds doesn't play well with headless runs.

  Dean Herbert · 2021-12-21 15:15:05 +09:00
  c0a8758839
• Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure

  Fix intermittent failures on `TestSceneBeatmapListingOverlay`

  Dan Balasescu · 2021-12-21 15:11:25 +09:00
  a8cd96278d
• Fix intermittent failures on TestSceneBeatmapListingOverlay

  In the specific method, there was no wait step after the initial fetch
  (unlike all of the rest), meaning the fetch may not have finished in
  time for the follow-up steps.
  
  As seen at
  https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.

  Dean Herbert · 2021-12-21 14:12:06 +09:00
  0f8a6a3f64
• Add note about local button clicking usage
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  bb3f375958
• Remove unused method in TestSceneMultiplayerQueueList
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  aad55ef89e
• Centralise all multiplayer button clicking test logic

  This adds the "wait for enabled" check in a way that can be easily
  reused, as it keeps getting missed in test implementations.
  
  This particular commit hopefully fixes
  https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.

  Dean Herbert · 2021-12-21 13:49:51 +09:00
  9aff646ff4
• Merge branch 'master' into beatmap-card/extra
  Bartłomiej Dach · 2021-12-20 15:49:00 +01:00
  f1a03aced5
• Merge branch 'master' into fix-song-select-test-failure
  Bartłomiej Dach · 2021-12-20 11:36:49 +01:00
  0b7daf542f
• Ensure presence of at least 1 difficulty for each ruleset
  Bartłomiej Dach · 2021-12-20 11:34:39 +01:00
  f492cf84d9
• Merge branch 'master' into fix-ready-button-test
  Bartłomiej Dach · 2021-12-20 11:02:43 +01:00
  d8be455a43
• Rename TestMultiplayerScreenStack to TestMultiplayerComponents
  Dean Herbert · 2021-12-20 18:24:59 +09:00
  ec0a6735eb
• Name some screen stacks for better logging context
  Dean Herbert · 2021-12-20 18:24:14 +09:00
  6907a9a3cc
• Add better defined steps to TestLoseHostWhileReady ready button test

  Not 100% sure this will solve the issue but it's worth a try. The button
  state checks are using `Until` everywhere else so this brings the test
  in line with the standards.
  
  As seen
  https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.

  Dean Herbert · 2021-12-20 17:47:06 +09:00
  87051d5d61
• Chooser earlier items in song select tests to avoid potentially not having enough
  Dean Herbert · 2021-12-20 17:11:15 +09:00
  5c8e317a6e
• Fix weird loop logic
  Dean Herbert · 2021-12-20 17:09:08 +09:00
  af78a3e99d
• Add wait step to TestScenePlaylistResultScreen explicitly for screen load
  Dean Herbert · 2021-12-20 16:58:36 +09:00
  d79602a912
• Merge pull request #16164 from smoogipoo/fix-intermittent-background-test

  Fix intermittent background screen test failures

  Dean Herbert · 2021-12-20 14:00:53 +09:00
  2e47c4e25d
• Better fix for intermittent multiplayer tests
  Dan Balasescu · 2021-12-20 13:10:13 +09:00
  9316abc278
• Wait for previous screen to be hidden in test
  Dan Balasescu · 2021-12-20 12:44:23 +09:00
  11f3ec0cb5
• Add test for ranked/unranked user display
  Bartłomiej Dach · 2021-12-19 13:40:22 +01:00
  097402677d
• Bring profile header test in line with modern conventions

  - Removed online code that didn't work anyway after the introduction of
    the development web instance.
  
  - Removed some weird test steps.
  
  - Fixed online/offline test steps not working at all due to identical
    user ID.

  Bartłomiej Dach · 2021-12-19 13:40:21 +01:00
  c112177559
• Fix tests
  Bartłomiej Dach · 2021-12-17 11:45:01 +01:00
  883fcf2604
• Merge branch 'master' into beatmap-card/extra-wip
  Bartłomiej Dach · 2021-12-17 11:11:36 +01:00
  c6d0b5d200
• Merge branch 'master' into fix-realm-post-storage-migration-failure
  Bartłomiej Dach · 2021-12-17 00:19:46 +01:00
  54790bb758
• Don't show multiplayer channels in chat overlay
  Dan Balasescu · 2021-12-16 16:41:47 +09:00
  488374b4a2
• Merge branch 'master' into beatmap-card-expanded-state-fix
  Bartłomiej Dach · 2021-12-15 22:20:30 +01:00
  cbb65e1e07
• Merge branch 'master' into forego-resetting-spectate-state
  Dean Herbert · 2021-12-15 18:05:06 +09:00
  9e82a3e79a
• Don't reset spectating state if gameplay is finished
  Dan Balasescu · 2021-12-15 17:40:30 +09:00
  18d7b79207
• Add test coverage of same scenario without deletion
  Dean Herbert · 2021-12-15 17:30:09 +09:00
  39a0a21132
• Add another until step to guard against async test issues
  Dan Balasescu · 2021-12-15 17:00:06 +09:00
  d22e1b9001
• Fix exception when updating the room's visual playlist
  Dan Balasescu · 2021-12-15 16:53:25 +09:00
  740a6f16c7
• Add failing test showing expanded state being unexpectedly lost
  Dean Herbert · 2021-12-15 16:26:19 +09:00
  e9187cc3cf
• Merge pull request #16083 from peppy/fix-online-availability-after-reimport

  Fix `OnlinePlayBeatmapAvailabilityTracker` failng after modified reimport of existing beatmap

  Dan Balasescu · 2021-12-15 08:31:02 +09:00
  2cea39a92a
• Remove whitespace
  Dan Balasescu · 2021-12-15 07:33:49 +09:00
  da00c020be
• Merge branch 'master' into fix-menu-background-desync
  Bartłomiej Dach · 2021-12-14 21:31:10 +01:00
  00154fe86d
• Add back PlaylistRoomCreation test

  Was spiritually removed in https://github.com/ppy/osu/pull/16045.
  
  This implementation is mostly taken from that PR's comment thread
  verbatim, and now works due to the associated changes to
  `OnlinePlayBeatmapAvailabilityTracker`.

  Dean Herbert · 2021-12-14 19:16:52 +09:00
  0950d8d327